New issue
Advanced search Search tips

Issue 757022 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make an experiment where all TaskScheduler tasks run with TaskPriority::USER_BLOCKING.

Project Member Reported by fdoray@chromium.org, Aug 18 2017

Issue description

This is useful to assess the impact of annotating tasks with priorities.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f7e1a4d6160d0194bd507bb151b016e6cff17c

commit d9f7e1a4d6160d0194bd507bb151b016e6cff17c
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Aug 22 20:20:40 2017

Add option to run all TaskScheduler tasks with TaskPriority::USER_BLOCKING.

This is useful to assess the impact of annotating tasks with priorities.
A separate CL will allow this option to be enabled via a field trial.

Bug:  757022 
Change-Id: I22f176a66de2c25200299da2083c5e01319f51d3
Reviewed-on: https://chromium-review.googlesource.com/621294
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496422}
[modify] https://crrev.com/d9f7e1a4d6160d0194bd507bb151b016e6cff17c/base/task_scheduler/task_scheduler.cc
[modify] https://crrev.com/d9f7e1a4d6160d0194bd507bb151b016e6cff17c/base/task_scheduler/task_scheduler.h
[modify] https://crrev.com/d9f7e1a4d6160d0194bd507bb151b016e6cff17c/base/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/d9f7e1a4d6160d0194bd507bb151b016e6cff17c/base/task_scheduler/task_scheduler_impl.h
[modify] https://crrev.com/d9f7e1a4d6160d0194bd507bb151b016e6cff17c/base/task_scheduler/task_scheduler_impl_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a

commit fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Aug 25 19:44:58 2017

Make all TaskScheduler tasks USER_BLOCKING via a field trial.

This CL allows a field trial to make all TaskScheduler tasks
USER_BLOCKING. This will be used to assess the impact of annotating
tasks with priorities.

Bug:  757022 
Change-Id: I7c5762395815b9b9de6c99c5fecb2a086bdc24b1
Reviewed-on: https://chromium-review.googlesource.com/634524
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497504}
[modify] https://crrev.com/fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a/base/task_scheduler/task_scheduler.cc
[modify] https://crrev.com/fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a/base/task_scheduler/task_scheduler.h
[modify] https://crrev.com/fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a/base/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a/base/task_scheduler/task_scheduler_impl.h
[modify] https://crrev.com/fbfcc6bb3ad5e97a501bd1e7d96dd093675fee7a/base/task_scheduler/task_scheduler_impl_unittest.cc

Comment 3 by fdoray@chromium.org, Oct 27 2017

Status: Fixed (was: Started)

Comment 4 by gab@chromium.org, Oct 31 2017

Did we remove the experimental hooks before calling this fixed? (We can
always revert later for reuse but at least we don't have to maintain unused
code until then)

Le ven. 27 oct. 2017 16 h 36, fdoray via monorail <
monorail+v2.3491009315@chromium.org> a écrit :
At the very least, there's still a comment with a TODO referring to this bug in base/task_scheduler/task_scheduler_impl.h.

Sign in to add a comment