devserver: apache_log_metrics crashing on import MakeLogHandler |
|||||||
Issue description
root@chromeos6-devserver4:/var/log/devserver# tail -n 10 devserver_apache_access_log_metrics.log
Traceback (most recent call last):
File "/home/chromeos-test/chromiumos/src/platform/dev/apache_log_metrics.py", line 20, in <module>
from devserver_lib.devserver import MakeLogHandler
ImportError: No module named devserver_lib.devserver
Fri Aug 18 11:46:46 PDT 2017 upstart_apache_log_metrics: starting.
Fri Aug 18 11:46:46 PDT 2017 devserver_apache_access_log_metrics: started.
Traceback (most recent call last):
File "/home/chromeos-test/chromiumos/src/platform/dev/apache_log_metrics.py", line 20, in <module>
from devserver_lib.devserver import MakeLogHandler
ImportError: No module named devserver_lib.devserver
I'm not sure if this is directly contributing to the devserver job crash-looping.
,
Aug 18 2017
,
Aug 18 2017
phobbs@ tells me he made some changes around this to re-enable the code. He also says that the failure isn't any kind of blocker...
,
Aug 18 2017
Yeah, this isn't critical. I was trying to re-enable the script; apparently, the devserver_lib import is broken under virtualenv.
,
Aug 18 2017
sorry, #5 is false alarm, old error log
,
Aug 18 2017
,
Aug 21 2017
The fix is pending code review.
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/fe0b1c698b50605f8b6d87c6c7237cc065fe99ce commit fe0b1c698b50605f8b6d87c6c7237cc065fe99ce Author: Paul Hobbs <phobbs@google.com> Date: Sat Aug 26 02:54:16 2017 apache_log_metrics: Remove dependency on devserver_lib Don't import devserver_lib just to set up a rotating log handler. BUG= chromium:757002 TEST=unit tests Change-Id: I00170a962ab5dcb63d0c980331371dbe79db0494 Reviewed-on: https://chromium-review.googlesource.com/621780 Commit-Ready: Paul Hobbs <phobbs@google.com> Tested-by: Paul Hobbs <phobbs@google.com> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/fe0b1c698b50605f8b6d87c6c7237cc065fe99ce/apache_log_metrics.py
,
Aug 31 2017
,
Sep 18 2017
Above fix caused stacktrace discussed on dupe'd bug. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pprabhu@chromium.org
, Aug 18 2017