New issue
Advanced search Search tips

Issue 756998 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

32 kb regression in resource_sizes (MonochromePublic.apk) at 495505:495505

Project Member Reported by estevenson@chromium.org, Aug 18 2017

Issue description

Caused by "Remove compile flag for out-of-process heap-profiling."

Commit 49bbfa2c69b0e6f8e87c2ce234b09ec7fd1d3fa1

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=495505

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

All growth comes from native code size.

It's not clear to me whether or not this increase was expected. Is this used on Android? Please have a look and either:
  
  1. Close as “Won't Fix” with a short justification, or
  2. Land a revert / fix-up.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 18 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=756998

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1b5db4f941908f63cf025f406ba905ca32ed6222b6acc99473c2e54574df7775


Bot(s) for this bug's original alert(s):

Android Builder
Labels: OS-Android
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
See attached diff for details.

erikchen@ - can you take a look?
diff_results.txt
93.4 KB View Download
Status: WontFix (was: Assigned)
This CL in question removed a compile time flag for a feature [out of process heap profiling]. This introduced ~30k bytes of native code. This is expected.

Sign in to add a comment