New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756976 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

The base::win::OSInfo::version_type value should distinguish enterprise VS pro types.

Project Member Reported by mad@chromium.org, Aug 18 2017

Issue description

We currently merge the PRODUCT_PROFESSIONAL, PRODUCT_ULTIMATE, PRODUCT_ENTERPRISE, PRODUCT_BUSINESS Windows version type into a single value; SUITE_PROFESSIONAL. We should at least split it in two, to get a feel of how many Chrome users run on an enterprise/business version as opposed to a pro/ultimate version.

 
Cc: blumberg@chromium.org

Comment 2 by mad@chromium.org, Aug 22 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75bf659b1220d2e2e20c1baaf3f7c7369b41bd30

commit 75bf659b1220d2e2e20c1baaf3f7c7369b41bd30
Author: Marc-André (MAD) Decoste <mad@chromium.org>
Date: Tue Aug 22 21:46:35 2017

Add Enterprise and Education Windows version types.

BUG= 756976 

Change-Id: I37050ae2c933ef7b75f22cba94a31a83f35f4215
Reviewed-on: https://chromium-review.googlesource.com/626380
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496456}
[modify] https://crrev.com/75bf659b1220d2e2e20c1baaf3f7c7369b41bd30/base/win/windows_version.cc
[modify] https://crrev.com/75bf659b1220d2e2e20c1baaf3f7c7369b41bd30/base/win/windows_version.h

Comment 4 by mad@chromium.org, Aug 22 2017

Status: Fixed (was: Started)
I also added another entry for education. 
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320a8bcebb87d98085b805d82717598d9a1ff754

commit 320a8bcebb87d98085b805d82717598d9a1ff754
Author: Marc-André (MAD) Decoste <mad@chromium.org>
Date: Wed Aug 23 19:42:33 2017

Added more OsSuites

As added in commit 75bf659b1220d2e2e20c1baaf3f7c7369b41bd30

Bug:  756976 
Change-Id: Ie6327b64bb66261928c84b349d200605478b7a51
Reviewed-on: https://chromium-review.googlesource.com/627580
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496770}
[modify] https://crrev.com/320a8bcebb87d98085b805d82717598d9a1ff754/tools/metrics/histograms/enums.xml

Sign in to add a comment