New issue
Advanced search Search tips

Issue 756970 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

System font settings not respected for Apps (and some other non-Tab-WebContents that don't have a PrefsTabHelper)

Reported by bau...@gmail.com, Aug 18 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.49 Safari/537.36

Steps to reproduce the problem:
0.use standard screen resolution PC with mouse (1920x1080 for example). Disable Cleartype, disable font smoothing.
1. choice to create new chrome session

or open apps from chrome://apps (example keep; teamviewer..)

What is the expected behavior?
use the same setting as defined in the system OS, and the same as used in chrome tab

What went wrong?
All text are blur And tired, bad for our eyes  when not use 4K screen.  I prefer to see bad roboto font (easy made for android tiny screen high density, but never for PC screen)

Did this work before? Yes 

Chrome version: 61.0.3163.49  Channel: beta
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
blur_popup-only.png
66.0 KB View Download
blur.png
29.0 KB View Download
Cc: rbasuvula@chromium.org
Labels: Needs-Feedback Needs-Triage-M61
Thanks for filing the issue! Tested in chrome #61.0.3163.49, Canary #62.0.3191.0 on win 7 and not able to reproduce the issue.Please find the screen shots for your reference.

@ baudav: Could you please let me know if i have missed anything and if possible,Please create new profile without extensions and apps.Re-check once and let us know the observations of the issue which would help us to triage the issue further.

Thanks in Advance.
756970.PNG
284 KB View Download

Comment 2 by bau...@gmail.com, Aug 21 2017

I see in your capture, you use cleartype (red/blue effect) and this force the font smoothing. Problem is when set on the system No cleartype, No fontsmooth; it's respected in the chrome tab, all website, but not in Google Apps popup.

-disable ClearType (no work fine for all LCD, The fonts are less fine, less clear and with a fat/blur effect)
-disable smooth font (add blur effect for smooth)
-compare in the new tab keep.google.com and apps google Keep (from webstore)  or other apps.

and check again. Chrome respects this configuration for web pages and shortcut in desktop to new windows, but not for the chrome application
zoom756970.png
5.2 MB View Download
cleartype disabled(no red-blue blur).png
7.5 KB View Download
smooth font disabled(no blur font).png
14.1 KB View Download
perfect-screenfont in chrome tab.png
11.0 KB View Download
no blur-no cleartype(perfect).png
13.0 KB View Download
chrome apps example blur with good font (not roboto).png
11.9 KB View Download
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 21 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: e...@chromium.org
Components: -UI Blink>Fonts

Comment 5 by e...@chromium.org, Aug 22 2017

Components: -Blink>Fonts Platform>Apps
Summary: System font settings not respected for Apps (was: please respect font system setting (no blur) and our eyes)
Cc: pbomm...@chromium.org tapted@chromium.org
tapted@ for more insights on Chrome App fonts.

Comment 7 by tapted@chromium.org, Aug 23 2017

Cc: benwells@chromium.org
Status: Available (was: Unconfirmed)
Summary: System font settings not respected for Apps (and some other non-Tab-WebContents that don't have a PrefsTabHelper) (was: System font settings not respected for Apps)
app_window_contents.cc is missing a call to renderer_preferences_util::UpdateFromSystemSettings(content::RendererPreferences* prefs..). Usually PrefsTabHelper does this, but only tabs have those.

AppWindowContentsImpl::Initialize needs to look something like


void AppWindowContentsImpl::Initialize(content::BrowserContext* context,
                                       content::RenderFrameHost* creator_frame,
                                       const GURL& url) {
  ...
  Observe(web_contents_.get());
  content::RendererPreferences* render_prefs =
      web_contents_->GetMutableRendererPrefs();
  renderer_preferences_util::UpdateFromSystemSettings(render_prefs,
                                                      context,
                                                      web_contents_);
  render_prefs->browser_handles_all_top_level_requests = true;
  web_contents_->GetRenderViewHost()->SyncRendererPrefs();
}


but renderer_preferences_util is in src/chrome which needs to call via ExtensionsBrowserClient

Comment 8 by tapted@chromium.org, Aug 23 2017

Cc: a...@chromium.org
+avi - do you have any thoughts about adding a ContentBrowserClient method for this? (i.e. something like

void ContentBrowserClient::FillDefaultRendererPrefs(BrowserContext* browser_context, content::RendererPreferences* renderer_prefs);


A lot of other font preferences are set in 

void ChromeContentBrowserClient::OverrideWebkitPrefs(RenderViewHost* rvh, WebPreferences* web_prefs) - https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_client.cc?q=ChromeContentBrowserClient::OverrideWebkitPrefs&sq=package:chromium&l=2373

So a more robust alternative to #c7 might be to make setting default RendererPreferences the responsibility of the ContentBrowserClient. This could allow a WebContents to pick up a meaningful default set of RendererPreferences rather relying on the client code to invoke renderer_preferences_util::UpdateFromSystemSettings().

There is some other important stuff there - https://cs.chromium.org/chromium/src/chrome/browser/renderer_preferences_util.cc?type=cs&q=UpdateFromSystemSettings&sq=package:chromium&l=85

This approach would mean the "Manage People" account picker dialog also gets the correct values, which #c7 doesn't attempt to solve.

Comment 9 by a...@chromium.org, Aug 23 2017

Cc: jam@chromium.org
+jam for his thoughts

I think this would be a reasonable approach; John, what do you think?

Comment 10 by bau...@gmail.com, Sep 3 2017

same problem with dev Tools(F12), all menu and setting are blur
https://i.imgur.com/5E6xNb4.png
+the first page before enable sync with google is blurry
chrome_2018-08-19_20-38-14.png
118 KB View Download

Sign in to add a comment