Issue 756954 link

Starred by 1 user

Issue metadata

Status:	Untriaged
Owner:	----
Cc:	█ hzl@chromium.org jbudorick@chromium.org
Components:	Test>Android
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug
Hotlist-Recharge-Cold

startMainActivityWithURL will not crash when given predefined intentionally crashing url

Project Member Reported by hzl@chromium.org, Aug 18 2017

Issue description

startMainActivityWithURL used to crash when given a url such as "chrome://crash". And we have been using this method for some time in IntentionalCrashTest class. However recently the test cases in the class do not fail anymore.

The interesting thing is that if we visit these pages by 'mActivityTestRule.startMainActivityFromLauncher();            
 mActivityTestRule.loadUrl("chrome://inducebrowsercrashforrealz");', then the test case will crash. I suspect that startMainActivityWithURL will circumvent the logic in loadUrl that checks whether the url is a predefined intentionally crashing url.

Comment 1 by jbudorick@chromium.org, Aug 18 2017

Components: Test>Android
Labels: OS-Android
Status: Available (was: Untriaged)

Comment 2 by hzl@chromium.org, Aug 18 2017

snippet of testRendererCrash passing:
D   37.534s run_tests_on_device(ZX1G2268HX)  raw output from org.chromium.chrome.test.crash.IntentionalCrashTest#testRendererCrash:
D   37.534s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   37.534s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=
D   37.534s run_tests_on_device(ZX1G2268HX)    org.chromium.chrome.test.crash.IntentionalCrashTest:
D   37.534s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   37.534s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testRendererCrash
D   37.534s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 1
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=.
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testRendererCrash
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 0
D   37.535s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_RESULT: stream=
D   37.535s run_tests_on_device(ZX1G2268HX)    
D   37.535s run_tests_on_device(ZX1G2268HX)    Time: 1.617
D   37.535s run_tests_on_device(ZX1G2268HX)    
D   37.536s run_tests_on_device(ZX1G2268HX)    OK (1 test)
D   37.536s run_tests_on_device(ZX1G2268HX)    
D   37.536s run_tests_on_device(ZX1G2268HX)    
D   37.536s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_CODE: -1

Comment 3 by hzl@chromium.org, Aug 18 2017

I tested all the test cases in IntentionalCrashTest, and all of them are suspiciously passing, very weird.

Passing BrowserCrash:
D   68.919s run_tests_on_device(ZX1G2268HX)  raw output from org.chromium.chrome.test.crash.IntentionalCrashTest#testBrowserCrash:
D   68.919s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   68.919s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=
D   68.920s run_tests_on_device(ZX1G2268HX)    org.chromium.chrome.test.crash.IntentionalCrashTest:
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testBrowserCrash
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 1
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=.
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testBrowserCrash
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 0
D   68.920s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_RESULT: stream=
D   68.921s run_tests_on_device(ZX1G2268HX)    
D   68.921s run_tests_on_device(ZX1G2268HX)    Time: 1.607
D   68.921s run_tests_on_device(ZX1G2268HX)    
D   68.921s run_tests_on_device(ZX1G2268HX)    OK (1 test)
D   68.921s run_tests_on_device(ZX1G2268HX)    
D   68.921s run_tests_on_device(ZX1G2268HX)    
D   68.921s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_CODE: -1

Passing java crash:
D   37.510s run_tests_on_device(ZX1G2268HX)  raw output from org.chromium.chrome.test.crash.IntentionalCrashTest#testJavaCrash:
D   37.510s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   37.510s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=
D   37.510s run_tests_on_device(ZX1G2268HX)    org.chromium.chrome.test.crash.IntentionalCrashTest:
D   37.510s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   37.510s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testJavaCrash
D   37.510s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   37.510s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 1
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=.
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testJavaCrash
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 0
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_RESULT: stream=
D   37.511s run_tests_on_device(ZX1G2268HX)    
D   37.511s run_tests_on_device(ZX1G2268HX)    Time: 1.702
D   37.511s run_tests_on_device(ZX1G2268HX)    
D   37.511s run_tests_on_device(ZX1G2268HX)    OK (1 test)
D   37.511s run_tests_on_device(ZX1G2268HX)    
D   37.511s run_tests_on_device(ZX1G2268HX)    
D   37.511s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_CODE: -1

# Passing testGpuCrash:
D   37.852s run_tests_on_device(ZX1G2268HX)  raw output from org.chromium.chrome.test.crash.IntentionalCrashTest#testGpuCrash:
D   37.852s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   37.852s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=
D   37.852s run_tests_on_device(ZX1G2268HX)    org.chromium.chrome.test.crash.IntentionalCrashTest:
D   37.852s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   37.852s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testGpuCrash
D   37.852s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   37.852s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 1
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: numtests=1
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: stream=.
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: test=testGpuCrash
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.crash.IntentionalCrashTest
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS: current=1
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_STATUS_CODE: 0
D   37.853s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_RESULT: stream=
D   37.853s run_tests_on_device(ZX1G2268HX)    
D   37.853s run_tests_on_device(ZX1G2268HX)    Time: 1.713
D   37.853s run_tests_on_device(ZX1G2268HX)    
D   37.853s run_tests_on_device(ZX1G2268HX)    OK (1 test)
D   37.853s run_tests_on_device(ZX1G2268HX)    
D   37.854s run_tests_on_device(ZX1G2268HX)    
D   37.854s run_tests_on_device(ZX1G2268HX)    INSTRUMENTATION_CODE: -1

I suspect that recent changes in startMainActivityWithURL might have caused this.

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64ead141db8d55acd2abe6179b794e73f006f164

commit 64ead141db8d55acd2abe6179b794e73f006f164
Author: Zhiling Huang <hzl@chromium.org>
Date: Fri Aug 18 22:08:58 2017

Make IntentionalCrashTest#testBrowserCrash crash again.

IntentionalCrashTest was crashing, but recently all the test cases are
passing.

I suspect that the cause is due to recent changes in
startMainActivityWithURL. This cl changes all test cases to not
call startMainActivityWithURL, but call two separate methods,
startMainActivityFromLauncher and then loadUrl, which will predictably
produce crashes.

Another issue is that the predefined crashing url is
'chrome://java-crash/' instead of 'chrome://java-crash'.

Bug: 756954
Change-Id: Ic827a1a8b6c0f4bab7b67e17501dafe67d11e015
Reviewed-on: https://chromium-review.googlesource.com/621293
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495711}
[modify] https://crrev.com/64ead141db8d55acd2abe6179b794e73f006f164/chrome/android/javatests/src/org/chromium/chrome/test/crash/IntentionalCrashTest.java

Project Member

Comment 5 by sheriffbot@chromium.org, Aug 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

►

Issue 756954 link

Issue metadata

startMainActivityWithURL will not crash when given predefined intentionally crashing url

Issue description

Comment 1 by jbudorick@chromium.org, Aug 18 2017

Comment 1 Deleted

Comment 2 by hzl@chromium.org, Aug 18 2017

Comment 2 Deleted

Comment 3 by hzl@chromium.org, Aug 18 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Aug 18 2017

Comment 4 Deleted

Comment 5 by sheriffbot@chromium.org, Aug 20

Comment 5 Deleted

Sign in to add a comment