New issue
Advanced search Search tips

Issue 756950 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Re-enable Context suggestions tests for iPhone idiom.

Project Member Reported by michaeldo@chromium.org, Aug 18 2017

Issue description

The following Content Suggestions egtests need to be fixed for iPhone:
- testSwipeToDismissReadingListItem
- testReadingListOpenNewTab
- testMostVisitedNewTab

The CLs which caused the failure are:
https://chromium-review.googlesource.com/c/619088
https://chromium-review.googlesource.com/c/619151
https://chromium-review.googlesource.com/c/620656
 
2 of the CLs were reverted so I've only testSwipeToDismissReadingListItem was disabled.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2084d0274e99a6a5de25148fca67ded219682a2a

commit 2084d0274e99a6a5de25148fca67ded219682a2a
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Aug 18 21:56:21 2017

Disable content suggestions egtest on iPhone.

Bug:  756950 
Change-Id: Id18bf811b8e90d38fcea997a620bdb1acaf8c02c
Reviewed-on: https://chromium-review.googlesource.com/621412
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495706}
[modify] https://crrev.com/2084d0274e99a6a5de25148fca67ded219682a2a/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20dd4fb040ec9b74ed7038bbda0a7ac3a2652e88

commit 20dd4fb040ec9b74ed7038bbda0a7ac3a2652e88
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Aug 21 15:22:55 2017

Reenable testSwipeToDismissReadingListItem

The test was failing on iPhone 5s because the toolbar menu was not
visible. This is because the iPhone 5s screen is smaller, so the test
has to scroll.

Bug:  756950 
Change-Id: I53cf387ec8a2250c88446180a4607ec958f33ff7
Reviewed-on: https://chromium-review.googlesource.com/623088
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495937}
[modify] https://crrev.com/20dd4fb040ec9b74ed7038bbda0a7ac3a2652e88/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment