New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756945 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 757067
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 731558



Sign in to add a comment

webkit_python_tests fails on LUCI linux_chromium_rel_ng but not regular linux_chromium_rel_ng

Project Member Reported by jbudorick@chromium.org, Aug 18 2017

Issue description

Appears to be a new failure as of this week w/ tansell's migration of webkit_python_tests to src/-side specs. They were previously special-cased to run on linux_chromium_rel_ng but not its LUCI equivalent.
 

Comment 1 by estaab@chromium.org, Aug 18 2017

Cc: no...@chromium.org

Comment 2 by no...@chromium.org, Aug 18 2017

Blocking: 731558

Comment 3 by no...@chromium.org, Aug 18 2017

Owner: no...@chromium.org
Status: Started (was: Untriaged)
looks like webkit's https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder.py
searches for depot tools. I will fix it to use he depot tools in //src/third_party/depot_tools

Comment 4 by no...@chromium.org, Aug 18 2017

Blockedon: 727976

Comment 5 by no...@chromium.org, Aug 18 2017

Blockedon: -727976
not entirely blocked on, but very related to bug 727976
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94

commit dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94
Author: Nodir Turakulov <nodir@google.com>
Date: Fri Aug 18 22:47:06 2017

Fix depot_tools path resolution

path_finder searches for depot_tools is present in the sys.path or env.
This does not work on LUCI.

depot_tools was depsed into src.git, so a better way to implement this (and
that's what other "find depot tools" scripts do now) is to expect depot_tools
to be in //src/third_party.

R=dranke@chromium.org
BUG= 756945 , 730686

Change-Id: Ie7b6480704fa07921e30efabdc11aef80a9a969e
Reviewed-on: https://chromium-review.googlesource.com/621874
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495721}
[modify] https://crrev.com/dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder.py
[modify] https://crrev.com/dd2839ebeaefbc8a0e66b98b4bea08bb72d95b94/third_party/WebKit/Tools/Scripts/webkitpy/common/path_finder_unittest.py

Comment 7 by no...@chromium.org, Aug 22 2017

new failure in https://luci-milo.appspot.com/swarming/task/3821189b58826c10 is different from the previous one https://ci.chromium.org/swarming/task/3816a38ffe8ea610

The following tests failed:

 Run on OS: 'Ubuntu-14.04'
 Total tests: 68894
 * Passed: 58415 (58384 expected, 31 unexpected)
 * Skipped: 8934 (8934 expected, 0 unexpected)
 * Failed: 1508 (1486 expected, >>>22 unexpected<<<)
 * Flaky: 37 (37 expected, 0 unexpected)
 
 Unexpected Failures:
 * external/wpt/WebCryptoAPI/generateKey/failures.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_AES-CBC.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_AES-CTR.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_AES-GCM.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_AES-KW.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_ECDH.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_ECDSA.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_HMAC.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_RSA-PSS.worker.html
 * external/wpt/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_AES-CBC.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_AES-CTR.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_AES-GCM.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_AES-KW.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_ECDH.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_ECDSA.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_HMAC.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html
 * external/wpt/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html
 

Comment 8 by no...@chromium.org, Sep 5 2017

Mergedinto: 757067
Status: Duplicate (was: Started)

Sign in to add a comment