New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756896 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

assertion triggered for adding reviewer to revert

Project Member Reported by st...@chromium.org, Aug 18 2017

Issue description

https://pantheon.corp.google.com/errors/1587803913566185768

It seems the email address is with @some.domain.
 

Comment 1 by chanli@chromium.org, Aug 18 2017

Another issue here is that the assertion failure cause Findit post message on the revert CL repeatly.

Comment 2 by st...@chromium.org, Aug 18 2017

Labels: -Pri-2 Pri-1
The revert CL is https://chromium-review.googlesource.com/c/621287

bump up priority

Comment 3 by chanli@chromium.org, Aug 18 2017

The root cause of this assertion error is because one of the sheriff's email address is in wrong format: xxx@chromium.org@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/64878ca445cbe64dc0023778ac5cda522aa2eadd

commit 64878ca445cbe64dc0023778ac5cda522aa2eadd
Author: Chan <chanli@chromium.org>
Date: Mon Aug 21 22:32:08 2017

[Findit] Fix bug when getting sheriff's emails

Bug:  756896 
Change-Id: I5b2623c11cb9cdc581b55375230e6a6087286588
Reviewed-on: https://chromium-review.googlesource.com/624460
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/64878ca445cbe64dc0023778ac5cda522aa2eadd/appengine/findit/common/test/rotations_test.py
[modify] https://crrev.com/64878ca445cbe64dc0023778ac5cda522aa2eadd/appengine/findit/common/rotations.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aea7fe076ff16452ef422c5384da177ccacdd0e2

commit aea7fe076ff16452ef422c5384da177ccacdd0e2
Author: Chan <chanli@chromium.org>
Date: Mon Aug 28 21:07:10 2017

[Findit] Auto-revert: Remove assert of email format and don't send duplicated messages.

Bug:  756896 
Change-Id: Idfedd570e6943a4d3abdedad181090121c5a8dcd
Reviewed-on: https://chromium-review.googlesource.com/621963
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/aea7fe076ff16452ef422c5384da177ccacdd0e2/appengine/findit/infra_api_clients/codereview/gerrit.py
[modify] https://crrev.com/aea7fe076ff16452ef422c5384da177ccacdd0e2/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py

Comment 6 by chanli@chromium.org, Aug 31 2017

Status: Fixed (was: Assigned)

Sign in to add a comment