New issue
Advanced search Search tips

Issue 756892 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[MacViewsBrowser] Wrench menu looks/feels wrong

Project Member Reported by sdy@chromium.org, Aug 18 2017

Issue description

Chrome Version: 62.0.3188.0 (MacViews)
OS: macOS 10.12.6 (16G29)

What steps will reproduce the problem?
(1) Open the wrench/app/three dots menu.

What is the expected result?
The menu behaves like a normal macOS menu.

What happens instead?
- The menu's background appears a frame earlier than the content.
- The menu's background looks unusually dark.
- The menu doesn't fade out when I click away from it.
- When I select an item, the item doesn't flash to confirm (the menu disappears immediately).
- If I move my mouse over a submenu and then away, the submenu stays visible for a short amount of time.
 
Labels: M-68
[Bulk Edit]
Applying M-68 milestone per email discussion with ellyjones@. Pls change it if milestone is incorrectly applied. 
Labels: -M-68 Target-68
Owner: sdy@chromium.org
Status: Assigned (was: Available)
Mac triage: assigning to sdy@ as part of the menu work. Let's target M-68 for this.
Cc: sdy@chromium.org
Owner: ellyjo...@chromium.org

Comment 4 by gov...@chromium.org, Mar 27 2018

Labels: M-68

Comment 5 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

FYI: Starting 04/13 M68 will be in canary, M68 Dev promotion will be on 04/26.

Status: Started (was: Assigned)
Before & after screenshots for CL 987476.
Screen Shot 2018-03-30 at 9.59.10 AM.png
50.7 KB View Download
Screen Shot 2018-03-30 at 10.13.35 AM.png
41.7 KB View Download

Comment 7 by rsesek@chromium.org, Mar 30 2018

C#6 looks much improved! One more item to add to the list from the OP:

- Keyboard shortcuts should use symbols (⌘ for Command and ⇧ for Shift, etc.) instead of the spelled-out words.
https://chromium-review.googlesource.com/c/chromium/src/+/987917 will fix the keyboard shortcuts.

The black line is  issue 826472 , being tracked separately.
(Fixing the shortcuts also fixes the excessive width of the menu, which is a nice bonus.)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/179f56a77bd6e89bb98ad1c764c9181adc469416

commit 179f56a77bd6e89bb98ad1c764c9181adc469416
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Mar 30 18:16:21 2018

macviews: fix menu transparency, remove some 10.9 code

This change:
1) Reduces the transparency of Views menus on Mac - the transparency is far
   too great as is. The newer value is close to what Mac native menus use.
2) Removes a couple of 10.9-only conditionals in the menu code

Bug:  756892 
Change-Id: Icf6c777e3ac99961bbf9f980f3e245d12475c375
Reviewed-on: https://chromium-review.googlesource.com/987476
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547210}
[modify] https://crrev.com/179f56a77bd6e89bb98ad1c764c9181adc469416/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/179f56a77bd6e89bb98ad1c764c9181adc469416/ui/views/controls/menu/menu_config_mac.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3af29753687ede6a8482d96997c40f72c20a361f

commit 3af29753687ede6a8482d96997c40f72c20a361f
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Mar 30 19:15:35 2018

views: tint focused menu color on Mac

Otherwise it's always blue even when the system tint is grey. Oops.

Bug:  756892 
Change-Id: I9d8627ec7f8d4a1b8f80d2f0c67cc734b74354a6
Reviewed-on: https://chromium-review.googlesource.com/988272
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547232}
[modify] https://crrev.com/3af29753687ede6a8482d96997c40f72c20a361f/ui/native_theme/native_theme_mac.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f795ec64cc2c10fb371dea5f9c58fc7db1a59731

commit f795ec64cc2c10fb371dea5f9c58fc7db1a59731
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Mar 30 22:26:06 2018

ui: use Mac-style accelerators on Mac

Mac menus use a compact format for naming accelerators, so this change
implements support for that format, uses it on Mac, and adds test coverage.

Bug:  756892 
Change-Id: I165e602d1d210e8b5f03c1b512afaf2d3670b294
Reviewed-on: https://chromium-review.googlesource.com/987917
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547288}
[modify] https://crrev.com/f795ec64cc2c10fb371dea5f9c58fc7db1a59731/chrome/test/data/extensions/api_test/keybinding/component/background.js
[modify] https://crrev.com/f795ec64cc2c10fb371dea5f9c58fc7db1a59731/chrome/test/data/extensions/api_test/keybinding/synthesized/background.js
[modify] https://crrev.com/f795ec64cc2c10fb371dea5f9c58fc7db1a59731/ui/base/accelerators/accelerator.cc
[modify] https://crrev.com/f795ec64cc2c10fb371dea5f9c58fc7db1a59731/ui/base/accelerators/accelerator.h
[modify] https://crrev.com/f795ec64cc2c10fb371dea5f9c58fc7db1a59731/ui/base/accelerators/accelerator_unittest.cc

It looks like both "Backspace" and "Escape" accelerators need to be Mac-ified too. Backspace should be ⌫ and escape should be ⎋. However, the task manager does not have a keyboard shortcut on Mac, so it shouldn't be displayed in the menu.

Also, the menu item highlight should be flush with the edge of the menu. Currently there is a 1px border.
Screen Shot 2018-04-03 at 2.05.54 PM.png
47.6 KB View Download
Labels: Sprint-1
Status: WontFix (was: Started)
I'm closing this bug:

The issues mentioned in #13 are handled now, and the remaining L&F has been moved away from a Mac style and towards Material ( issue 829347 ).

Sign in to add a comment