New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756890 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 756832
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

webgl2_conformance_tests flaking on Windows Mac and possibly Linux

Project Member Reported by jmad...@chromium.org, Aug 18 2017

Issue description

This seems to have started around https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28NVIDIA%29/builds/2925 but it's hard to tell because of the flakiness. Happening on multiple OS'es and bots. I tried digging through the logs for useful information but was having trouble producing anything I could tell would be useful. Possibly a v8 roll problem?

 

Comment 1 by kbr@chromium.org, Aug 18 2017

Cc: machenb...@chromium.org hpayer@chromium.org hablich@chromium.org
Components: Blink>JavaScript
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
Yes, looks like a crash in V8's GC:

https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/2925
This shard:
https://chromium-swarm.appspot.com/task?id=380e0dc877051710&refresh=10&show_raw=1
This test:
WebglConformance_deqp_functional_gles3_shaderoperator_binary_operator_13

Looks like it's crashing during a scavenge based on the incomplete stack trace:

  ********************************************************************************
  	Last event: 1cc.f74: Access violation - code c0000005 (first/second chance not available)
  	  debugger time: Fri Aug 18 05:21:26.714 2017 (UTC - 7:00)
  	ChildEBP RetAddr  Args to Child              
  	WARNING: Frame IP not in any known module. Following frames may be wrong.
  	0537c708 6c7a27ed 0537cdfc 6b6f4c23 6df27768 0x0
  	0537c710 6b6f4c23 6df27768 000007d1 6deb7bdc chrome_child!v8::base::OS::Abort+0xd
  	0537c714 6df27768 000007d1 6deb7bdc 0ac21468 chrome_child!v8::internal::Heap::Scavenge+0xdc3
  	0537c718 00000000 6deb7bdc 0ac21468 00000000 chrome_child!`string'

Given that it's late Friday Munich time I think we need to freeze V8 rolls and roll back.

Mergedinto: 756832
Status: Duplicate (was: Assigned)
Feel free to roll back. The fix is already in and we'll roll any minute... but it will take a CQ cycle...

Comment 4 by kbr@chromium.org, Aug 18 2017

OK, I'll stop my effort to roll back 1838595ababbbab335d12952588a29a2467cbe16 . Thanks for your quick action.

Here is the roll with ulan's fix:
https://chromium-review.googlesource.com/c/621191/

Will hopefully land in one hour if there's no other blocker in there...
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b

commit c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b
Author: Filip Gorski <fgorski@chromium.org>
Date: Tue Dec 19 23:32:04 2017

[Offline pages] Selecting items requiring upgrade to public storage

This patch extends GetPagesTask to provide capability to select
items that need to be upgraded (to a new public storage).

This approach is much simpler and shorter than providing a dedicated
task, that would copy most of the GetPagesTask code.

Bug:  756890 
Change-Id: Ib6e1822b2103fca3a3b8c0bc11713842fc7e7144
Reviewed-on: https://chromium-review.googlesource.com/828266
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525182}
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/model/get_pages_task.cc
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/model/get_pages_task.h
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/model/get_pages_task_unittest.cc
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[modify] https://crrev.com/c0bf1f0d80bfb11682328db8bf2eb9885e1d8a3b/components/offline_pages/core/offline_page_metadata_store_test_util.cc

Sign in to add a comment