New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

JavaScript alert/confirm buttons do not render properly

Project Member Reported by elawrence@chromium.org, Aug 18 2017

Issue description

Chrome Version: 62.3188
OS: Windows 10

What steps will reproduce the problem?

1. Type

 javascript:confirm("confirm() dialog");

...in the omnibox and hit enter

Expect: Visible "OK" button

Actual: Ok text is almost impossible to see.

Possibly related to  Issue 745290 




 
62vs61.png
6.0 KB View Download
Summary: JavaScript alert/confirm buttons do not render properly (was: JavaScript confirm dialog does not render properly)
Owner: est...@chromium.org
Same as 756737?

Comment 3 by est...@chromium.org, Aug 18 2017

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd97f8280d14e0638f766278936445ebc5ea1605

commit fd97f8280d14e0638f766278936445ebc5ea1605
Author: Evan Stade <estade@chromium.org>
Date: Fri Aug 18 17:42:33 2017

Fix button border/background painting.

Regression from I7e4922fcb73a185b873acf3525d

TBR=sky@chromium.org

Bug:  756719 , 756720 , 756728 , 756734 , 756737 , 756848 
Change-Id: I35f34055bbe0982d20d64ea1a0f05b1a5231a7a7
Reviewed-on: https://chromium-review.googlesource.com/621446
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495604}
[modify] https://crrev.com/fd97f8280d14e0638f766278936445ebc5ea1605/ui/views/controls/button/button.cc

Comment 5 by est...@chromium.org, Aug 18 2017

Status: Fixed (was: Started)
Cc: ranjitkan@chromium.org ligim...@chromium.org
Rechecked this issue on Windows 10 using chrome version 62.0.3191.0. Th java script buttons are displayed fine. Screen shot attached.

Tried to reproduce the issue on reported version of chrome 62.0.3188.0 and was unable to replicate it. OK button was displayed fine when the script was executed.

P.S: Was able to reproduce the  issue 745290  on Windows 10 using chrome the reported version in the issue.

Not adding TE-Verified labels.

Thanks.!
Java script Button.png
22.4 KB View Download

Sign in to add a comment