GPU FYI and ANGLE Windows builders failing compile step |
||||||
Issue descriptionninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_h264_cc.pdb" cl : Command line error D8021 : invalid numeric argument '/Wno-thread-safety-attributes' Seems to have started sometime early this morning: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder/builds/73559 https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20x64%20Builder/builds/30651 https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20dEQP%20Builder/builds/532 This is a pretty serious break for us since it is blocking the ANGLE CQ and all Windows testing. Can someone assist in triaging? The blamelist didn't seem suspicious and I no longer can find how to associate infra CLs with a build.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cc48f8f23f2d0864fe5d72ed5102fd6c475c6fa commit 8cc48f8f23f2d0864fe5d72ed5102fd6c475c6fa Author: Jamie Madill <jmadill@chromium.org> Date: Fri Aug 18 14:45:29 2017 Revert "Roll WebRTC 19324:19403 (73 commits)" This reverts commit 897b5aa9c138b73be735f16067ec2d6ab45c09f2. Reason for revert: Breaks the GPU FYI and ANGLE Windows builders: ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_h264_cc.pdb" cl : Command line error D8021 : invalid numeric argument '/Wno-thread-safety-attributes' BUG= 756840 Original change's description: > Roll WebRTC 19324:19403 (73 commits) > > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/4a604c8..55d14ce > > $ git log 4a604c8..55d14ce --date=short --no-merges --format=%ad %ae %s > 2017-08-18 oprypin@webrtc.org Remove xians@webrtc.org from OWNERS > 2017-08-18 emircan@chromium.org Reland of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #1 id:1 of https://codereview.webrtc.org/2995173002/ ) > 2017-08-18 oprypin@webrtc.org Fix a delete type mismatch (deleting a sockaddr_in6* as a sockaddr*) > 2017-08-17 steveanton@webrtc.org Reduce code repetition in RtpDemuxerTest. > 2017-08-17 emircan@chromium.org Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #2 id:20001 of https://codereview.webrtc.org/2925253002/ ) > 2017-08-16 yujo@chromium.org Explicitly specify the onFrameAvailable() thread. > 2017-08-17 steveanton@webrtc.org Add TLS TURN tests. > 2017-08-17 steveanton@webrtc.org Rename RsidResolutionObserver to SsrcBindingObserver. > 2017-08-17 steveanton@webrtc.org Refactor TurnPort tests. > 2017-08-17 zhihuang@webrtc.org Relanding: Adding support for Unified Plan offer/answer negotiation to the mediasession layer. > 2017-08-16 zijiehe@chromium.org Share ScreenDrawerLockPosix implementation > 2017-08-17 tkchin@webrtc.org Revert of quest keyframes more frequently on stream start/decoding error. (patchset #2 id:170001 of https://codereview.webrtc.org/2996823002/ ) > 2017-08-17 asapersson@webrtc.org Move kMinPixelsPerFrame constant in VideoStreamEncoder to VideoEncoder::ScalingSettings. > 2017-08-17 eladalon@webrtc.org Add rtc_event_log_unittest_helper.h to relevant BUILD.gn > 2017-08-17 oprypin@webrtc.org Make isac_fix_test use gtest (in a hacky way) > 2017-08-17 sprang@webrtc.org RTC_CHECK instead of assert in vp9_impl.cc > 2017-08-17 ehmaldonado@webrtc.org Reland of Make it possible for tests to set up trace event handlers. (patchset #1 id:1 of https://codereview.webrtc.org/2997963002/ ) > 2017-08-17 asapersson@webrtc.org Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. > 2017-08-17 olka@webrtc.org Revert of Adding support for Unified Plan offer/answer negotiation. (patchset #9 id:500001 of https://codereview.webrtc.org/2991693002/ ) > 2017-08-17 ehmaldonado@webrtc.org Revert of Make it possible for tests to set up trace event handlers. (patchset #4 id:60001 of https://codereview.webrtc.org/3002663002/ ) > 2017-08-17 ehmaldonado@webrtc.org Make it possible for tests to set up trace event handlers. > 2017-08-17 kwiberg@webrtc.org Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names > 2017-08-17 sakal@webrtc.org Fix a reference leak when converting I420 VideoFrame to I420Frame. > 2017-08-17 andersc@webrtc.org ObjC: Include additional files in umbrella header. > 2017-08-17 sakal@webrtc.org Implement QP parsing in VideoDecoderWrapper. > 2017-08-17 stefan@webrtc.org Reland of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2999893002/ ) > 2017-08-15 zijiehe@chromium.org Replace WindowUnderPoint free function with WindowFinder interface > 2017-08-14 cmumford@chromium.org Check for prior thread annotation macros before defining. > 2017-08-16 stefan@webrtc.org Reland of Add functionality which limits the number of bytes on the network. (patchset #1 id:1 of https://codereview.webrtc.org/3001653002/ ) > 2017-08-16 kthelgason@webrtc.org Remove dep on system_wrappers for apprtc and use only framework. > 2017-08-16 saza@webrtc.org Replace old logging mechanism in webrtc/modules/video_capture/linux > 2017-08-16 henrika@webrtc.org Avoids WebRtcAudioTrack null pointer access at stop. > 2017-08-16 kwiberg@webrtc.org L16 implementation of the Audio{En,De}coderFactoryTemplate APIs > 2017-08-08 saza@webrtc.org Replace WEBRTC_TRACE in modules/video_capture/ > 2017-08-16 sprang@webrtc.org Don't boost pacing rate after pause. > 2017-08-16 kwiberg@webrtc.org When using clang, switch on -Wc++11-narrowing > 2017-08-11 noahric@chromium.org Don't fail SetStereoPlayout(false) for Android devices. > 2017-08-16 owb@webrtc.org Make path to wav file for jitter buffer simulation in event_log_visualizer configurable. > 2017-08-14 nisse@webrtc.org Delete unneeded Start and Stop methods on FlexfecReceiveStream. > 2017-08-16 asapersson@webrtc.org Add support for a forced software encoder fallback. > 2017-08-15 mbonadei@webrtc.org Remove old webrtc/base directory > 2017-08-15 emircan@google.com Revert of Add a flags field to video timing extension. (patchset #15 id:280001 of https://codereview.webrtc.org/3000753002/ ) > 2017-08-14 noahric@chromium.org Check keepAlive before calling nativeDataIsRecording. > 2017-08-15 jianjun.zhu@intel.com Replace absolute path with relative path for GN files. > 2017-08-15 charujain@webrtc.org Revert of L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (patchset #5 id:80001 of https://codereview.webrtc.org/2995523002/ ) > 2017-08-15 kwiberg@webrtc.org L16 implementation of the Audio{En,De}coderFactoryTemplate APIs > 2017-08-15 sprang@webrtc.org Add a flags field to video timing extension. > 2017-08-15 sprang@webrtc.org Fix incorrect InterframeDelayMaxInMs histogram metrics > 2017-08-15 andersc@webrtc.org AppRTCMobile: Use high resolution app icon on retina screens. > 2017-08-15 ehmaldonado@webrtc.org Roll chromium_revision f156b499f7..f439921f66 (493756:494089) > 2017-08-15 gnish@webrtc.org Almost full implementation of BBR's core, missing receiver side implementation, pacer, and BitrateObserver class which is responsible for communication between BBR and pacer/encoder. Significant changes: Recovery mode and a separate bucket for the high gain phase. > 2017-08-15 terelius@webrtc.org Improved UI for event_log_analyzer tool > 2017-08-15 sakal@webrtc.org Add VideoSink interface to SurfaceViewRenderer. > 2017-08-15 sprang@webrtc.org Default enable content type rtp header extension > 2017-08-15 andersc@webrtc.org Ensure UIView.layer is accessed on main thread. > 2017-08-14 mbonadei@webrtc.org Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) > 2017-08-14 zhihuang@webrtc.org Adding support for Unified Plan offer/answer negotiation to the mediasession layer. > 2017-08-14 juberti@webrtc.org Implementation of SSL caching; tests in separate CL. > 2017-08-14 ehmaldonado@webrtc.org Trace the stats report as JSON instead of each stat separately. > 2017-08-11 noahric@chromium.org Change OpenSLES blacklist warning to debug. > 2017-08-14 stefan@webrtc.org Revert of Add functionality which limits the number of bytes on the network. (patchset #26 id:500001 of https://codereview.webrtc.org/2918323002/ ) > 2017-08-14 minyue@webrtc.org Don't use rvalue reference function arguments in the audio coding module > 2017-08-14 stefan@webrtc.org Revert of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2998753002/ ) > 2017-08-14 danilchap@webrtc.org Reduce locking when collecting receive statistic > 2017-08-14 sakal@webrtc.org Add support for adding VideoSinks to VideoTracks. > 2017-07-27 aleloi@webrtc.org Remove older AEC-dump interface. > 2017-08-14 srte@webrtc.org Removed unused async_invoker_ in WebRtcVideoCapturer > 2017-07-27 aleloi@webrtc.org Remove older AEC-dump implementation. > 2017-08-14 brandtr@webrtc.org Rename SetProcessParams -> SetTestConfig. > 2017-08-14 brandtr@webrtc.org Reorganize code in plot_videoprocessor_integrationtest.cc. > 2017-08-14 mbonadei@webrtc.org Removing NO_SOUND_SYSTEM > 2017-08-11 danilchap@webrtc.org Move RtcpReportBlocks implementation from ReceiveStatistics to ReceiveStatisticsImpl > 2017-08-11 brandtr@webrtc.org Minor improvements to VideoProcessorIntegrationTest. > > TBR= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > > Bug: > Change-Id: I8fd21f63f0e6cef017087b762798425e8c119eb9 > Reviewed-on: https://chromium-review.googlesource.com/620662 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Henrik Kjellander <kjellander@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#495523} TBR=kjellander@chromium.org,olka@chromium.org Change-Id: I9fef55d6e2ef723f4ecbfff2287090b48e93f36b No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/620966 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#495548} [modify] https://crrev.com/8cc48f8f23f2d0864fe5d72ed5102fd6c475c6fa/DEPS
,
Aug 18 2017
Assigning to original CL author, let me know if you need any help.
,
Aug 18 2017
,
Aug 18 2017
Full error report: [2214/6282] CXX obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj FAILED: obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_encoder_impl.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_h264_cc.pdb" cl : Command line error D8021 : invalid numeric argument '/Wno-thread-safety-attributes' [2215/6282] CXX obj/third_party/webrtc/p2p/rtc_p2p/session.obj [2216/6282] CXX obj/third_party/webrtc/p2p/rtc_p2p/asyncstuntcpsocket.obj [2217/6282] CXX obj/third_party/webrtc/modules/video_processing/video_processing/denoiser_filter_c.obj [2218/6282] CXX obj/third_party/webrtc/modules/audio_processing/audio_processing/level_controller.obj [2219/6282] CXX obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_decoder_impl.obj FAILED: obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_decoder_impl.obj ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_decoder_impl.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_h264/h264_decoder_impl.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_h264_cc.pdb" cl : Command line error D8021 : invalid numeric argument '/Wno-thread-safety-attributes' [2220/6282] CXX obj/third_party/webrtc/modules/audio_processing/aec_dump/aec_dump_impl/write_to_file_task.obj [2221/6282] CXX obj/third_party/webrtc/modules/video_coding/webrtc_vp9/screenshare_layers.obj [2222/6282] CXX obj/third_party/webrtc/modules/video_processing/video_processing/noise_estimation.obj [2223/6282] CXX obj/third_party/webrtc/p2p/rtc_p2p/p2pconstants.obj [2224/6282] CXX obj/third_party/webrtc/p2p/rtc_p2p/packetlossestimator.obj [2225/6282] CXX obj/third_party/webrtc/modules/video_coding/webrtc_vp8/simulcast_rate_allocator.obj [2226/6282] CXX obj/third_party/webrtc/modules/audio_processing/audio_processing/noise_suppression_impl.obj [2227/6282] CXX obj/third_party/webrtc/modules/video_coding/video_coding_utility/quality_scaler.obj [2228/6282] CXX obj/third_party/webrtc/modules/audio_processing/audio_processing/splitting_filter.obj [2229/6282] CXX obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264.obj FAILED: obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264.obj ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "e:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64_x86/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/modules/video_coding/webrtc_h264/h264.obj.rsp /c ../../third_party/webrtc/modules/video_coding/codecs/h264/h264.cc /Foobj/third_party/webrtc/modules/video_coding/webrtc_h264/h264.obj /Fd"obj/third_party/webrtc/modules/video_coding/webrtc_h264_cc.pdb" cl : Command line error D8021 : invalid numeric argument '/Wno-thread-safety-attributes'
,
Aug 18 2017
Probably related to the fact that these bots are still running msvc? I'm trying to finish untangling this today in Issue 727437 .
,
Aug 18 2017
Could be: I have not found anything suspicious in the roll so far.
,
Aug 18 2017
,
Aug 18 2017
No, actually https://codereview.webrtc.org/3001673002
,
Aug 19 2017
Thanks ynovikov@! ehmaldonado@ and kjellander@ PTAL: the only WebRTC roll we managed this week was reverted.
,
Aug 21 2017
Taking over this as Edward is OOO. I'm disabling that warning only when Clang compiler is used (not MSVC) in https://codereview.webrtc.org/3003473002/ I've filed bug 757293 to investigate our missing coverage on WebRTC trybots so we can catch things like this earlier.
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/8b844b16eb8d71313d6b5a06e9469f968fcb0446 commit 8b844b16eb8d71313d6b5a06e9469f968fcb0446 Author: kjellander <kjellander@webrtc.org> Date: Mon Aug 21 04:37:21 2017 Only disable -Wthread-safety-attributes warning for Clang. Clang is enabled by default and we currently lack coverage for building on Windows with MSVC (see crbug.com/757293 ). This should unblock rolling WebRTC into Chromium DEPS. We need to improve our trybot coverage for standalone WebRTC to prevent things like this in the future though ( crbug.com/756840 ). BUG= webrtc:8119 , chromium:756840 , chromium:757293 TBR=hbos@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/3003473002 Cr-Commit-Position: refs/heads/master@{#19420} [modify] https://crrev.com/8b844b16eb8d71313d6b5a06e9469f968fcb0446/webrtc/modules/video_coding/BUILD.gn
,
Aug 21 2017
New roll in progress: https://chromium-review.googlesource.com/c/622789 It is running the win_optional_gpu_tests_rel trybot as well, which seems to match the failing ones in https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=8394bae7034e5eeb9bf5ada381fc3ea39baf323a&l=673 FTR: I got permission denied with my kjellander@google.com account to schedule tryjobs at the chromium.angle tryserver. Is that intentional?
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/889b5e7ae8c4255e600c77bb7bb4980f1026b37e commit 889b5e7ae8c4255e600c77bb7bb4980f1026b37e Author: Henrik Kjellander <kjellander@chromium.org> Date: Mon Aug 21 10:26:10 2017 Roll WebRTC 19324:19420 (90 commits) Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/4a604c8..c2bba60 $ git log 4a604c8..c2bba60 --date=short --no-merges --format=%ad %ae %s 2017-08-20 kjellander@webrtc.org Only disable -Wthread-safety-attributes warning for Clang. 2017-08-20 charujain@webrtc.org Revert of Add Jpeg frame writer for test support. (patchset #12 id:220001 of https://codereview.webrtc.org/2990563002/ ) 2017-08-20 gnish@webrtc.org Final version of BBR, with tweaks made for WebRTC, major changes: 1) Entering PROBE_RTT when necessary. 2) Congestion window gain of 0.65 instead of constant 4 packets. 3) {1.1, 0.9} pair instead of {1.25, 0.75} 4) Recovery mode. 5) No reaction to losses due to Recovery mode's implementation. 6) Supports encoder. 7) A new test compiling most of the simulation tests. 8) Bucket for high gain phase, disabled by default. 9) Pacer specific to BBR. 2017-08-18 steveanton@webrtc.org Reduce code repetition in RtcpDemuxerTest. 2017-08-18 sakal@webrtc.org Fix a bug where listener custom drawer was ignored in EglRenderer. 2017-08-18 steveanton@webrtc.org Add BUNDLE processing to RtpDemuxer. 2017-08-18 ilnik@webrtc.org Add Jpeg frame writer for test support. 2017-08-18 oprypin@webrtc.org Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ ) 2017-08-18 oprypin@webrtc.org Stop silently accepting unsupported flags in test binaries 2017-08-18 andersc@webrtc.org Make a friendlier RTCVideoCodecInfo initializer for when only name and parameters are interesting. 2017-08-18 philipel@webrtc.org Reland of quest keyframes more frequently on stream start/decoding error. (patchset #1 id:1 of https://codereview.chromium.org/2995153002/ ) 2017-08-18 kwiberg@webrtc.org iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs 2017-08-18 eladalon@webrtc.org Change ThreadChecker to SequencedTaskChecker in VideoReceiveStream 2017-08-18 tschumim@webrtc.org Fix for alr detection bug on pause. 2017-08-18 sakal@webrtc.org Optimize HardwareVideoDecoder by doing all frame conversions in C++. 2017-08-18 sprang@webrtc.org Reland of Add a flags field to video timing extension. (patchset #1 id:1 of https://codereview.webrtc.org/2995953002/ ) 2017-08-18 eladalon@webrtc.org Change ThreadChecker to SequencedTaskChecker in internal::Call 2017-08-18 oprypin@webrtc.org Remove xians@webrtc.org from OWNERS 2017-08-18 emircan@chromium.org Reland of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #1 id:1 of https://codereview.webrtc.org/2995173002/ ) 2017-08-18 oprypin@webrtc.org Fix a delete type mismatch (deleting a sockaddr_in6* as a sockaddr*) 2017-08-17 steveanton@webrtc.org Reduce code repetition in RtpDemuxerTest. 2017-08-17 emircan@chromium.org Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #2 id:20001 of https://codereview.webrtc.org/2925253002/ ) 2017-08-16 yujo@chromium.org Explicitly specify the onFrameAvailable() thread. 2017-08-17 steveanton@webrtc.org Add TLS TURN tests. 2017-08-17 steveanton@webrtc.org Rename RsidResolutionObserver to SsrcBindingObserver. 2017-08-17 steveanton@webrtc.org Refactor TurnPort tests. 2017-08-17 zhihuang@webrtc.org Relanding: Adding support for Unified Plan offer/answer negotiation to the mediasession layer. 2017-08-16 zijiehe@chromium.org Share ScreenDrawerLockPosix implementation 2017-08-17 tkchin@webrtc.org Revert of quest keyframes more frequently on stream start/decoding error. (patchset #2 id:170001 of https://codereview.webrtc.org/2996823002/ ) 2017-08-17 asapersson@webrtc.org Move kMinPixelsPerFrame constant in VideoStreamEncoder to VideoEncoder::ScalingSettings. 2017-08-17 eladalon@webrtc.org Add rtc_event_log_unittest_helper.h to relevant BUILD.gn 2017-08-17 oprypin@webrtc.org Make isac_fix_test use gtest (in a hacky way) 2017-08-17 sprang@webrtc.org RTC_CHECK instead of assert in vp9_impl.cc 2017-08-17 ehmaldonado@webrtc.org Reland of Make it possible for tests to set up trace event handlers. (patchset #1 id:1 of https://codereview.webrtc.org/2997963002/ ) 2017-08-17 asapersson@webrtc.org Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. 2017-08-17 olka@webrtc.org Revert of Adding support for Unified Plan offer/answer negotiation. (patchset #9 id:500001 of https://codereview.webrtc.org/2991693002/ ) 2017-08-17 ehmaldonado@webrtc.org Revert of Make it possible for tests to set up trace event handlers. (patchset #4 id:60001 of https://codereview.webrtc.org/3002663002/ ) 2017-08-17 ehmaldonado@webrtc.org Make it possible for tests to set up trace event handlers. 2017-08-17 kwiberg@webrtc.org Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names 2017-08-17 sakal@webrtc.org Fix a reference leak when converting I420 VideoFrame to I420Frame. 2017-08-17 andersc@webrtc.org ObjC: Include additional files in umbrella header. 2017-08-17 sakal@webrtc.org Implement QP parsing in VideoDecoderWrapper. 2017-08-17 stefan@webrtc.org Reland of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2999893002/ ) 2017-08-15 zijiehe@chromium.org Replace WindowUnderPoint free function with WindowFinder interface 2017-08-14 cmumford@chromium.org Check for prior thread annotation macros before defining. 2017-08-16 stefan@webrtc.org Reland of Add functionality which limits the number of bytes on the network. (patchset #1 id:1 of https://codereview.webrtc.org/3001653002/ ) 2017-08-16 kthelgason@webrtc.org Remove dep on system_wrappers for apprtc and use only framework. 2017-08-16 saza@webrtc.org Replace old logging mechanism in webrtc/modules/video_capture/linux 2017-08-16 henrika@webrtc.org Avoids WebRtcAudioTrack null pointer access at stop. 2017-08-16 kwiberg@webrtc.org L16 implementation of the Audio{En,De}coderFactoryTemplate APIs 2017-08-08 saza@webrtc.org Replace WEBRTC_TRACE in modules/video_capture/ 2017-08-16 sprang@webrtc.org Don't boost pacing rate after pause. 2017-08-16 kwiberg@webrtc.org When using clang, switch on -Wc++11-narrowing 2017-08-11 noahric@chromium.org Don't fail SetStereoPlayout(false) for Android devices. 2017-08-16 owb@webrtc.org Make path to wav file for jitter buffer simulation in event_log_visualizer configurable. 2017-08-14 nisse@webrtc.org Delete unneeded Start and Stop methods on FlexfecReceiveStream. 2017-08-16 asapersson@webrtc.org Add support for a forced software encoder fallback. 2017-08-15 mbonadei@webrtc.org Remove old webrtc/base directory 2017-08-15 emircan@google.com Revert of Add a flags field to video timing extension. (patchset #15 id:280001 of https://codereview.webrtc.org/3000753002/ ) 2017-08-14 noahric@chromium.org Check keepAlive before calling nativeDataIsRecording. 2017-08-15 jianjun.zhu@intel.com Replace absolute path with relative path for GN files. 2017-08-15 charujain@webrtc.org Revert of L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (patchset #5 id:80001 of https://codereview.webrtc.org/2995523002/ ) 2017-08-15 kwiberg@webrtc.org L16 implementation of the Audio{En,De}coderFactoryTemplate APIs 2017-08-15 sprang@webrtc.org Add a flags field to video timing extension. 2017-08-15 sprang@webrtc.org Fix incorrect InterframeDelayMaxInMs histogram metrics 2017-08-15 andersc@webrtc.org AppRTCMobile: Use high resolution app icon on retina screens. 2017-08-15 ehmaldonado@webrtc.org Roll chromium_revision f156b499f7..f439921f66 (493756:494089) 2017-08-15 gnish@webrtc.org Almost full implementation of BBR's core, missing receiver side implementation, pacer, and BitrateObserver class which is responsible for communication between BBR and pacer/encoder. Significant changes: Recovery mode and a separate bucket for the high gain phase. 2017-08-15 terelius@webrtc.org Improved UI for event_log_analyzer tool 2017-08-15 sakal@webrtc.org Add VideoSink interface to SurfaceViewRenderer. 2017-08-15 sprang@webrtc.org Default enable content type rtp header extension 2017-08-15 andersc@webrtc.org Ensure UIView.layer is accessed on main thread. 2017-08-14 mbonadei@webrtc.org Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) 2017-08-14 zhihuang@webrtc.org Adding support for Unified Plan offer/answer negotiation to the mediasession layer. 2017-08-14 juberti@webrtc.org Implementation of SSL caching; tests in separate CL. 2017-08-14 ehmaldonado@webrtc.org Trace the stats report as JSON instead of each stat separately. 2017-08-11 noahric@chromium.org Change OpenSLES blacklist warning to debug. 2017-08-14 stefan@webrtc.org Revert of Add functionality which limits the number of bytes on the network. (patchset #26 id:500001 of https://codereview.webrtc.org/2918323002/ ) 2017-08-14 minyue@webrtc.org Don't use rvalue reference function arguments in the audio coding module 2017-08-14 stefan@webrtc.org Revert of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2998753002/ ) 2017-08-14 danilchap@webrtc.org Reduce locking when collecting receive statistic 2017-08-14 sakal@webrtc.org Add support for adding VideoSinks to VideoTracks. 2017-07-27 aleloi@webrtc.org Remove older AEC-dump interface. 2017-08-14 srte@webrtc.org Removed unused async_invoker_ in WebRtcVideoCapturer 2017-07-27 aleloi@webrtc.org Remove older AEC-dump implementation. 2017-08-14 brandtr@webrtc.org Rename SetProcessParams -> SetTestConfig. 2017-08-14 brandtr@webrtc.org Reorganize code in plot_videoprocessor_integrationtest.cc. 2017-08-14 mbonadei@webrtc.org Removing NO_SOUND_SYSTEM 2017-08-11 danilchap@webrtc.org Move RtcpReportBlocks implementation from ReceiveStatistics to ReceiveStatisticsImpl 2017-08-11 brandtr@webrtc.org Minor improvements to VideoProcessorIntegrationTest. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Bug: 756840 Change-Id: I310b370933f6523ffcd0ea8210c885a0e081519a Reviewed-on: https://chromium-review.googlesource.com/622789 Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#495905} [modify] https://crrev.com/889b5e7ae8c4255e600c77bb7bb4980f1026b37e/DEPS
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faa2a2c3e81a0f6e2a59fd2b72b10b871ab5f034 commit faa2a2c3e81a0f6e2a59fd2b72b10b871ab5f034 Author: Guido Urdaneta <guidou@chromium.org> Date: Mon Aug 21 11:09:13 2017 Revert "Roll WebRTC 19324:19420 (90 commits)" This reverts commit 889b5e7ae8c4255e600c77bb7bb4980f1026b37e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Roll WebRTC 19324:19420 (90 commits) > > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/4a604c8..c2bba60 > > $ git log 4a604c8..c2bba60 --date=short --no-merges --format=%ad %ae %s > 2017-08-20 kjellander@webrtc.org Only disable -Wthread-safety-attributes warning for Clang. > 2017-08-20 charujain@webrtc.org Revert of Add Jpeg frame writer for test support. (patchset #12 id:220001 of https://codereview.webrtc.org/2990563002/ ) > 2017-08-20 gnish@webrtc.org Final version of BBR, with tweaks made for WebRTC, major changes: 1) Entering PROBE_RTT when necessary. 2) Congestion window gain of 0.65 instead of constant 4 packets. 3) {1.1, 0.9} pair instead of {1.25, 0.75} 4) Recovery mode. 5) No reaction to losses due to Recovery mode's implementation. 6) Supports encoder. 7) A new test compiling most of the simulation tests. 8) Bucket for high gain phase, disabled by default. 9) Pacer specific to BBR. > 2017-08-18 steveanton@webrtc.org Reduce code repetition in RtcpDemuxerTest. > 2017-08-18 sakal@webrtc.org Fix a bug where listener custom drawer was ignored in EglRenderer. > 2017-08-18 steveanton@webrtc.org Add BUNDLE processing to RtpDemuxer. > 2017-08-18 ilnik@webrtc.org Add Jpeg frame writer for test support. > 2017-08-18 oprypin@webrtc.org Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ ) > 2017-08-18 oprypin@webrtc.org Stop silently accepting unsupported flags in test binaries > 2017-08-18 andersc@webrtc.org Make a friendlier RTCVideoCodecInfo initializer for when only name and parameters are interesting. > 2017-08-18 philipel@webrtc.org Reland of quest keyframes more frequently on stream start/decoding error. (patchset #1 id:1 of https://codereview.chromium.org/2995153002/ ) > 2017-08-18 kwiberg@webrtc.org iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs > 2017-08-18 eladalon@webrtc.org Change ThreadChecker to SequencedTaskChecker in VideoReceiveStream > 2017-08-18 tschumim@webrtc.org Fix for alr detection bug on pause. > 2017-08-18 sakal@webrtc.org Optimize HardwareVideoDecoder by doing all frame conversions in C++. > 2017-08-18 sprang@webrtc.org Reland of Add a flags field to video timing extension. (patchset #1 id:1 of https://codereview.webrtc.org/2995953002/ ) > 2017-08-18 eladalon@webrtc.org Change ThreadChecker to SequencedTaskChecker in internal::Call > 2017-08-18 oprypin@webrtc.org Remove xians@webrtc.org from OWNERS > 2017-08-18 emircan@chromium.org Reland of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #1 id:1 of https://codereview.webrtc.org/2995173002/ ) > 2017-08-18 oprypin@webrtc.org Fix a delete type mismatch (deleting a sockaddr_in6* as a sockaddr*) > 2017-08-17 steveanton@webrtc.org Reduce code repetition in RtpDemuxerTest. > 2017-08-17 emircan@chromium.org Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #2 id:20001 of https://codereview.webrtc.org/2925253002/ ) > 2017-08-16 yujo@chromium.org Explicitly specify the onFrameAvailable() thread. > 2017-08-17 steveanton@webrtc.org Add TLS TURN tests. > 2017-08-17 steveanton@webrtc.org Rename RsidResolutionObserver to SsrcBindingObserver. > 2017-08-17 steveanton@webrtc.org Refactor TurnPort tests. > 2017-08-17 zhihuang@webrtc.org Relanding: Adding support for Unified Plan offer/answer negotiation to the mediasession layer. > 2017-08-16 zijiehe@chromium.org Share ScreenDrawerLockPosix implementation > 2017-08-17 tkchin@webrtc.org Revert of quest keyframes more frequently on stream start/decoding error. (patchset #2 id:170001 of https://codereview.webrtc.org/2996823002/ ) > 2017-08-17 asapersson@webrtc.org Move kMinPixelsPerFrame constant in VideoStreamEncoder to VideoEncoder::ScalingSettings. > 2017-08-17 eladalon@webrtc.org Add rtc_event_log_unittest_helper.h to relevant BUILD.gn > 2017-08-17 oprypin@webrtc.org Make isac_fix_test use gtest (in a hacky way) > 2017-08-17 sprang@webrtc.org RTC_CHECK instead of assert in vp9_impl.cc > 2017-08-17 ehmaldonado@webrtc.org Reland of Make it possible for tests to set up trace event handlers. (patchset #1 id:1 of https://codereview.webrtc.org/2997963002/ ) > 2017-08-17 asapersson@webrtc.org Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. > 2017-08-17 olka@webrtc.org Revert of Adding support for Unified Plan offer/answer negotiation. (patchset #9 id:500001 of https://codereview.webrtc.org/2991693002/ ) > 2017-08-17 ehmaldonado@webrtc.org Revert of Make it possible for tests to set up trace event handlers. (patchset #4 id:60001 of https://codereview.webrtc.org/3002663002/ ) > 2017-08-17 ehmaldonado@webrtc.org Make it possible for tests to set up trace event handlers. > 2017-08-17 kwiberg@webrtc.org Give Audio{De,En}coderIsac* an "Impl" suffix, to free up the original names > 2017-08-17 sakal@webrtc.org Fix a reference leak when converting I420 VideoFrame to I420Frame. > 2017-08-17 andersc@webrtc.org ObjC: Include additional files in umbrella header. > 2017-08-17 sakal@webrtc.org Implement QP parsing in VideoDecoderWrapper. > 2017-08-17 stefan@webrtc.org Reland of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2999893002/ ) > 2017-08-15 zijiehe@chromium.org Replace WindowUnderPoint free function with WindowFinder interface > 2017-08-14 cmumford@chromium.org Check for prior thread annotation macros before defining. > 2017-08-16 stefan@webrtc.org Reland of Add functionality which limits the number of bytes on the network. (patchset #1 id:1 of https://codereview.webrtc.org/3001653002/ ) > 2017-08-16 kthelgason@webrtc.org Remove dep on system_wrappers for apprtc and use only framework. > 2017-08-16 saza@webrtc.org Replace old logging mechanism in webrtc/modules/video_capture/linux > 2017-08-16 henrika@webrtc.org Avoids WebRtcAudioTrack null pointer access at stop. > 2017-08-16 kwiberg@webrtc.org L16 implementation of the Audio{En,De}coderFactoryTemplate APIs > 2017-08-08 saza@webrtc.org Replace WEBRTC_TRACE in modules/video_capture/ > 2017-08-16 sprang@webrtc.org Don't boost pacing rate after pause. > 2017-08-16 kwiberg@webrtc.org When using clang, switch on -Wc++11-narrowing > 2017-08-11 noahric@chromium.org Don't fail SetStereoPlayout(false) for Android devices. > 2017-08-16 owb@webrtc.org Make path to wav file for jitter buffer simulation in event_log_visualizer configurable. > 2017-08-14 nisse@webrtc.org Delete unneeded Start and Stop methods on FlexfecReceiveStream. > 2017-08-16 asapersson@webrtc.org Add support for a forced software encoder fallback. > 2017-08-15 mbonadei@webrtc.org Remove old webrtc/base directory > 2017-08-15 emircan@google.com Revert of Add a flags field to video timing extension. (patchset #15 id:280001 of https://codereview.webrtc.org/3000753002/ ) > 2017-08-14 noahric@chromium.org Check keepAlive before calling nativeDataIsRecording. > 2017-08-15 jianjun.zhu@intel.com Replace absolute path with relative path for GN files. > 2017-08-15 charujain@webrtc.org Revert of L16 implementation of the Audio{En,De}coderFactoryTemplate APIs (patchset #5 id:80001 of https://codereview.webrtc.org/2995523002/ ) > 2017-08-15 kwiberg@webrtc.org L16 implementation of the Audio{En,De}coderFactoryTemplate APIs > 2017-08-15 sprang@webrtc.org Add a flags field to video timing extension. > 2017-08-15 sprang@webrtc.org Fix incorrect InterframeDelayMaxInMs histogram metrics > 2017-08-15 andersc@webrtc.org AppRTCMobile: Use high resolution app icon on retina screens. > 2017-08-15 ehmaldonado@webrtc.org Roll chromium_revision f156b499f7..f439921f66 (493756:494089) > 2017-08-15 gnish@webrtc.org Almost full implementation of BBR's core, missing receiver side implementation, pacer, and BitrateObserver class which is responsible for communication between BBR and pacer/encoder. Significant changes: Recovery mode and a separate bucket for the high gain phase. > 2017-08-15 terelius@webrtc.org Improved UI for event_log_analyzer tool > 2017-08-15 sakal@webrtc.org Add VideoSink interface to SurfaceViewRenderer. > 2017-08-15 sprang@webrtc.org Default enable content type rtp header extension > 2017-08-15 andersc@webrtc.org Ensure UIView.layer is accessed on main thread. > 2017-08-14 mbonadei@webrtc.org Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) > 2017-08-14 zhihuang@webrtc.org Adding support for Unified Plan offer/answer negotiation to the mediasession layer. > 2017-08-14 juberti@webrtc.org Implementation of SSL caching; tests in separate CL. > 2017-08-14 ehmaldonado@webrtc.org Trace the stats report as JSON instead of each stat separately. > 2017-08-11 noahric@chromium.org Change OpenSLES blacklist warning to debug. > 2017-08-14 stefan@webrtc.org Revert of Add functionality which limits the number of bytes on the network. (patchset #26 id:500001 of https://codereview.webrtc.org/2918323002/ ) > 2017-08-14 minyue@webrtc.org Don't use rvalue reference function arguments in the audio coding module > 2017-08-14 stefan@webrtc.org Revert of Make the acceptable queue in the cwnd experiment configurable. (patchset #1 id:1 of https://codereview.webrtc.org/2998753002/ ) > 2017-08-14 danilchap@webrtc.org Reduce locking when collecting receive statistic > 2017-08-14 sakal@webrtc.org Add support for adding VideoSinks to VideoTracks. > 2017-07-27 aleloi@webrtc.org Remove older AEC-dump interface. > 2017-08-14 srte@webrtc.org Removed unused async_invoker_ in WebRtcVideoCapturer > 2017-07-27 aleloi@webrtc.org Remove older AEC-dump implementation. > 2017-08-14 brandtr@webrtc.org Rename SetProcessParams -> SetTestConfig. > 2017-08-14 brandtr@webrtc.org Reorganize code in plot_videoprocessor_integrationtest.cc. > 2017-08-14 mbonadei@webrtc.org Removing NO_SOUND_SYSTEM > 2017-08-11 danilchap@webrtc.org Move RtcpReportBlocks implementation from ReceiveStatistics to ReceiveStatisticsImpl > 2017-08-11 brandtr@webrtc.org Minor improvements to VideoProcessorIntegrationTest. > > TBR= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Bug: 756840 > Change-Id: I310b370933f6523ffcd0ea8210c885a0e081519a > Reviewed-on: https://chromium-review.googlesource.com/622789 > Commit-Queue: Henrik Kjellander <kjellander@chromium.org> > Reviewed-by: Henrik Kjellander <kjellander@chromium.org> > Cr-Commit-Position: refs/heads/master@{#495905} TBR=kjellander@chromium.org,olka@chromium.org Change-Id: I1d630b2440d7a31334540e7567a91996e88a1275 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756840 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/623487 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#495908} [modify] https://crrev.com/faa2a2c3e81a0f6e2a59fd2b72b10b871ab5f034/DEPS
,
Aug 21 2017
Roll was reverted after another breakage (see [1] for details). We somehow seem unable to catch in WebRTC standalone. I posted a comment in https://chromium-review.googlesource.com/c/578628 about fixing it but I don't know why it isn't caught either with our own bots or the Chromium CQ trybots. [1]: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4OWI1ZTdhZThjNDI1NWU2MDBjNzdiYjdiYjQ5ODBmMTAyNmIzN2UM
,
Aug 21 2017
It looks like the same problem as https://bugs.chromium.org/p/webrtc/issues/detail?id=8108 which was caught by CQ during the roll last week.
,
Aug 22 2017
Re #17: can you provide links as reference? If it was "caught" by CQ, how could the CL land? Regarding this bug, niklase@ landed a roll ~4 hours ago in https://chromium-review.googlesource.com/c/chromium/src/+/624696 that seems to stick, so I'm closing this. I will investigate the remaining unanswered questions about our test coverage as part of bug 757293 .
,
Aug 22 2017
Re #18: from #16 log for https://luci-milo.appspot.com/buildbot/chromium/Win%20x64/14080: FAILED: obj/third_party/webrtc/call/rtp_receiver/rtp_demuxer.obj ninja -t msvc -e environment.x64 -- C:\b\c\goma_client/gomacc.exe "c:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/call/rtp_receiver/rtp_demuxer.obj.rsp /c ../../third_party/webrtc/call/rtp_demuxer.cc /Foobj/third_party/webrtc/call/rtp_receiver/rtp_demuxer.obj /Fd"obj/third_party/webrtc/call/rtp_receiver_cc.pdb" ../../third_party/webrtc/call/rtp_demuxer.cc(149): error C2220: warning treated as error - no 'object' file generated ../../third_party/webrtc/call/rtp_demuxer.cc(149): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data It's the same warning (but in another place) CQ rejected the build with in https://bugs.chromium.org/p/webrtc/issues/detail?id=8108 I refer to (see big description in there). I'm not sure what is going on here, maybe a race of clang bit flipping on/off in Chromium and WebRTC.
,
Aug 23 2017
kjellander@: re #13: > FTR: I got permission denied with my kjellander@google.com account to > schedule tryjobs at the chromium.angle tryserver. Is that intentional? Might require @chromium.org, not sure, but the chromium.angle tryserver is configured to only try patches that apply to src/third_party/angle. master.tryserver.chromium.win:win_optional_gpu_tests_rel can be used for the moment to catch this, as can master.tryserver.chromium.win:win_clang (which is now really "win_msvc"). |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jmad...@chromium.org
, Aug 18 2017Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)