New issue
Advanced search Search tips

Issue 756839 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 730232



Sign in to add a comment

Renaming a file is not finished when tapping another file

Project Member Reported by yamaguchi@chromium.org, Aug 18 2017

Issue description

Chrome Version: 62.0.3189.0

Steps To Reproduce:
(1) Long-tap a file (or a folder) to select it.
(2) Open the overflow menu and select "rename".
(3) Tap another file or folder.

Expected Result:
Renaming is finished.

Actual Result:
Renaming text box stays.
The 2nd file is added to selection.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
100%

What is the impact to the user, and is there a workaround? If so, what is
it?
This happens often because large part of the file list is occupied by the files, and user will touch such part of the window to cancel renaming.

Workaround:
- cancel by [esc] key
- [enter] to finish renaming
- tap other part of the window to finish renaming

 
Status: Assigned (was: Untriaged)
IIUC this is caused by the List not getting focus by touch, as the current touch handler logic cancels the event to prevent mouse click events.
So this can be fixed by the same fix as  Issue 755774 .
 Issue 753835  is also related to this.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/314eb17f4f278c9db669525137df44a5f27ca526

commit 314eb17f4f278c9db669525137df44a5f27ca526
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Aug 23 01:40:23 2017

Focus parent list element when tapped.

This will also allow to finish renaming when tapping outside the input
text box.

Bug:  755774 , 756839 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d05724e85c9615b284dc7e799cb2dfb7f18f190
Reviewed-on: https://chromium-review.googlesource.com/622332
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496550}
[modify] https://crrev.com/314eb17f4f278c9db669525137df44a5f27ca526/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
[modify] https://crrev.com/314eb17f4f278c9db669525137df44a5f27ca526/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
[modify] https://crrev.com/314eb17f4f278c9db669525137df44a5f27ca526/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js

Labels: Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a97cabaedd6e5aa1ac1d53317594e3835b9ea83

commit 4a97cabaedd6e5aa1ac1d53317594e3835b9ea83
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Aug 25 03:14:26 2017

Focus parent list element when tapped.

This will also allow to finish renaming when tapping outside the input
text box.

TBR=yamaguchi@chromium.org

(cherry picked from commit 314eb17f4f278c9db669525137df44a5f27ca526)

Bug:  755774 , 756839 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d05724e85c9615b284dc7e799cb2dfb7f18f190
Reviewed-on: https://chromium-review.googlesource.com/622332
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496550}
Reviewed-on: https://chromium-review.googlesource.com/634024
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#870}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4a97cabaedd6e5aa1ac1d53317594e3835b9ea83/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
[modify] https://crrev.com/4a97cabaedd6e5aa1ac1d53317594e3835b9ea83/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
[modify] https://crrev.com/4a97cabaedd6e5aa1ac1d53317594e3835b9ea83/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment