Media Controls: hide duration text field when it is infinity |
|||
Issue descriptionThe duration field is hidden in ::Reset() if the duration is equal to infinity but is not hidden if the duration is changed dynamically using MSE. The reason is that the durationchange event handler doesn't implement this logic.
,
Aug 18 2017
,
Aug 31 2017
FYI, the official sample is now available at https://googlechrome.github.io/samples/media/live-seekable-range.html
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/710899b571a24886905df6b0825729cadd226633 commit 710899b571a24886905df6b0825729cadd226633 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Fri Sep 08 21:09:44 2017 Media Controls: hide duration field when changed to infinity. The duration field will not show up when the resource is known to have an infinite duration but if it is updated after load, the UI will not properly update. This is refactoring both code path to be the same and therefore always hide the duration field when the duration is known to be not finite. Bug: 756785 Change-Id: Iab38f61fc337f39e5b6bb712bd5f1cecc9a95f05 Reviewed-on: https://chromium-review.googlesource.com/620775 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#500664} [modify] https://crrev.com/710899b571a24886905df6b0825729cadd226633/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/710899b571a24886905df6b0825729cadd226633/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
,
Sep 8 2017
,
Sep 11 2017
Verified in Chrome 63.0.3212.0 (Official Build) canary (64-bit). Thank you! |
|||
►
Sign in to add a comment |
|||
Comment 1 by fbeaufort@chromium.org
, Aug 18 2017