Issue metadata
Sign in to add a comment
|
roll_webrtc.py does not send rolls to CQ automatically with Gerrit. |
||||||||||||||||||||||
Issue descriptionWith Rietveld the rolls used to be sent to CQ automatically. Now in Gerrit we need to manually "start review", approve the patch and send it to CQ.
,
Aug 21 2017
Yes, but not today. I'm sheriffing today and I have quite a backlog.
,
Aug 21 2017
Olga, can you send a mail with your experience to sheriffs so that everyone is aware of this?
,
Aug 29 2017
CL in progress: https://chromium-review.googlesource.com/c/chromium/src/+/641457
,
Aug 29 2017
+agable and authors of similar roll scripts in src/tools: FYI since I think your scripts experience the same.
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afb7e1c3e5ecab664b07cbbdeaf67283168d01cd commit afb7e1c3e5ecab664b07cbbdeaf67283168d01cd Author: Per <perkj@chromium.org> Date: Thu Sep 07 07:41:28 2017 Roll WebRTC 19716:19720 (3 commits) Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3fa5b7b..efa3277 $ git log 3fa5b7b..efa3277 --date=short --no-merges --format=%ad %ae %s 2017-09-06 eladalon@webrtc.org Thread-checkers for PeerConnectionFactory::worker_thread_ 2017-09-06 ilnik@webrtc.org Add reporting of googContentType via GetStats on send side 2017-09-06 ehmaldonado@webrtc.org Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #2 id:40001 of https://codereview.webrtc.org/3011023002/ ) TBR=perkj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng roll_webrtc.py: Make it possible to send CL directly to CQ Previously the CL was sent directly to the CQ by default, but after the Rietveld to Gerrit switch for Chromium, this is no longer the case. According to the documentation generated by 'git cl help upload' the use of --send-email and --use-commit-queue seems to do what's desired. Part of the problem is that a new WIP state is introduced in Gerrit, which doesn't send the CL to the CQ until "Start Review" has been clicked and started. Bug: 756780 Change-Id: I0513102dcf8837c36d82abd1908c7457079e852d Reviewed-on: https://chromium-review.googlesource.com/654597 Reviewed-by: Per Kjellander <perkj@google.com> Commit-Queue: Per Kjellander <perkj@google.com> Cr-Commit-Position: refs/heads/master@{#500241} [modify] https://crrev.com/afb7e1c3e5ecab664b07cbbdeaf67283168d01cd/DEPS [modify] https://crrev.com/afb7e1c3e5ecab664b07cbbdeaf67283168d01cd/tools/roll_webrtc.py
,
Sep 7 2017
Thanks Per for (accidentally) submitting my change as part of your CL. As it works as we want, that's fine. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by grunell@chromium.org
, Aug 21 2017Status: Assigned (was: Untriaged)