New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756762 link

Starred by 1 user
Status: Fixed
Owner:
█ pho...@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
OKR

Blocked on:
issue 783393


Sign in to add a comment

Implement the CL-exonerator service

Project Member Reported by pho...@chromium.org, Aug 18 2017 
Tracking bug for the CL-exonerator service.

(1) Add a finalize annotation to cidb.
(2) Create a PubSub event whenever an annotation is entered in the annotator.
(3) Create a CL-exonerator annotation PubSub consumer with AppEngine.
  (3.1) Find the CLs in the build run
  (3.2) Check that there isn't a more recent build completed for each CL
  (3.3) Add CQ+1 label to CLs which weren't blamed as a bad CL and don't have a more recent build.

Comment 1 by pho...@chromium.org, Aug 18 2017

Components: Infra>Client>ChromeOS
Labels: -Type-Bug -Pri-3 OKR Pri-1 Type-Feature
Owner: pho...@chromium.org
Status: Started (was: startw)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/07dc24c6b2675ef14bfde387fe82754c24a0e784

commit 07dc24c6b2675ef14bfde387fe82754c24a0e784
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Nov 01 02:50:47 2017

appengine: Update fake_system_modules.py

Several changes are needed to keep fake_system_modules.py up to date with
changes to chromite:

- Add multiprocessing, ssl, subprocess to _FORBIDDEN_MODULES
- Add SIGHUP to fake_signal, because chromite.lib.paralllel uses it at the
  module level
- cidb.py uses chromite.lib.parallel, which uses multiprocessing, which assumes
  signal.SIGUSR1 is an integer.
- Catch IOError when using os.devnull at the module level in
  chromite.lib.gob_util

TEST=dev_appserver with a standard environment app that imports cidb.
BUG= chromium:756762 

Change-Id: I2f1c3897e2f48c352aa8255dd0e35488d2ba7f1f
Reviewed-on: https://chromium-review.googlesource.com/744301
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/07dc24c6b2675ef14bfde387fe82754c24a0e784/appengine/cq_stats/cq_stats/fake_system_modules.py
[modify] https://crrev.com/07dc24c6b2675ef14bfde387fe82754c24a0e784/lib/gob_util.py
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/fc51e07b9da605caf3dbe9c01929c75684e9e3fe

commit fc51e07b9da605caf3dbe9c01929c75684e9e3fe
Author: Paul Hobbs <phobbs@google.com>
Date: Mon Nov 06 17:38:35 2017

Switch to using Flexible environment

- Added example code to fetch Gerrit CL info
- Added a README
- updated .gitignore with env/

BUG= chromium:756762 
TEST=gunicorn runs the app locally, can fetch gerrit CL

Change-Id: Idf8d31960d313a0d06e3607584cea3b687f6c12d

[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/markupsafe/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/formparser.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/datastructures.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/markupsafe/_compat.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/DESCRIPTION.rst
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/testing.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/appengine_config.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/filesystem.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/markupsafe/_speedups.c
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/_compat.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/_compat.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/jsrouting.py
[modify] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/requirements.txt
[modify] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/.gitignore
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/METADATA
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/LICENSE.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/types.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/nodes.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/RECORD
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/compiler.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/exceptions.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/top_level.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/wsgi.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/DESCRIPTION.rst
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/RECORD
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/tests.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/globals.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/style.css
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/urls.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/metadata.json
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/__main__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/_compat.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/debughelpers.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/utils.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/debugger.js
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/limiter.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/wrappers.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/entry_points.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/top_level.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/optimizer.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/top_level.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/WHEEL
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/ext/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/markupsafe/_native.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/INSTALLER
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/environment.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/_bashcomplete.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/source.png
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/exthook.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/posixemulation.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/meta.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/views.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/top_level.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/serving.py
[add] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/dev_requirements.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/WHEEL
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/routing.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/blueprints.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/jquery.js
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/cache.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/defaults.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/security.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/sessions.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/INSTALLER
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/signals.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/lint.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/profiler.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/visitor.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/_textwrap.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/DESCRIPTION.rst
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/local.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/cli.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/sessions.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/termui.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/LICENSE.txt
[add] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/gunicorn.conf.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/METADATA
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/metadata.json
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/config.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/_compat.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/testtools.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/markupsafe/_speedups.so
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/_winconsole.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/RECORD
[modify] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/app.yaml
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/INSTALLER
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/json.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/utils.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/LICENSE.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/test.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/exceptions.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/RECORD
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/exceptions.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/ubuntu.ttf
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/FONT_LICENSE
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/DESCRIPTION.rst
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/_stringdefs.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/top_level.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/DESCRIPTION.rst
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/useragents.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/core.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/iterio.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/loaders.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/DESCRIPTION.rst
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/METADATA
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/WHEEL
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/globals.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/WHEEL
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/filters.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/lexer.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/LICENSE.txt
[add] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/chromite
[add] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/README.md
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/INSTALLER
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/asyncsupport.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/tbtools.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/asyncfilters.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/logging.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/more.png
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/METADATA
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/formatting.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/repr.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/less.png
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/parser.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/METADATA
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/atom.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/templating.py
[modify] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/locked_requirements.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/_reloader.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/METADATA
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/_unicodefun.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/RECORD
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/ext.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/INSTALLER
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Werkzeug-0.12.2.dist-info/metadata.json
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Flask-0.12.2.dist-info/entry_points.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/shared/console.png
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/metadata.json
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/WHEEL
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/bccache.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/Jinja2-2.9.6.dist-info/WHEEL
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/metadata.json
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/script.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/idtracking.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/fixers.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/runtime.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/wrappers.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/securecookie.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/http.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/_termui_impl.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/parser.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/_internal.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/app.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/top_level.txt
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/testing.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/constants.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/contrib/wrappers.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/helpers.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/itsdangerous-0.24.dist-info/metadata.json
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/decorators.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/debug/console.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/markupsafe/_constants.py
[modify] https://crrev.com/fc51e07b9da605caf3dbe9c01929c75684e9e3fe/main.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/werkzeug/testapp.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click-6.7.dist-info/INSTALLER
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/utils.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/click/__init__.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/debug.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/flask/ctx.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/jinja2/sandbox.py
[delete] https://crrev.com/2f9d4a4cc13f3c0978a19c3a0fae456b67c9030b/lib/MarkupSafe-1.0.dist-info/RECORD
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d327111f4a881ce1e1bcd07141eba3b8f926dedb

commit d327111f4a881ce1e1bcd07141eba3b8f926dedb
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Nov 08 23:10:22 2017

cidb: Changes for cl_exonerator

- Add GetBuildMessagesNewerThan method
- Add MESSAGE_TYPE_ANNOTATIONS_FINALIZED constant

BUG= chromium:756762 
TEST=None

Change-Id: I318d95bc5ee8b3fed317b652dcbe282050b667f6
Reviewed-on: https://chromium-review.googlesource.com/755622
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d327111f4a881ce1e1bcd07141eba3b8f926dedb/lib/constants.py
[modify] https://crrev.com/d327111f4a881ce1e1bcd07141eba3b8f926dedb/lib/cidb.py

Comment 8 by pho...@chromium.org, Nov 9 2017

Blockedon: 783393
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/7b34a150570e7d3ca1df10110f8947ca3c98a540

commit 7b34a150570e7d3ca1df10110f8947ca3c98a540
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 14 18:53:22 2017

Use google.cloud.datastore instead of ndb

ndb can only be used in Standard AppEngine apps.

TEST=unit tests
BUG= chromium:756762 

Change-Id: I8f14afc52565bfcf4cb31efd0ea716e52723d856

[modify] https://crrev.com/7b34a150570e7d3ca1df10110f8947ca3c98a540/exonerator/innocent_cls_test.py
[modify] https://crrev.com/7b34a150570e7d3ca1df10110f8947ca3c98a540/requirements.txt
[modify] https://crrev.com/7b34a150570e7d3ca1df10110f8947ca3c98a540/exonerator/innocent_cls.py
[modify] https://crrev.com/7b34a150570e7d3ca1df10110f8947ca3c98a540/main.py
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/2af42d0f8c6b31354d0faf2a66213a82622bb0d8

commit 2af42d0f8c6b31354d0faf2a66213a82622bb0d8
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 14 18:53:22 2017

Production requirements.txt should use pymysql

chromite.lib.cidb configures CIDBConnections that use service_account=True to
use pymysql (the pure-python library), not the native MySQLdb. Change
requirements.txt and dev_requirements.txt to reflect this.

TEST=Can create a CIDBConnection in prod now.
BUG= chromium:756762 

Change-Id: I32fae45dd22e60d9f6a2a0260821b7773c9da207

[modify] https://crrev.com/2af42d0f8c6b31354d0faf2a66213a82622bb0d8/requirements.txt
[modify] https://crrev.com/2af42d0f8c6b31354d0faf2a66213a82622bb0d8/dev_requirements.txt
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/9614a3e1a9f0d87130fa13234c195eaf039b46da

commit 9614a3e1a9f0d87130fa13234c195eaf039b46da
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 14 18:53:22 2017

Add deploy_app script.

Adapted from cq_stat's deploy_app script.

BUG= chromium:756762 
TEST=used it.

Change-Id: Ib4ec98c56b9a0f3e31445ee5be9b7b3949b7b9f1

[add] https://crrev.com/9614a3e1a9f0d87130fa13234c195eaf039b46da/deploy_app.py
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/4ac8b2c0d53b5b4404f9d68c002f3bf364f46d85

commit 4ac8b2c0d53b5b4404f9d68c002f3bf364f46d85
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 14 18:53:22 2017

Add DEBUG environment variable.

TEST=None
BUG= chromium:756762 

Change-Id: Id43b9f8464c9429b1889df77b81d81e55990cd71

[modify] https://crrev.com/4ac8b2c0d53b5b4404f9d68c002f3bf364f46d85/app.yaml
[modify] https://crrev.com/4ac8b2c0d53b5b4404f9d68c002f3bf364f46d85/main.py
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/68e711811334cc172d503ec406fbaa1e1d71139f

commit 68e711811334cc172d503ec406fbaa1e1d71139f
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 14 18:53:22 2017

innocent_cls: Allow toggling checkpointing

This will be useful for making debug endpoints that print out the pending CLs to
be exonerated.

TEST=None
BUG= chromium:756762 

Change-Id: I9bc5e630c8c15b95cce14e8b08936ab63ab15575

[modify] https://crrev.com/68e711811334cc172d503ec406fbaa1e1d71139f/exonerator/innocent_cls.py
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/9c15153195ac07985e235f68562522ad87d0c41f

commit 9c15153195ac07985e235f68562522ad87d0c41f
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 14 18:59:40 2017

Moved configuration to config.py

TEST=None
BUG= chromium:756762 

Change-Id: I4967acdbb992475734bb71eceea85ed2c2e1b1dc

[add] https://crrev.com/9c15153195ac07985e235f68562522ad87d0c41f/config.py
[modify] https://crrev.com/9c15153195ac07985e235f68562522ad87d0c41f/main.py
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d1c2163097ade5065890ddab88634e7a3e1b3f19

commit d1c2163097ade5065890ddab88634e7a3e1b3f19
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Nov 15 08:39:53 2017

gob_util: Support Appengine Gerrit credentials.

Add a fallback to AppAssertionCredentials for using service accounts from
Appengine.

BUG= chromium:756762 
TEST=unit tests pass.

Change-Id: I1497f82dbb107e29db8168a2e073861466f8f3fa
Reviewed-on: https://chromium-review.googlesource.com/761979
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d1c2163097ade5065890ddab88634e7a3e1b3f19/lib/gob_util.py
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f364cf3153839b017228d0fa4bdc79a4ec483e1b

commit f364cf3153839b017228d0fa4bdc79a4ec483e1b
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 16 02:42:59 2017

Revert "gob_util: Support Appengine Gerrit credentials."

This reverts commit d1c2163097ade5065890ddab88634e7a3e1b3f19.

Reason for revert:  https://crbug.com/785606 


Original change's description:
> gob_util: Support Appengine Gerrit credentials.
> 
> Add a fallback to AppAssertionCredentials for using service accounts from
> Appengine.
> 
> BUG= chromium:756762 
> TEST=unit tests pass.
> 
> Change-Id: I1497f82dbb107e29db8168a2e073861466f8f3fa
> Reviewed-on: https://chromium-review.googlesource.com/761979
> Commit-Ready: Paul Hobbs <phobbs@google.com>
> Tested-by: Paul Hobbs <phobbs@google.com>
> Reviewed-by: Paul Hobbs <phobbs@google.com>

Bug:  chromium:756762 
Change-Id: I5210376900995bdd3b942cfb2cf1467e57db54d6
Reviewed-on: https://chromium-review.googlesource.com/773639
Reviewed-by: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/f364cf3153839b017228d0fa4bdc79a4ec483e1b/lib/gob_util.py
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/cf97639749420173d6278a69d7bca928f589fe5b

commit cf97639749420173d6278a69d7bca928f589fe5b
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 16 19:41:29 2017

Added local server script

BUG= chromium:756762 
TEST=ran the script

Change-Id: I317e09b48fabf3bb1566f49b272c665f21f3f45d

[modify] https://crrev.com/cf97639749420173d6278a69d7bca928f589fe5b/README.md
[add] https://crrev.com/cf97639749420173d6278a69d7bca928f589fe5b/bin/local_server
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/23c92352afb4383a7ee09c0a0b611aba1228a22a

commit 23c92352afb4383a7ee09c0a0b611aba1228a22a
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 16 19:46:56 2017

Add debug routes for inspecting app state

TEST=Ran locally
BUG= chromium:756762 

Change-Id: Ic186b53aa6b4d44e555c7fe574b28e173e06d6f1

[add] https://crrev.com/23c92352afb4383a7ee09c0a0b611aba1228a22a/debug_routes.py
[modify] https://crrev.com/23c92352afb4383a7ee09c0a0b611aba1228a22a/exonerator/gerrit.py
[modify] https://crrev.com/23c92352afb4383a7ee09c0a0b611aba1228a22a/main.py
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/81e162143c3345c27fa5dc4291edaa13598940d5

commit 81e162143c3345c27fa5dc4291edaa13598940d5
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 16 21:34:44 2017

annotator: Add buildMessageTable model

We will use the buildMessageTable for finalize annotations.

BUG= chromium:756762 
TEST=Tested locally

Change-Id: I973ff4bea17b6d353bce4e5f4c73d3c57f77cb46
Reviewed-on: https://chromium-review.googlesource.com/770493
Reviewed-by: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/81e162143c3345c27fa5dc4291edaa13598940d5/appengine/cq_stats/build_annotations/models.py
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f124c2bb3a1e0c916bea5fbc1253325e851d3bf3

commit f124c2bb3a1e0c916bea5fbc1253325e851d3bf3
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Nov 17 00:53:18 2017

annotator: Fix _MaybeSaveFinalizeMessage

TEST=None
BUG= chromium:756762 

Change-Id: I818ec4e3dcaec22dbdaebcb5ad52b317b2ece731
Reviewed-on: https://chromium-review.googlesource.com/776121
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/f124c2bb3a1e0c916bea5fbc1253325e851d3bf3/appengine/cq_stats/build_annotations/views.py
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b9740471f5987894bae6058bb76eb99f9be52690

commit b9740471f5987894bae6058bb76eb99f9be52690
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Nov 17 00:53:25 2017

annotator: Fix finalize field.value usage.

TEST=Tested locally
BUG= chromium:756762 

Change-Id: Ie9292a932fa83a603134069151ab0a4ed528e00f
Reviewed-on: https://chromium-review.googlesource.com/776122
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/b9740471f5987894bae6058bb76eb99f9be52690/appengine/cq_stats/build_annotations/templates/build_annotations/edit_annotations.html
[modify] https://crrev.com/b9740471f5987894bae6058bb76eb99f9be52690/appengine/cq_stats/build_annotations/views.py
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/78eba04755fc6b14718237c68f7981446570d9e6

commit 78eba04755fc6b14718237c68f7981446570d9e6
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 16 21:53:56 2017

Parallelize /cron/exonerate

To make this work with iterator-based checkpointing, have NewInnocentCLs()
yield a batch of CLs for each finalize message, and parallelize exonerations
within each batch.

BUG= chromium:756762 
TEST=work in progress

Change-Id: I83f6a8579e1ac2a8e08cfc08482155659b92f926

[modify] https://crrev.com/78eba04755fc6b14718237c68f7981446570d9e6/debug_routes.py
[modify] https://crrev.com/78eba04755fc6b14718237c68f7981446570d9e6/exonerator/innocent_cls.py
[modify] https://crrev.com/78eba04755fc6b14718237c68f7981446570d9e6/exonerator/innocent_cls_test.py
[modify] https://crrev.com/78eba04755fc6b14718237c68f7981446570d9e6/main.py
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/251920387bce21a10ad59c5050569927745aa51a

commit 251920387bce21a10ad59c5050569927745aa51a
Author: Paul Hobbs <phobbs@google.com>
Date: Sat Nov 18 04:18:22 2017

cidb: Allow CLAction build_id to be NULL

This supports creating CLActions from non-build services, such as CL-exonerator.

TEST=None
BUG= chromium:756762 

Change-Id: I62383371b91eaa7778bab54ec0c269479a4343a6
Reviewed-on: https://chromium-review.googlesource.com/776132
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/251920387bce21a10ad59c5050569927745aa51a/cidb/schema.dump
[add] https://crrev.com/251920387bce21a10ad59c5050569927745aa51a/cidb/migrations/00063-alter_claction_table_allow_build_id_null.sql
[modify] https://crrev.com/251920387bce21a10ad59c5050569927745aa51a/lib/cidb_integration_test.py
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/24598496ce33910ed2c888475a2c5f53ba854537

commit 24598496ce33910ed2c888475a2c5f53ba854537
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Nov 17 22:41:30 2017

Insert CLAction upon exoneration

TEST=None
BUG= chromium:756762 

Change-Id: I2d52aaa8852024f86e0e442d41f70c71d61d9e36

[modify] https://crrev.com/24598496ce33910ed2c888475a2c5f53ba854537/exonerator/gerrit.py
[modify] https://crrev.com/24598496ce33910ed2c888475a2c5f53ba854537/main.py
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/9fed3ae85b8d180671e9144b7dd25e304fba6b53

commit 9fed3ae85b8d180671e9144b7dd25e304fba6b53
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 21 00:28:36 2017

deploy_app: Prompt for password, fill in app.yaml

Changed app.yaml to be a Jinja2 template. The deploy_app.py script now prompts
for a password, hashes it, and fills in the app.yaml template in the deployment
staging temporary directory.

Also, updated README.md

TEST=Ran it, it works
BUG= chromium:756762 

Change-Id: I00c8cb8b7a01e02106d88bfbbbcbcd119f93ec4b

[modify] https://crrev.com/9fed3ae85b8d180671e9144b7dd25e304fba6b53/app.yaml
[modify] https://crrev.com/9fed3ae85b8d180671e9144b7dd25e304fba6b53/deploy_app.py
[modify] https://crrev.com/9fed3ae85b8d180671e9144b7dd25e304fba6b53/README.md
[modify] https://crrev.com/9fed3ae85b8d180671e9144b7dd25e304fba6b53/bin/local_server
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/4781bf9732fe903f989f4577046180907b6b9d83

commit 4781bf9732fe903f989f4577046180907b6b9d83
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 21 00:28:36 2017

CIDBConnection: for_service=$IS_SERVICE

Now that we have a DEBUG environment which is an Appengine service, use a new
environment variable, IS_SERVICE, for detecting whether we are on Appengine.

TEST=Deployed
BUG= chromium:756762 

Change-Id: I4315081932e8f6a25770de0b83f25f2377d4f0c7

[modify] https://crrev.com/4781bf9732fe903f989f4577046180907b6b9d83/main.py
[modify] https://crrev.com/4781bf9732fe903f989f4577046180907b6b9d83/debug_routes.py
[modify] https://crrev.com/4781bf9732fe903f989f4577046180907b6b9d83/exonerator/innocent_cls_test.py
[modify] https://crrev.com/4781bf9732fe903f989f4577046180907b6b9d83/bin/local_server
[modify] https://crrev.com/4781bf9732fe903f989f4577046180907b6b9d83/app.yaml
[modify] https://crrev.com/4781bf9732fe903f989f4577046180907b6b9d83/deploy_app.py
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/c0545ebf1ec1c15abec8d55d8c2cf741ba1a4712

commit c0545ebf1ec1c15abec8d55d8c2cf741ba1a4712
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 21 00:28:36 2017

Use the correct CloudSQL instance in debug.

Use _InstanceConnectionName(debug) to configure the CloudSQL instance that we
want to connect to in app.yaml.

TEST=./deploy_app --debug=True
BUG= chromium:756762 

Change-Id: Ifdc9913097303996bd57348552d6e7ad201d6ad1

[modify] https://crrev.com/c0545ebf1ec1c15abec8d55d8c2cf741ba1a4712/app.yaml
[modify] https://crrev.com/c0545ebf1ec1c15abec8d55d8c2cf741ba1a4712/deploy_app.py
Project Member

Comment 33 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/7cff97f8ee5d6474eec78803d4245b4e9f24b7c4

commit 7cff97f8ee5d6474eec78803d4245b4e9f24b7c4
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 21 00:28:36 2017

Deploy_app: allow deploying other yaml files

TEST=Used it
BUG= chromium:756762 

Change-Id: I27f861d28acf6c457d1e440ecfe358bc0d327135

[modify] https://crrev.com/7cff97f8ee5d6474eec78803d4245b4e9f24b7c4/deploy_app.py
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8ba76cfe9ff3fc7f178c34d872ec7d11c5fad240

commit 8ba76cfe9ff3fc7f178c34d872ec7d11c5fad240
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Nov 22 00:45:04 2017

annotator: Only finalize when checked

Currently we don't test whether the "Finalize annotations" checkbox was
actually checked by the user. Fix that.

BUG= chromium:756762 
TEST=Local

Change-Id: I3eaeabbae454fee8991d36749f5fe31da0489a13
Reviewed-on: https://chromium-review.googlesource.com/783527
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/8ba76cfe9ff3fc7f178c34d872ec7d11c5fad240/appengine/cq_stats/build_annotations/views.py
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b0d57d6e4ed6737c24c8e0a2955415e72cdc4ed8

commit b0d57d6e4ed6737c24c8e0a2955415e72cdc4ed8
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 23 01:29:38 2017

gob_util: Support Appengine credentials [reland]

Add a fallback to AppAssertionCredentials for using service accounts from
Appengine.

BUG= chromium:756762 
TEST=gob_util_unittest --network

Change-Id: I224b52e78bc571f186dbe19fe4beca5caf30f1c7
Reviewed-on: https://chromium-review.googlesource.com/783886
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/b0d57d6e4ed6737c24c8e0a2955415e72cdc4ed8/lib/gob_util.py
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a9afcc9c0a74cec3727a1a6f9a928725781322eb

commit a9afcc9c0a74cec3727a1a6f9a928725781322eb
Author: Paul Hobbs <phobbs@google.com>
Date: Sat Nov 25 22:01:10 2017

clactions: "rejections - exonerations" metric.

Added a metric to get a distribution of rejections - exonerations.

BUG= chromium:756762 
TEST=clactions_unittest

Change-Id: I05762225810451913bb2ff5e14504a1629137baa
Reviewed-on: https://chromium-review.googlesource.com/786258
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/a9afcc9c0a74cec3727a1a6f9a928725781322eb/lib/constants.py
[modify] https://crrev.com/a9afcc9c0a74cec3727a1a6f9a928725781322eb/lib/clactions.py
[modify] https://crrev.com/a9afcc9c0a74cec3727a1a6f9a928725781322eb/lib/cidb.py
Project Member

Comment 37 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/ccb52169e20ac00d8f02872ce929163e01592bee

commit ccb52169e20ac00d8f02872ce929163e01592bee
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Nov 21 23:54:17 2017

Add "limit" argument to /cls

BUG= chromium:756762 
TEST=local server

Change-Id: I842ef201e871b511de290b60b7db24990638896e

[modify] https://crrev.com/ccb52169e20ac00d8f02872ce929163e01592bee/debug_routes.py
Project Member

Comment 38 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/0d26d1795939786cbbea695391ebd801fbfc771a

commit 0d26d1795939786cbbea695391ebd801fbfc771a
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 30 04:58:19 2017

gerrit: Handle missing data in change details

Some revisions don't have a _number. Sometimes, we get a None
ChangeDetails.

BUG= chromium:756762 
TEST=No longer get 500s with test routes.

Change-Id: Ie18ddb210416f993cc0242156deb760af93ca9e7

[modify] https://crrev.com/0d26d1795939786cbbea695391ebd801fbfc771a/exonerator/gerrit.py
Project Member

Comment 39 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/cdd03eb9da16b1629ce6886546a6eddf0105fbb4

commit cdd03eb9da16b1629ce6886546a6eddf0105fbb4
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 30 05:03:12 2017

Fix batch exoneration (CIDBConnection is not picklable)

Insert CLActions in batch after exonerating.

BUG= chromium:756762 
TEST=None

Change-Id: I74927c7eedd3f700936ed55c97ce843b433e93f4

[modify] https://crrev.com/cdd03eb9da16b1629ce6886546a6eddf0105fbb4/debug_routes.py
[add] https://crrev.com/cdd03eb9da16b1629ce6886546a6eddf0105fbb4/exonerator/cidblib.py
[modify] https://crrev.com/cdd03eb9da16b1629ce6886546a6eddf0105fbb4/exonerator/gerrit.py
[modify] https://crrev.com/cdd03eb9da16b1629ce6886546a6eddf0105fbb4/main.py
Project Member

Comment 40 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/c3253f79d45de56603e5b9aceb6ee18f8b8e484c

commit c3253f79d45de56603e5b9aceb6ee18f8b8e484c
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 30 05:03:12 2017

Fix innocent_cls checkpointing logic

Add test for checkpointing

TEST=innocent_cls_test
BUG= chromium:756762 

Change-Id: I0a8de0d485bf9b9fc223116f0cbe17f7e220f5c5

[modify] https://crrev.com/c3253f79d45de56603e5b9aceb6ee18f8b8e484c/exonerator/innocent_cls_test.py
[modify] https://crrev.com/c3253f79d45de56603e5b9aceb6ee18f8b8e484c/exonerator/innocent_cls.py
[modify] https://crrev.com/c3253f79d45de56603e5b9aceb6ee18f8b8e484c/requirements.txt
Project Member

Comment 41 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/2722d07e17c68625686b0530055384541148d10f

commit 2722d07e17c68625686b0530055384541148d10f
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Nov 30 05:03:12 2017

Fix main.py's usage of parallel

Convert the ChangeWithBuild tuples into lists for parallel's benefit.
Improve logging in gerrit.MaybeExonerate.

BUG= chromium:756762 
TEST=manual

Change-Id: I050796ed2b26d2ee68d4533d0a390d035f5f5495

[modify] https://crrev.com/2722d07e17c68625686b0530055384541148d10f/exonerator/gerrit.py
[modify] https://crrev.com/2722d07e17c68625686b0530055384541148d10f/exonerator/cidblib.py
[modify] https://crrev.com/2722d07e17c68625686b0530055384541148d10f/main.py
Project Member

Comment 42 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/1db5a1cdda535cd36ea603cb80b83fb3d590cd40

commit 1db5a1cdda535cd36ea603cb80b83fb3d590cd40
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Dec 01 03:53:56 2017

Added /exonerate-all debug route

TEST=Used it
BUG= chromium:756762 

Change-Id: Ic698299819d9b9c8c375fb5691614e55e6fdb67c

[modify] https://crrev.com/1db5a1cdda535cd36ea603cb80b83fb3d590cd40/main.py
Project Member

Comment 43 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/7f11914d927274df52f52d748efbfb062c1acd28

commit 7f11914d927274df52f52d748efbfb062c1acd28
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Dec 01 03:53:56 2017

exonerator.gerrit: Add more safety checks

Don't exonerate CLs with Code-Review-1 or Verified-1.

Also, added more logging.

BUG= chromium:756762 
TEST=None

Change-Id: I46847e0557c59f151a096e23d1751ecfabe28415

[modify] https://crrev.com/7f11914d927274df52f52d748efbfb062c1acd28/exonerator/gerrit.py
[modify] https://crrev.com/7f11914d927274df52f52d748efbfb062c1acd28/exonerator/cidblib.py
[modify] https://crrev.com/7f11914d927274df52f52d748efbfb062c1acd28/exonerator/innocent_cls.py
[modify] https://crrev.com/7f11914d927274df52f52d748efbfb062c1acd28/main.py
Project Member

Comment 44 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/470833274a7143efb4e09565561246802be7e575

commit 470833274a7143efb4e09565561246802be7e575
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Dec 01 03:53:56 2017

exonerator.gerrit: Add FailedToApply check.

Check whether a change failed to apply before exonerating.

TEST=None
BUG= chromium:756762 

Change-Id: I4a17214eeabfb43401fc693c37aad7ad530a3226

[modify] https://crrev.com/470833274a7143efb4e09565561246802be7e575/exonerator/gerrit.py
[modify] https://crrev.com/470833274a7143efb4e09565561246802be7e575/exonerator/cidblib.py
Project Member

Comment 46 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/29ec8f7c704596b7293e9bd140cacfa09fdd95b1

commit 29ec8f7c704596b7293e9bd140cacfa09fdd95b1
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Dec 01 19:24:34 2017

local_server: Add --port option.

Also, only use 1 worker process. This reduces the log noise when you interrupt
the server, as each child process dumps a stacktrace.

BUG= chromium:756762 
TEST=Used it.

Change-Id: If28c0478a69b3b54395e84e734ca26b9e64e63fc

[modify] https://crrev.com/29ec8f7c704596b7293e9bd140cacfa09fdd95b1/bin/local_server

Comment 47 by akes...@chromium.org, Dec 13 2017

Status: Fixed (was: Started)
Closing this. The service is implemented. There will be follow up work, that can be tracked in its own bugs.
►

Sign in to add a comment