Issue metadata
Sign in to add a comment
|
Regression : 'Google Profile photo(loading)' Tool tip is seen instead of 'Google Profile photo' Tool tip in chrome://settings/changePicture page |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3163.51/9765.31.0 dev-channel Peppy,Daisy and Kip OS: Chrome Pre-Condition : Login with Account which should not have 'Google Profile photo' What steps will reproduce the problem? (1)Sign in to user -> Go to chrome://settings/changePicture page (2)Now hover the mouse pointer at 'Google Profile photo' icon and observe 'Google Profile photo(loading)' Tool tip (Please refer Video and screenshot) Expected:'Google Profile photo' Tool tip should be seen Actual: Instead 'Google Profile photo(loading)' Tool tip is seen This is Regression Issue as same is working fine in 60.0.3112.101/9592.82.0 stable-channel Peppy @stevenjb : Please confirm the Issue Note: Issue is seen on latest M-62 also
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/278b43368b1ad92f37ddc4363b6c18f14e857eb6 commit 278b43368b1ad92f37ddc4363b6c18f14e857eb6 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Aug 18 21:50:12 2017 Settings: Change Picture: Fix tooltop We don't actually track the loading state of the Google profile image so we should just remove the (loading) version of the tooltip. Bug: 756761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8d7f53c62cf6699b1b2cea2b52cf8ad87538d3dd Reviewed-on: https://chromium-review.googlesource.com/621407 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#495702} [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/chrome/app/settings_strings.grdp [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/chrome/browser/resources/chromeos/login/oobe_change_picture.html [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/chrome/browser/resources/settings/people_page/change_picture.html [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html [modify] https://crrev.com/278b43368b1ad92f37ddc4363b6c18f14e857eb6/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Aug 22 2017
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6051a030f4f44bcb0fec7c94921931d4d5ebefc6 commit 6051a030f4f44bcb0fec7c94921931d4d5ebefc6 Author: David Reveman <reveman@chromium.org> Date: Fri Aug 25 08:01:54 2017 Settings: Change Picture: Fix tooltop We don't actually track the loading state of the Google profile image so we should just remove the (loading) version of the tooltip. TBR=stevenjb@chromium.org (cherry picked from commit 278b43368b1ad92f37ddc4363b6c18f14e857eb6) Bug: 756761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8d7f53c62cf6699b1b2cea2b52cf8ad87538d3dd Reviewed-on: https://chromium-review.googlesource.com/621407 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#495702} Reviewed-on: https://chromium-review.googlesource.com/634985 Cr-Commit-Position: refs/branch-heads/3163@{#879} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/chrome/app/settings_strings.grdp [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/chrome/browser/resources/chromeos/login/oobe_change_picture.html [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/chrome/browser/resources/settings/people_page/change_picture.html [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html [modify] https://crrev.com/6051a030f4f44bcb0fec7c94921931d4d5ebefc6/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Aug 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0deb79d3996e1c33cd4f409b89fb9681d599bec2 commit 0deb79d3996e1c33cd4f409b89fb9681d599bec2 Author: Vladislav Kaznacheev <kaznacheev@chromium.org> Date: Sat Aug 26 00:32:27 2017 Revert "Settings: Change Picture: Fix tooltop" This reverts commit 6051a030f4f44bcb0fec7c94921931d4d5ebefc6. Reason for revert: Breaks compile (IDS_OPTIONS_CHANGE_PICTURE_PROFILE_LOADING_PHOTO required by chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc) Original change's description: > Settings: Change Picture: Fix tooltop > > We don't actually track the loading state of the Google profile image > so we should just remove the (loading) version of the tooltip. > > TBR=stevenjb@chromium.org > > (cherry picked from commit 278b43368b1ad92f37ddc4363b6c18f14e857eb6) > > Bug: 756761 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8d7f53c62cf6699b1b2cea2b52cf8ad87538d3dd > Reviewed-on: https://chromium-review.googlesource.com/621407 > Reviewed-by: David Reveman <reveman@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#495702} > Reviewed-on: https://chromium-review.googlesource.com/634985 > Cr-Commit-Position: refs/branch-heads/3163@{#879} > Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} TBR=stevenjb@chromium.org,reveman@chromium.org Change-Id: Ibf44fc32cdbc5cf12e670eb93cb8c808d8cfbb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/636774 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#910} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/chrome/app/settings_strings.grdp [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/chrome/browser/resources/chromeos/login/oobe_change_picture.html [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/chrome/browser/resources/settings/people_page/change_picture.html [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html [modify] https://crrev.com/0deb79d3996e1c33cd4f409b89fb9681d599bec2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Aug 18 2017Status: Started (was: Assigned)