New Translate Infobar - Adjust tab text, button color and icon space |
|||
Issue descriptionAfter discussion, we want to do the following for the new translate infobar: 1. Adjust the font color of non-selected language text to #5a5a5a (same as the close button) 2. Adjust the color of the menu button (3 dots) to #5a5a5a (same as the close button) 3. Adjust the space for the translation logo, from 56dp to 48dp. 4. Force the tab text to be single line. (See attached picture) ------------------------------------ Steps to show the new translate infobar: 1. Enable the flag "New Translate Infobar" flag from about://flags page 2. Visit any page in a language other than the System language(s). (Example - Baidu.com,m.yahoo.com.jp) 3. Wait for page load to finish, then the new translate infobar will appear.
,
Aug 21 2017
Rachel - can you please confirm that this is all correct? In particular is 1 ok? ("Adjust the font color of non-selected language text to #5a5a5a") It was not clear to me from the email thread that the non-selected text can be adjusted.
,
Aug 23 2017
crrev.com/c/622456 got LGTM and ready to commit. But Theresa suggests that for a long term solution, we should pick one of the accepted text styles in the go/clankstyles doc. If we are in doubt to the text color, I was wondering if we should skip (1) for now and just do 2,3,4?
,
Aug 23 2017
Thanks Yana!
No, 1 isn't correct. My apologies if that was unclear in the email thread ("Translate toggle tweaks"). We'd like to keep the font color consistent with spec for now, which it currently is. Please do bring this question to the EM UX office hour so we can chat further there.
2,3,4 are all correct! :)
,
Aug 24 2017
Thanks Rachel and Yana, I will skip 1 and do 2,3,4
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/827dc08a47d26c1533d3600a3ee4c9758680a919 commit 827dc08a47d26c1533d3600a3ee4c9758680a919 Author: Marti Wong <martiw@chromium.org> Date: Thu Aug 24 07:50:21 2017 New Translate Infobar - Adjust color, spacing and force single-line tab. This CL will: 1. Adjust the color of the menu button (3 dots button) to #5a5a5a. 2. Adjust the space for the translation logo, from 56dp to 48dp. 3. Force the tab text to be single line. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=299225&inline=1 Bug: 756753 Change-Id: I6fd7f0a478503bc6933a57fbfb74bbff04225f0a Reviewed-on: https://chromium-review.googlesource.com/622456 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#496974} [modify] https://crrev.com/827dc08a47d26c1533d3600a3ee4c9758680a919/chrome/android/java/res/layout/infobar_translate_compact_content.xml [modify] https://crrev.com/827dc08a47d26c1533d3600a3ee4c9758680a919/chrome/android/java/res/layout/infobar_translate_tab_content.xml [modify] https://crrev.com/827dc08a47d26c1533d3600a3ee4c9758680a919/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarCompactLayout.java
,
Sep 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by martiw@chromium.org
, Aug 21 2017