browser_tests in chromium.webrtc.fyi fails due to missing frame_analyzer |
||
Issue descriptionAfter https://chromium-review.googlesource.com/616736 the slave checkouts were changed and some of the build output directories were clobbered. This seems to have surfaced a hidden bug: that the frame_analyzer tool, which is needed by our browser_tests video quality tests, is no longer built as part of the 'all' target. This has caused browser_tests to start failing.
,
Aug 18 2017
After closer inspection it seems frame_analyzer is built as it should, at least for Release builds. The problem was that the new Debug builders took over the triggering of the Testers, which also have been running with debug builds for ~1 day. This is being fixed in https://chromium-review.googlesource.com/620588
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/447498951dda678acfa8af0b306a5931a1394c08 commit 447498951dda678acfa8af0b306a5931a1394c08 Author: Henrik Kjellander <kjellander@chromium.org> Date: Fri Aug 18 07:22:53 2017 WebRTC: Fix bug causing Debug builders to trigger testers In https://chromium-review.googlesource.com/616736 a bug was introduced that caused the debug builders to take over the triggering of the testers instead of the Release builders. Using platform+build config as key in the dictionary will restore the previous behavior. This would have been caught if we had the expectations around, but it has been decided they're undesired, so we lost that protection. BUG= 756741 TBR=iannucci@chromium.org, ehmaldonado@chromium.org Change-Id: I3054542929b7cbc3b32ee31ef72fdea81c7b3981 Reviewed-on: https://chromium-review.googlesource.com/620588 Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> [modify] https://crrev.com/447498951dda678acfa8af0b306a5931a1394c08/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
,
Aug 18 2017
I've now verified builds are back to normal. |
||
►
Sign in to add a comment |
||
Comment 1 by emir...@chromium.org
, Aug 18 2017