New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

browser_tests in chromium.webrtc.fyi fails due to missing frame_analyzer

Project Member Reported by kjellander@chromium.org, Aug 18 2017

Issue description

After https://chromium-review.googlesource.com/616736 the slave checkouts were changed and some of the build output directories were clobbered.

This seems to have surfaced a hidden bug: that the frame_analyzer tool, which is needed by our browser_tests video quality tests, is no longer built as part of the 'all' target. This has caused browser_tests to start failing.


 
Thanks for the catch. I suspected another patch in the range to be related since it was VPX only, but just found out that H264 was disabled for another reason. Relanding it here: https://codereview.webrtc.org/3002933002/.
After closer inspection it seems frame_analyzer is built as it should, at least for Release builds. The problem was that the new Debug builders took over the triggering of the Testers, which also have been running with debug builds for ~1 day.

This is being fixed in https://chromium-review.googlesource.com/620588
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/447498951dda678acfa8af0b306a5931a1394c08

commit 447498951dda678acfa8af0b306a5931a1394c08
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Fri Aug 18 07:22:53 2017

WebRTC: Fix bug causing Debug builders to trigger testers

In https://chromium-review.googlesource.com/616736 a bug was introduced
that caused the debug builders to take over the triggering of the testers
instead of the Release builders.

Using platform+build config as key in the dictionary will restore the previous
behavior.

This would have been caught if we had the expectations around, but
it has been decided they're undesired, so we lost that protection.

BUG= 756741 
TBR=iannucci@chromium.org, ehmaldonado@chromium.org

Change-Id: I3054542929b7cbc3b32ee31ef72fdea81c7b3981
Reviewed-on: https://chromium-review.googlesource.com/620588
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/447498951dda678acfa8af0b306a5931a1394c08/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py

Status: Fixed (was: Assigned)
I've now verified builds are back to normal.

Sign in to add a comment