New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756739 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add UMA for hiding window animation

Project Member Reported by wutao@chromium.org, Aug 18 2017

Issue description

Add one UMA for hiding window animation smoothness, used in closing windows, so that we can evaluate how much improvement we can achieve by caching render surface.

 

Comment 1 by wutao@chromium.org, Aug 18 2017

Labels: Merge-Request-61
ketakid@:

We want to merge this back to M61 so that we can compare the improvement metrics with M62. Thanks

Project Member

Comment 2 by sheriffbot@chromium.org, Aug 18 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 22 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cd8c28952cea1df929f9ff3453383fc7d4361bf

commit 5cd8c28952cea1df929f9ff3453383fc7d4361bf
Author: wutao <wutao@chromium.org>
Date: Wed Aug 23 04:49:01 2017

CrOS: Add UMA for hiding window animation.

Add one UMA for hiding window animation smoothness, used in closing
windows, so that we can evaluate how much improvement we can achieve
by caching render surface.

Bug:  756739 
TEST: has histogram at local device.
Change-Id: I11e3ab879e246b034f021caa3340061aec188220
Reviewed-on: https://chromium-review.googlesource.com/620253
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496587}
[modify] https://crrev.com/5cd8c28952cea1df929f9ff3453383fc7d4361bf/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/5cd8c28952cea1df929f9ff3453383fc7d4361bf/ui/wm/core/window_animations.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2191ed40f075330fcc912d2a1063c0e222f1d7ef

commit 2191ed40f075330fcc912d2a1063c0e222f1d7ef
Author: Qiang Xu <warx@chromium.org>
Date: Wed Aug 23 23:58:11 2017

m61 merge: CrOS: Add UMA for hiding window animation.

m61 merge on behalf of wutao@.

Add one UMA for hiding window animation smoothness, used in closing
windows, so that we can evaluate how much improvement we can achieve
by caching render surface.

TBR: reveman@chromium.org, varkha@chromium.org, sky@chromium.org,
holte@chromium.org

(cherry picked from commit 5cd8c28952cea1df929f9ff3453383fc7d4361bf)

Bug:  756739 
TEST: has histogram at local device.
Change-Id: I11e3ab879e246b034f021caa3340061aec188220
Reviewed-on: https://chromium-review.googlesource.com/620253
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Valery Arkhangorodsky <varkha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496587}
Reviewed-on: https://chromium-review.googlesource.com/630638
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#843}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/2191ed40f075330fcc912d2a1063c0e222f1d7ef/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/2191ed40f075330fcc912d2a1063c0e222f1d7ef/ui/wm/core/window_animations.cc

Comment 7 by wutao@chromium.org, Aug 25 2017

Status: Fixed (was: Available)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment