Issue metadata
Sign in to add a comment
|
Regression: Weird buttons is seen on Allow/block bubble.
Reported by
db...@etouch.net,
Aug 18 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3189.0 (Official Build) dcbb81a3ed5ff9bff681d3227bbb30e403239eea-refs/heads/master@{#495 (64-bit) OS: Mac(10.12.3, 10.11.6), What steps will reproduce the problem? (1) Launch chrome, open NTP and click on 'Search by Voice' icon near search engine. (2) Observe buttons on bubble. Actual: Weird buttons is seen on Allow/block bubble. Expected: Allow and Block buttons should seen proper. This is Regression Issue broken in M-62 and will soon update the other bisect info. Manual Bisect Info: Good Build: 62.0.3188.0 Bad Build: 62.0.3189.0
,
Aug 18 2017
Yikes! tapted might have some ideas...
,
Aug 18 2017
,
Aug 18 2017
I bisected with python bisect_builds.py -o -amac --good=495209 --bad=495226 -- --no-first-run https://permission.site Which gives a single revision 339cc03 Merge views::CustomButton into views::Button. by Evan Stade ยท 13 hours ago --> Reviewed-on: https://chromium-review.googlesource.com/617407 This text ugliness usually happens when the text is being painted on to a transparent canvas. You are probably looking for a change made after 495214 (known good), but no later than 495215 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/826deb2b00f0b13fc8d2c9e8e53d5df0cdf12ec6..339cc036e7c749ce416ef9d9f46159d2dceadbdf
,
Aug 18 2017
Likely also causing Issue 756848 ?
,
Aug 18 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd97f8280d14e0638f766278936445ebc5ea1605 commit fd97f8280d14e0638f766278936445ebc5ea1605 Author: Evan Stade <estade@chromium.org> Date: Fri Aug 18 17:42:33 2017 Fix button border/background painting. Regression from I7e4922fcb73a185b873acf3525d TBR=sky@chromium.org Bug: 756719 , 756720 , 756728 , 756734 , 756737 , 756848 Change-Id: I35f34055bbe0982d20d64ea1a0f05b1a5231a7a7 Reviewed-on: https://chromium-review.googlesource.com/621446 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#495604} [modify] https://crrev.com/fd97f8280d14e0638f766278936445ebc5ea1605/ui/views/controls/button/button.cc
,
Aug 18 2017
Thanks for the fix. dbote@ Please verify in canary.
,
Aug 18 2017
,
Aug 19 2017
Issue 757154 has been merged into this issue.
,
Aug 21 2017
With respect to comment 8: Issue is fixed on latest Canary #62.0.3192.0
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by db...@etouch.net
, Aug 18 2017Components: UI>Browser>Bubbles
Labels: -Type-Bug -Pri-3 M-62 OS-Mac Pri-1 Type-Bug-Regression