New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756736 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Font size Drop down in misplaced

Reported by aiman.an...@etouch.net, Aug 18 2017

Issue description

Chrome Version: 62.0.3189.0 (Official Build) dcbb81a3ed5ff9bff681d3227bbb30e403239eea-refs/heads/master@{#495 (64-bit)

OS:  Mac(10.12.3, 10.11.6),

Steps to Reproduce:
1.Launch chrome, go to chrome://settings/Appearance and observe.

Actual Result: Font size drop down is misplaced
Expected Result:  Font size drop down should not be misplaced

This is Regression Issue broken in M-62 and will soon update the other bisect info.

Manual Bisect Info:
Good Build: 62.0.3188.0
Bad Build: 62.0.3189.0

 
Actual Result.png
243 KB View Download
Components: UI>Settings
Labels: M-62
Labels: OS-Windows
Expected Result.png
198 KB View Download
Labels: Needs-Bisect OS-Chrome OS-Linux
Can we get a bisect to figure out when this regressed? I think it might be fixed again - at least, I can't reproduce this in 62.0.3188.0.
Cc: jmukthavaram@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7, mac 10.12.6 & ubuntu 14.04 using latest Canary-62.0.3189.0.
Manual Bisect Info:
————————-
Good Build: 62.0.3188.0 - Revision-495023
Bad Build: 62.0.3189.0 - Revision- 495410

Per revision bisect info:
-------------------------
You are probably looking for a change made after 495358 (known good), but no later than 495359 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/90da7ff5e6a95c7fc7987fe7291d9a6be9483478..10db7308a27aaedef35b99ca8c0dff339a8a27e7

dschuyler@,Could you please take a look & reassign to the respective owner if it is not related to your change.

As it is a recent regression in M62, adding 'Release block Stable' label.

Thanks..!!

Status: Started (was: Assigned)
Labels: -OS-Linux
No repro on Linux - I think this is Mac only.
Err, more correctly, I suspect it's Mac and Chromeos. I've verified that it's not on Linux and expect it would also not repro on Windows (but haven't tested that).
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a

commit 8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Sat Aug 19 02:50:52 2017

[MD settings] settings-toggle-button default to settings-box styling

This CL changes the default settings-toggle-button style to be as a
.settings-box so that class="settings-box" need not be used on every
instance. Also changes remaining toggles rows to be fully clickable;
along with a formatting error on mac/chromeos with the font size 
drop-down.

Bug:  734275 ,  756736 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e61fc4d7b6e2229aea1f1d05da0da0a7a5f05f2
Reviewed-on: https://chromium-review.googlesource.com/619757
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495792}
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/pointers.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/power.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/device_page/stylus.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/people_page/users_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/site_settings/category_default_setting.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/site_settings/pdf_documents.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/browser/resources/settings/system_page/system_page.html
[modify] https://crrev.com/8aa2bf834647e8f2e5f97f8b0e9cc98cb727d44a/chrome/test/data/webui/settings/device_page_tests.js

Status: Fixed (was: Started)
Cc: bettes@chromium.org tbuck...@chromium.org dschuyler@chromium.org
 Issue 757176  has been merged into this issue.

Sign in to add a comment