New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756724 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

PermissionContextBaseTests failure in unit_tests

Project Member Reported by michae...@chromium.org, Aug 18 2017

Issue description

The test "PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0" fails when run after other PermissionContextBaseTests tests, which happens naturally when running unit_tests. It passes when the try bots re-run it standalone, as seen on the flakiness dashboard.

$ ./out_linux/rel/unit_tests --gtest_filter=PermissionContextBaseTestsInstance/PermissionContextBaseTests.TestDismissVariations/0:PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = PermissionContextBaseTestsInstance/PermissionContextBaseTests.TestDismissVariations/0:PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from PermissionContextBaseTestsInstance/PermissionContextBaseTests
[ RUN      ] PermissionContextBaseTestsInstance/PermissionContextBaseTests.TestDismissVariations/0
[       OK ] PermissionContextBaseTestsInstance/PermissionContextBaseTests.TestDismissVariations/0 (1225 ms)
[ RUN      ] PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0
../../chrome/browser/permissions/permission_context_base_unittest.cc:388: Failure
      Expected: PermissionStatusSource::MULTIPLE_DISMISSALS
      Which is: 4-byte object <03-00 00-00>
To be equal to: result.source
      Which is: 4-byte object <00-00 00-00>
../../chrome/browser/permissions/permission_context_base_unittest.cc:389: Failure
      Expected: CONTENT_SETTING_BLOCK
      Which is: 2
To be equal to: result.content_setting
      Which is: 3
../../base/test/histogram_tester.cc:178: Failure
      Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "Permissions.AutoBlocker.EmbargoStatus" does not have the right number of samples (1) in the expected bucket (2). It has (0).
../../chrome/browser/permissions/permission_context_base_unittest.cc:420: Failure
      Expected: CONTENT_SETTING_BLOCK
      Which is: 2
To be equal to: result.content_setting
      Which is: 3
../../chrome/browser/permissions/permission_context_base_unittest.cc:421: Failure
      Expected: PermissionStatusSource::MULTIPLE_DISMISSALS
      Which is: 4-byte object <03-00 00-00>
To be equal to: result.source
      Which is: 4-byte object <00-00 00-00>
../../base/test/histogram_tester.cc:178: Failure
      Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "Permissions.AutoBlocker.EmbargoPromptSuppression" does not have the right number of samples (1) in the expected bucket (2). It has (0).
../../chrome/browser/permissions/permission_context_base_unittest.cc:897: Failure
      Expected: CONTENT_SETTING_BLOCK
      Which is: 2
To be equal to: result.content_setting
      Which is: 3
../../chrome/browser/permissions/permission_context_base_unittest.cc:898: Failure
      Expected: PermissionStatusSource::MULTIPLE_DISMISSALS
      Which is: 4-byte object <03-00 00-00>
To be equal to: result.source
      Which is: 4-byte object <00-00 00-00>
../../chrome/browser/permissions/permission_context_base_unittest.cc:903: Failure
      Expected: CONTENT_SETTING_BLOCK
      Which is: 2
To be equal to: result.content_setting
      Which is: 3
../../chrome/browser/permissions/permission_context_base_unittest.cc:904: Failure
      Expected: PermissionStatusSource::MULTIPLE_DISMISSALS
      Which is: 4-byte object <03-00 00-00>
To be equal to: result.source
      Which is: 4-byte object <00-00 00-00>
[  FAILED  ] PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0, where GetParam() = 4-byte object <00-00 00-00> (23 ms)
[----------] 2 tests from PermissionContextBaseTestsInstance/PermissionContextBaseTests (1249 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (1249 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0, where GetParam() = 4-byte object <00-00 00-00>

 1 FAILED TEST
[88174:88177:0817/223649.762430:10200033260548:ERROR:kill_posix.cc(83)] Unable to terminate process group 88178: No such process (3)
[1/2] PermissionContextBaseTestsInstance/PermissionContextBaseTests.TestDismissVariations/0 (1225 ms)
[2/2] PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0 (23 ms)
1 test failed:
    PermissionContextBaseTestsInstance/PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications/0 (../../chrome/browser/permissions/permission_context_base_unittest.cc:841)
Tests took 2 seconds.
e
 

Comment 1 by raymes@chromium.org, Aug 30 2017

Cc: -patricia...@chromium.org
Labels: -Pri-1 Pri-2
Owner: patricia...@chromium.org
Status: Assigned (was: Available)
patricialor: are you able to take a look at this when you have a chance? I think this might be a test you added?
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825144c7668aeffa03ddfe0d5fb851efe75d9562

commit 825144c7668aeffa03ddfe0d5fb851efe75d9562
Author: Patti <patricialor@chromium.org>
Date: Thu Sep 14 07:22:25 2017

Permissions: Revert to defaults if no field trial variations for Embargo.

As reported in  https://crbug.com/756724 ,
PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications fails
if run after PermissionContextBaseTests.TestDismissVariations. This is because
the variations applied to test field trial behavior in TestDismissVariations
were not cleared properly (if no new variations were detected, which is what
happens when you ClearAllVariationParams(), it would just continue using the old
values).

To fix, revert to using the default values when no variations are detected. Test
this by running unit_tests with the following --gtest_filter -
PermissionContextBaseTests.TestDismissVariations:\
PermissionContextBaseTests.PushMessagingEmbargoEmbargoesNotifications

Bug:  756724 
Change-Id: Id3d895405a6c350de207082e83477001aa379c00
Reviewed-on: https://chromium-review.googlesource.com/664166
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501889}
[modify] https://crrev.com/825144c7668aeffa03ddfe0d5fb851efe75d9562/chrome/browser/permissions/permission_decision_auto_blocker.cc

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Assigned)

Sign in to add a comment