New issue
Advanced search Search tips

Issue 756722 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
danakj@chromium.org
tkent@chromium.org
jbroman@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 756721



Sign in to add a comment

Get rid of C++ style checks in check_blink_style.py

Project Member Reported by dcheng@chromium.org, Aug 18 2017 
https://docs.google.com/spreadsheets/d/1tVVQMHDst_iv1qxfJ6kQbV_SposTFMKpw_uo51syfW8/edit?usp=sharing is an overview of the current features of the C++ checker in check-webkit-style. Over half the checks can probably be eliminated; then we can look at how valuable the remaining checks are. Since most of these involve parsing C++, we should look at integrating them into clang-tidy eventually.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d6b6eeeb3d16eda186b041b139472da122b9952

commit 7d6b6eeeb3d16eda186b041b139472da122b9952
Author: Daniel Cheng <dcheng@chromium.org>
Date: Mon Aug 28 07:41:37 2017

Clean up unneeded C++ WebKit style checks.

Bug: 756722
Change-Id: I4c5493456a4a3f23611a04edb3993216beb300e6
Reviewed-on: https://chromium-review.googlesource.com/621956
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497706}
[modify] https://crrev.com/7d6b6eeeb3d16eda186b041b139472da122b9952/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
[modify] https://crrev.com/7d6b6eeeb3d16eda186b041b139472da122b9952/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/7d6b6eeeb3d16eda186b041b139472da122b9952/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 28

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by tkent@chromium.org, Aug 28

Labels: -Hotlist-Recharge-Cold -OS-Mac
Status: Available (was: Untriaged)
Summary: Get rid of C++ style checks in check_blink_style.py (was: Get rid of C++ style checks in check-webkit-style)
►

Sign in to add a comment