New issue
Advanced search Search tips

Issue 756716 link

Starred by 1 user
Status: Assigned
Owner:
tmartino@chromium.org
Cc:
rogerta@chromium.org
r...@chromium.org
tmartino@chromium.org
afakhry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Unused code for Chrome Cleanup Tool (SRT) flow in feedback component extension

Project Member Reported by michae...@chromium.org, Aug 18 2017 
There's a bunch of unused code for the Feedback component extension relating to the SRT/Chrome Cleanup Tool. Can it all be removed? (Did we intend to stop prompting for it?)

tmartino: if you're no longer working in this area, feel free to clear Owner field, but please mention if you know why all this is unused now.

* SRT feature and FEEDBACK_FLOW_SHOWSRTPROMPT feedback request in feedback_private_api.cc are unused, since nothing calls FeedbackPrivateAPI::RequestFeedback. This function will be removed in https://chromium-review.googlesource.com/c/616224.

* Lots of SRT-related JavaScript, HTML and CSS in the Feedback component extension: https://cs.chromium.org/search/?q=srt+file:%5Esrc/chrome/browser/resources/feedback/+package:%5Echromium$&type=cs

* And SRT-related strings for the extension: https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc?type=cs&q=srt+file:feedback&sq=package:chromium&l=83

* If the above can be removed, then presumably so can the SRT enum and function in feedback_private.idl: https://cs.chromium.org/chromium/src/chrome/common/extensions/api/feedback_private.idl?type=cs&q=file:feedback_private%5C.idl+srt&l=176

* And the logSrtPromptResult extension function implementation: https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/feedback_private/feedback_private_api.h?type=cs&q=%22logSrtPromptResult%22&l=144 which also has a corresponding entry in enums.xml.

See also: https://chromium-review.googlesource.com/c/616224/6/extensions/common/api/feedback_private.idl#96

Comment 1 by tmartino@chromium.org, Sep 8 2017

Owner: ----
Status: Available (was: Assigned)
Whoops, sorry for the late response.

The reason it's not being used is that we never launched. We never launched for a couple reasons:

- The PM who was pushing for this left Chrome, and there didn't seem to be a ton of interest in this space from anyone else.

- The metrics numbers we were seeing for hits in non-Stable channels were quite tiny.

- We ran into some UX bugs (that may or may not have been specific to the SRT prompt, don't remember) that blocked launch, and I didn't have bandwidth to fix them.

Comment 2 by tmartino@chromium.org, Sep 8 2017

Cc: tmartino@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by r...@chromium.org, Sep 10

Labels: -Pri-2 -Hotlist-Recharge-Cold Pri-1
Owner: tmartino@chromium.org
Status: Assigned (was: Untriaged)
Tommy, so you wrote this code, the feature was never launched, so I presume that you are planning on deleting this code?

I would request that you do this sooner than later. Chrome is very bloated as it is, we would really appreciate engineers cleaning up after themselves.
►

Sign in to add a comment