New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756715 link

Starred by 1 user
Status: WontFix
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: UpdateShortcutWorker thread-unsafe use of gfx::Image

Project Member Reported by krajshree@chromium.org, Aug 18 2017 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
===
https://chromium.googlesource.com/chromium/src.git/+/e6cf2c3cd8720693a2b07744ccf9d42cda14f423

Ref Bug: 
========
https://bugs.chromium.org/p/chromium/issues/detail?id=596348

Thank you...!!

Comment 1 by mgiuca@chromium.org, Aug 18 2017

Status: WontFix (was: Assigned)
Thanks for the report.

Note that I did write a test for this (in fact, I had the fix sitting around for a YEAR but couldn't land it because the test wasn't actually failing when it should). You can see the test in this old (unsubmitted) version of the CL:

https://chromium-review.googlesource.com/c/578915/12

It turns out the test could not actually guarantee that the code had created an icon before terminating, without a full refactor of the whole feature. Since this feature is slated for deletion, it did not make sense to refactor, as discussed in that code review.

The bulk of this test was landed in r494672 (but it does not cover regressions of the above bugfix).
►

Sign in to add a comment