Chrome Version       : 62.0.3178.0

go/macviewsbuilder regressed compile in 

https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.10%20MacViews/builds/26926

suspect


Changed by	catherinechung@google.com
Revision	5795ebbaa40775bda2ae1046add17ae69ec3ebba
Wed Aug 09 08:10:42 2017

Connecting frontend and backend code for the NewTabTracker

- Browsertest added to confirm the tracker can call the promo UI
- Added static helper in NewTabButton to show the promo for the
  last active browser
- The method DismissNewTracker was renamed to OnPromoClosed

Bug: 734132,  737830 
Change-Id: Ia6881474661b44c3994cc641b10333cd96fc1172
Reviewed-on: https://chromium-review.googlesource.com/596274
Cr-Commit-Position: refs/heads/master@{#492896}


errors

FAILED: obj/chrome/test/browser_tests/new_tab_tracker_browsertest.o /* snip */ -c ../../chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc -o obj/chrome/test/browser_tests/new_tab_tracker_browsertest.o
../../chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc:92:65: error: no member named 'kSessionTime' in namespace 'feature_engagement::events'
  EXPECT_CALL(*feature_engagement_tracker_, NotifyEvent(events::kSessionTime));
                                                        ~~~~~~~~^
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1848:61: note: expanded from macro 'EXPECT_CALL'
#define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
                                                            ^~~~
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1847:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
    ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
                   ^~~~
../../chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc:99:35: error: no member named 'kOmniboxInteraction' in namespace 'feature_engagement::events'
              NotifyEvent(events::kOmniboxInteraction));
                          ~~~~~~~~^
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1848:61: note: expanded from macro 'EXPECT_CALL'
#define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
                                                            ^~~~
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1847:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
    ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
                   ^~~~
../../chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc:110:45: error: use of undeclared identifier 'kIPHNewTabFeature'; did you mean 'kIPHDummyFeature'?
              ShouldTriggerHelpUI(IsFeature(kIPHNewTabFeature)))
                                            ^~~~~~~~~~~~~~~~~
                                            kIPHDummyFeature
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1848:61: note: expanded from macro 'EXPECT_CALL'
#define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
                                                            ^
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1847:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
    ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
                   ^
../../components/feature_engagement/public/feature_constants.h:17:28: note: 'kIPHDummyFeature' declared here
extern const base::Feature kIPHDummyFeature;
                           ^
../../chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc:125:35: error: use of undeclared identifier 'kIPHNewTabFeature'; did you mean 'kIPHDummyFeature'?
              Dismissed(IsFeature(kIPHNewTabFeature)));
                                  ^~~~~~~~~~~~~~~~~
                                  kIPHDummyFeature
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1848:61: note: expanded from macro 'EXPECT_CALL'
#define EXPECT_CALL(obj, call) GMOCK_EXPECT_CALL_IMPL_(obj, call)
                                                            ^
../../third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1847:20: note: expanded from macro 'GMOCK_EXPECT_CALL_IMPL_'
    ((obj).gmock_##call).InternalExpectedAt(__FILE__, __LINE__, #obj, #call)
                   ^
../../components/feature_engagement/public/feature_constants.h:17:28: note: 'kIPHDummyFeature' declared here
extern const base::Feature kIPHDummyFeature;
                           ^
4 errors generated.