Now that we have support for conditionals in gclient, we can remove NaCl's use of GYP_DEFINES with a proper gclient arg that will skip the download of the NaCl DEP and not download the NaCl toolchains.
Looks like Skia bots which build chromium started failing after the change in https://chromium-review.googlesource.com/681854. The error is:
ERROR at //build/config/features.gni:28:17: Left side of && operator is not a boolean.
enable_nacl = checkout_nacl &&
^------------
Type is "string" instead.
See //BUILD.gn:12:1: whence it was imported.
import("//build/config/features.gni")
^-----------------------------------
Error (ret code: 1) calling "['/b/work/src/buildtools/mac/gn', 'gen', 'out/CommandBufferForSkia', '--args=is_component_build=false is_debug=false ']" in /b/work/src
step returned non-zero exit code: 1
More details in https://bugs.chromium.org/p/skia/issues/detail?id=7072
Looks like https://chromium-review.googlesource.com/681854 was reverted but does not look like it was reverted for the same error as Skia saw.
Comment 1 by dpranke@chromium.org
, Aug 18 2017