Issue metadata
Sign in to add a comment
|
Layout test http/tests/inspector/cache-storage/cache-live-update-cache-content.html failing, blocking CQ |
||||||||||||||||||||||
Issue descriptionThis layout test is failing reliably on linux_chromium_rel_ng: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/527566 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/527553 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/527548 and others. Not sure what changed, but this needs to be fixed right away.
,
Aug 18 2017
,
Aug 18 2017
Never mind, found the commit: aa26f619fd32e61e564acf00b5513efe9cb73d69 from Issue 729795 . Reverting.
,
Aug 18 2017
Revert submitted in https://chromium-review.googlesource.com/620070 . Here's a link to one of the failures: https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/527566/layout-test-results/results.html and the diff: --- /b/s/w/iognQBy0/layout-test-results/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt +++ /b/s/w/iognQBy0/layout-test-results/http/tests/inspector/cache-storage/cache-live-update-cache-content-actual.txt @@ -10,7 +10,7 @@ Cache marked dirty = true Dumping CacheStorage tree: cache: testCache1 - http://127.0.0.1:8000 - 0, http://fake.request.com/1, OK + 1 Cache marked dirty = false Deleted entry Cache marked dirty = true kristipark@, please diagnose this failure (presumably it's intermittent) and fix before re-landing; thanks.
,
Aug 18 2017
The test dump format was changed, fixing expected text for test in this cl: https://chromium-review.googlesource.com/c/620308
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97 commit ae7d71ccd1e4925796b8bf2829067fb2b95a2f97 Author: kristipark <kristipark@chromium.org> Date: Fri Aug 18 21:00:29 2017 Reland "[DevTools] [CacheStorage] Live update cache storage content" This is a reland of aa26f619fd32e61e564acf00b5513efe9cb73d69 Original change's description: > [DevTools] [CacheStorage] Live update cache storage content > > Marks the cache content view as dirty if entries are > out-of-date. > > Bug: 729795 > Change-Id: I3600f8b196f5ca350768e6e75e82f18ecb88afb6 > Reviewed-on: https://chromium-review.googlesource.com/616222 > Commit-Queue: Kristi Park <kristipark@chromium.org> > Reviewed-by: Blaise Bruer <allada@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Michael Nordman <michaeln@chromium.org> > Cr-Commit-Position: refs/heads/master@{#495301} Bug: 756676 , 729795 Change-Id: I922e818ac106cb5a482151032452795f9ddaa910 Reviewed-on: https://chromium-review.googlesource.com/620308 Reviewed-by: Michael Nordman <michaeln@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#495678} [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage.cc [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage.h [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage_cache.cc [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage_manager_unittest.cc [add] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt [add] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content.html [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js [modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkerCacheViews.css
,
Aug 18 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Aug 18 2017