New issue
Advanced search Search tips

Issue 756676 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression

Blocking:
issue 729795



Sign in to add a comment

Layout test http/tests/inspector/cache-storage/cache-live-update-cache-content.html failing, blocking CQ

Project Member Reported by kbr@chromium.org, Aug 18 2017

Issue description

Comment 1 by kbr@chromium.org, Aug 18 2017

Cc: caseq@chromium.org dgozman@chromium.org pfeldman@chromium.org

Comment 2 by kbr@chromium.org, Aug 18 2017

Blocking: 729795

Comment 3 by kbr@chromium.org, Aug 18 2017

Owner: kbr@chromium.org
Status: Assigned (was: Untriaged)
Never mind, found the commit: aa26f619fd32e61e564acf00b5513efe9cb73d69 from  Issue 729795 . Reverting.

Comment 4 by kbr@chromium.org, Aug 18 2017

Labels: -Pri-1 Pri-2
Owner: kristip...@chromium.org
Revert submitted in https://chromium-review.googlesource.com/620070 .

Here's a link to one of the failures:

https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/527566/layout-test-results/results.html

and the diff:

--- /b/s/w/iognQBy0/layout-test-results/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt
+++ /b/s/w/iognQBy0/layout-test-results/http/tests/inspector/cache-storage/cache-live-update-cache-content-actual.txt
@@ -10,7 +10,7 @@
 Cache marked dirty = true
 Dumping CacheStorage tree:
     cache: testCache1 - http://127.0.0.1:8000
-        0, http://fake.request.com/1, OK
+        1
 Cache marked dirty = false
 Deleted entry
 Cache marked dirty = true

kristipark@, please diagnose this failure (presumably it's intermittent) and fix before re-landing; thanks.

The test dump format was changed, fixing expected text for test in this cl:

https://chromium-review.googlesource.com/c/620308
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97

commit ae7d71ccd1e4925796b8bf2829067fb2b95a2f97
Author: kristipark <kristipark@chromium.org>
Date: Fri Aug 18 21:00:29 2017

Reland "[DevTools] [CacheStorage] Live update cache storage content"

This is a reland of aa26f619fd32e61e564acf00b5513efe9cb73d69
Original change's description:
> [DevTools] [CacheStorage] Live update cache storage content
> 
> Marks the cache content view as dirty if entries are
> out-of-date.
> 
> Bug:  729795 
> Change-Id: I3600f8b196f5ca350768e6e75e82f18ecb88afb6
> Reviewed-on: https://chromium-review.googlesource.com/616222
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Blaise Bruer <allada@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Michael Nordman <michaeln@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495301}

Bug:  756676 ,  729795 
Change-Id: I922e818ac106cb5a482151032452795f9ddaa910
Reviewed-on: https://chromium-review.googlesource.com/620308
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495678}
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/content/browser/cache_storage/cache_storage_manager_unittest.cc
[add] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content-expected.txt
[add] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-live-update-cache-content.html
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
[modify] https://crrev.com/ae7d71ccd1e4925796b8bf2829067fb2b95a2f97/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkerCacheViews.css

Status: Fixed (was: Assigned)

Sign in to add a comment