New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756664 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

generate_perf_data complains about NON_TELEMETRY_BENCHMARKS when disabling benchmark

Project Member Reported by eakuefner@chromium.org, Aug 17 2017

Issue description

I'm trying to disable v8.(runtimestats.)browing_desktop because it's timing out (see https://bugs.chromium.org/p/chromium/issues/detail?id=756646), so I updated the expectations to do so: https://chromium-review.googlesource.com/c/619763

Then perf_data_generator threw an exception:

** Presubmit ERRORS **
Validating Perf JSON configs failed.

***************

Traceback (most recent call last):
  <module> at /Users/eakuefner/code/chrome/src/tools/perf/generate_perf_data:12
    sys.exit(perf_data_generator.main(sys.argv[1:]))
  main at /Users/eakuefner/code/chrome/src/tools/perf/core/perf_data_generator.py:1148
    if tests_are_up_to_date([fyi_waterfall, waterfall]):
  tests_are_up_to_date at /Users/eakuefner/code/chrome/src/tools/perf/core/perf_data_generator.py:960
    get_all_waterfall_benchmarks_metadata())
  verify_all_tests_in_benchmark_csv at /Users/eakuefner/code/chrome/src/tools/perf/core/perf_data_generator.py:1064
    'NON_TELEMETRY_BENCHMARKS as below:\n' + '\n'.join(error_messages))
AssertionError: Please update NON_TELEMETRY_BENCHMARKS as below:
Remove v8.browsing_desktop from NON_TELEMETRY_BENCHMARKS
Remove v8.runtimestats.browsing_desktop from NON_TELEMETRY_BENCHMARKS

Locals:
  benchmark_metadata : {'smoothness.key_desktop_move_cases': BenchmarkMetadata(emails='ssid@chromium.org', component=None, not_scheduled=False), 'system_health.common_mobile': BenchmarkMetadata(emails='charliea@chromium.org, nednguyen@chromium.org', component=None, not_scheduled=False), 'smoothness.tough_canvas_cases': BenchmarkMetadata(emails='junov@chromium.org', component=None, not_scheduled=False), 'gpu_perftests': BenchmarkMetadata(emails='reveman@chromium.org', component=None, not_scheduled=False), 'system_health.webview ... ', component=None, not_scheduled=False), 'startup.warm.blank_page': BenchmarkMetadata(emails=None, component=None, not_scheduled=False), 'blob_storage.blob_storage': BenchmarkMetadata(emails=None, component=None, not_scheduled=False), 'smoothness.pathological_mobile_sites': BenchmarkMetadata(emails='picksi@chromium.org', component=None, not_scheduled=False), 'scheduler.tough_scheduling_cases': BenchmarkMetadata(emails='skyostil@chromium.org, brianderson@chromium.org', component=None, not_scheduled=False)} (truncated)
  benchmark_names    : Set(['gpu_perftests', 'blink_perf.owp_storage', 'load_library_perf_tests', 'smoothness.image_decoding_cases', 'memory.long_running_idle_gmail_tbmv2', 'dummy_benchmark.noisy_benchmark_1', 'media.media_cns_cases', 'smoothness.tough_webgl_ad_cases', 'webrtc', 'blink_perf.shadow_dom', 'start_with_ext.warm.blank_page', 'loading.mobile', 'smoothness.tough_image_decode_cases', 'blink_perf.dom', 'thread_times.tough_compositor_cases', 'storage.indexeddb_endure_tracing', 'smoothness.tough_texture_upload_cases', 'v ... mes.simple_mobile_sites', 'angle_perftests', 'blob_storage.blob_storage', 'blink_perf.css', 'storage.indexeddb_endure', 'thread_times.key_hit_test_cases', 'smoothness.sync_scroll.key_mobile_sites_smooth', 'smoothness.tough_path_rendering_cases', 'startup.large_profile.cold.blank_page', 'kraken', 'media.tough_video_cases', 'smoothness.key_silk_cases', 'smoothness.gpu_rasterization_and_decoding.image_decoding_cases', 'smoothness.gpu_rasterization.tough_pinch_zoom_cases', 'scheduler.tough_scheduling_cases']) (truncated)
  data               : BenchmarkMetadata(emails='skyostil@chromium.org, brianderson@chromium.org', component=None, not_scheduled=False)
  error_messages     : ['Remove v8.browsing_desktop from NON_TELEMETRY_BENCHMARKS', 'Remove v8.runtimestats.browsing_desktop from NON_TELEMETRY_BENCHMARKS']
  name               : 'scheduler.tough_scheduling_cases'
  s                  : {'override_compile_targets': ['telemetry_perf_tests'], 'args': ['webrtc', '-v', '--upload-results', '--output-format=chartjson', '--browser=reference', '--max-failures=5', '--output-trace-tag=_ref'], 'swarming': {'dimension_sets': [{'gpu': '8086:22b1', 'os': 'Windows-10-10586', 'id': u'build149-b1', 'pool': 'Chrome-perf-fyi'}], 'upload_test_results': False, 'hard_timeout': 10800, 'ignore_task_failure': True, 'can_use_on_swarming_builders': True, 'expiration': 72000, 'io_timeout': 600}, 'name': 'webrtc.reference', 'isolate_name': 'telemetry_perf_tests'}
  scripts            : []
  t                  : 'Android Compile'
  test               : 'v8.runtimestats.browsing_desktop'
  test_names         : Set(['gpu_perftests', 'blink_perf.owp_storage', 'load_library_perf_tests', 'smoothness.image_decoding_cases', 'memory.long_running_idle_gmail_tbmv2', 'smoothness.gpu_rasterization.tough_pinch_zoom_cases', 'dummy_benchmark.noisy_benchmark_1', 'thread_times.simple_mobile_sites', 'media.media_cns_cases', 'smoothness.tough_webgl_ad_cases', 'webrtc', 'blink_perf.shadow_dom', 'start_with_ext.warm.blank_page', 'loading.mobile', 'smoothness.tough_image_decode_cases', 'blink_perf.dom', 'thread_times.tough_composi ... s.key_mobile_sites_smooth', 'memory.long_running_idle_gmail_background_tbmv2', 'angle_perftests', 'blob_storage.blob_storage', 'storage.indexeddb_endure', 'thread_times.key_hit_test_cases', 'smoothness.gpu_rasterization.tough_filters_cases', 'smoothness.tough_path_rendering_cases', 'startup.large_profile.cold.blank_page', 'kraken', 'media.tough_video_cases', 'smoothness.key_silk_cases', 'smoothness.gpu_rasterization_and_decoding.image_decoding_cases', 'blink_perf.css', 'scheduler.tough_scheduling_cases']) (truncated)
  tests              : {'Mac Mini 8GB 10.12 Perf': {'isolated_scripts': [{'override_compile_targets': ['telemetry_perf_tests'], 'args': ['battor.steady_state', '-v', '--upload-results', '--output-format=chartjson', '--browser=release'], 'swarming': {'dimension_sets': [{'gpu': '8086:0a26', 'os': 'Mac-10.12', 'id': u'build28-b1', 'pool': 'Chrome-perf'}], 'upload_test_results': False, 'hard_timeout': 10800, 'ignore_task_failure': False, 'can_use_on_swarming_builders': True, 'expiration': 72000, 'io_timeout': 600}, 'name': 'battor ... , '--browser=reference', '--max-failures=5', '--output-trace-tag=_ref'], 'swarming': {'dimension_sets': [{'gpu': '8086:22b1', 'os': 'Windows-10-10586', 'id': u'build149-b1', 'pool': 'Chrome-perf-fyi'}], 'upload_test_results': False, 'hard_timeout': 10800, 'ignore_task_failure': True, 'can_use_on_swarming_builders': True, 'expiration': 72000, 'io_timeout': 600}, 'name': 'webrtc.reference', 'isolate_name': 'telemetry_perf_tests'}]}, 'Android Compile': {'additional_compile_targets': ['microdump_stackwalk']}} (truncated)
***************

Presubmit checks took 16.8s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.
 
Cc: rnep...@chromium.org
Cc: martiniss@chromium.org
Hmm. I think I've seen this before one time, but dont recall exactly the actual root cause. 

Which disabling method are you using, StoryExpectations.PermanentlyDisableBenchmark() or decorators.Disabled()
I attempted to disable via decorators.Disabled('all') and PermanentlyDisableBenchmark() and neither caused that failure in perf_data_generator locally :/

I'll land a CL to get this disabled.
Actually scratch that. I think I didn't save the file before running generate_perf_data I am seeing it now.
Cc: charliea@chromium.org
Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
Looking at https://chromium-swarm.appspot.com/task?id=380b335b14495610&refresh=10&show_raw=1, this is another case of trace size explosion  leading to metric analysis code being stuck.

Trace sizes in bytes: {'traceEvents': 760834418, 'telemetry': 405967, 'tabIds': 40} 

760834418 bytes = 760.834418 Megabytes

Comment 6 by u...@chromium.org, Aug 19 2017

Status: WontFix (was: Assigned)
Since the reference build is OK, I think this regression in Chrome rather than regression in benchmark itself.
https://chromium-swarm.appspot.com/task?id=380b335f3d300410&refresh=10&show_raw=1

The Chrome issue seems to be fixed because v8.browsing cycled green on the bots.

Sign in to add a comment