New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756662 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 2018
Cc:
█ sczs@chromium.org
█ lpromero@chromium.org
s...@chromium.org
mastiz@chromium.org
ios-bugs@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

iOS History page sync retry seems fragile

Project Member Reported by s...@chromium.org, Aug 17 2017 
I'm concerned about the retry logic inside of history_collection_view_controller.mm. It seems that if web history starts timing out, such as a bad network or the remote servers are having problems, we break local history, and the history page stops working.

Also, it calls with end_time of now, which may often be wrong.

Comment 1 by s...@chromium.org, Aug 17 2017 

Bizarrely, if you do something like disabling WiFi, HistoryServiceFacade::WebHistoryQueryComplete() still gets called, instead of HistoryServiceFacade::WebHistoryTimeout(). It is unclear to me if you're on a bad cell connection, how broken things end up.

Comment 2 by s...@chromium.org, Aug 17 2017 

I wasn't very clear in #1, this was on the simulator, I'd disable WiFi on laptop, so there was no connection to WebHistory. And I was immediately receiving an empty response.

Comment 3 by s...@chromium.org, Aug 18 2017 

See issue 589277 that the retry logic was solving, make sure that doesn't regress as we move forward as well.

Comment 4 by olivierrobin@chromium.org, Aug 18 2017

Cc: sczs@chromium.org lpromero@chromium.org
Owner: ramyasharma@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by ramyasharma@chromium.org, Sep 19 2017

Owner: martiw@chromium.org

Comment 6 by zea@chromium.org, Jan 17 2018

Labels: SyncHandoff2018
Owner: s...@chromium.org
Reassigning to Sky to re-triage.

Comment 7 by s...@chromium.org, Jan 17 2018

Cc: s...@chromium.org
Owner: ----
Status: Archived (was: Assigned)
Things could always be better. We don't currently have plans to fix this, lets close for now.
►

Sign in to add a comment