New issue
Advanced search Search tips

Issue 756654 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Add security UI for network service

Project Member Reported by jam@chromium.org, Aug 17 2017

Issue description

Emily has a list of areas to fix in https://docs.google.com/document/d/1jhbF3PoqfxTwXVgTHfBWjIKmg_bzWk-6idMCxTXJG0c/edit#

Some areas:
-Certificate interstitials
-Mixed content
-HTTP auth
-DevTools security panel
-TLS client auth
-Cookie viewer
 

Comment 1 by est...@chromium.org, Aug 21 2017

Cc: -est...@chromium.org
Labels: Team-Security-UX
Owner: est...@chromium.org
Status: Assigned (was: Available)

Comment 2 by est...@chromium.org, Aug 21 2017

Labels: Proj-Servicification

Comment 3 by est...@chromium.org, Aug 21 2017

Blockedon: 757633

Comment 4 by jam@chromium.org, Aug 22 2017

Blocking: 598073
Components: Internals>PageSecurityState UI>Browser>Interstitials UI>Browser>CookiesTree

Comment 6 by dougt@chromium.org, Oct 20 2017

Components: Internals>Network>Service

Comment 7 by jam@chromium.org, Oct 30 2017

btw per discussion with Emily, I can take a look at the certificate interstitials for this.

Comment 8 by jam@chromium.org, Nov 2 2017

Cc: juncai@chromium.org
 Issue 779178  has been merged into this issue.

Comment 9 by jam@chromium.org, Nov 3 2017

btw I can also take a look at http auth and TLS client auth
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/576c61304079f3ea01395699c36287ebc98dd685

commit 576c61304079f3ea01395699c36287ebc98dd685
Author: John Abd-El-Malek <jam@chromium.org>
Date: Sat Nov 04 00:33:58 2017

Plumb certificate errors from the network service to the browser.

Bug:756654

Change-Id: I8712b2a9d532a7d5524cf61471e6ca0f1a7cfe03
Reviewed-on: https://chromium-review.googlesource.com/751685
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513989}
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/BUILD.gn
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[add] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/network_service_client.cc
[add] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/network_service_client.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/ssl/ssl_error_handler.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/ssl/ssl_manager.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/browser/ssl/ssl_manager.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/common/throttling_url_loader.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/common/throttling_url_loader.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/network_service_impl.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/network_service_impl.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/network_service_url_loader_factory.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/network_service_url_loader_factory.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/url_loader.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/url_loader.h
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/network/url_loader_unittest.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/public/browser/network_service_instance.cc
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/public/common/BUILD.gn
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/public/common/network_service.mojom
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/content/public/common/url_loader_factory.mojom
[modify] https://crrev.com/576c61304079f3ea01395699c36287ebc98dd685/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Labels: Hotlist-EnamelAndFriendsFixIt

Comment 13 by jam@chromium.org, Nov 10 2017

Blockedon: 783990

Comment 14 by jam@chromium.org, Nov 10 2017

Blockedon: 783996
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 15 2017

Comment 16 by jam@chromium.org, Nov 21 2017

Blockedon: 787535
Labels: -Hotlist-EnamelAndFriendsFixIt

Comment 18 by jam@chromium.org, Mar 6 2018

Blockedon: 819241

Comment 19 by dxie@chromium.org, May 17 2018

Labels: Proj-Servicification-Canary OS-All

Comment 20 by dxie@chromium.org, May 18 2018

Labels: -OS-All OS-Windows OS-Linux OS-Mac OS-Chrome OS-Android

Comment 21 by jam@chromium.org, May 22 2018

Status: Fixed (was: Assigned)
per discussion with Emily

Sign in to add a comment