See URLBlacklistManager that is used to block origins from loading. We'll need this to work with network service.
Design: https://docs.google.com/document/d/1sTVMxHKWgKEyZNoIGm6CvFMMNYKLi2aLbgh2kB5xo-k/edit#
Apologies, applied the wrong component in bulk.
Work is here: https://chromium-review.googlesource.com/c/chromium/src/+/745326
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/574253081eebc50b94efb2e1d46fc83d2a75c8f1 commit 574253081eebc50b94efb2e1d46fc83d2a75c8f1 Author: Doug Turner <dougt@chromium.org> Date: Thu Dec 07 00:20:27 2017 Add Chrome Policy Blacklist support for Network Service In this CL, we create a new implementation of NavigationThrottle, called PolicyBlacklistNavigationThrottle in which we call into a policy::URLBlacklistManager implementation during calls to WillStartRequest(). If the requested URL is in the blocklist, we’d return CANCEL otherwise PROCEED. This CL also introduces a KeyedService for accessing the policy::URLBlacklistManager. Bug: 756642 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I2d9ca0982e78b03be191b67e61eea14764150e68 Reviewed-on: https://chromium-review.googlesource.com/745326 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522268} [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/BUILD.gn [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/browser/DEPS [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/browser/aw_browser_context.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/browser/aw_browser_context.h [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/browser/net/aw_network_delegate.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/android_webview/browser/net/aw_network_delegate.h [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/BUILD.gn [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/DEPS [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/net/chrome_network_delegate.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/net/chrome_network_delegate.h [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/chrome/browser/profiles/profile_io_data.h [add] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/content/BUILD.gn [add] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/content/DEPS [add] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/content/policy_blacklist_navigation_throttle.cc [add] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/content/policy_blacklist_navigation_throttle.h [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/core/browser/url_blacklist_manager.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/core/browser/url_blacklist_manager.h [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/components/policy/core/browser/url_blacklist_manager_unittest.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/574253081eebc50b94efb2e1d46fc83d2a75c8f1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/034134229bfcfe39482304614c615b826979d822 commit 034134229bfcfe39482304614c615b826979d822 Author: Juan Antonio Navarro Pérez <perezju@chromium.org> Date: Thu Dec 07 15:05:45 2017 Revert "Add Chrome Policy Blacklist support for Network Service" This reverts commit 574253081eebc50b94efb2e1d46fc83d2a75c8f1. Reason for revert: Speculative revert to fix issue 792868 . Original change's description: > Add Chrome Policy Blacklist support for Network Service > > In this CL, we create a new implementation of NavigationThrottle, called > PolicyBlacklistNavigationThrottle in which we call into a > policy::URLBlacklistManager implementation during calls to WillStartRequest(). > If the requested URL is in the blocklist, we’d return CANCEL otherwise PROCEED. > > This CL also introduces a KeyedService for accessing the > policy::URLBlacklistManager. > > Bug: 756642 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I2d9ca0982e78b03be191b67e61eea14764150e68 > Reviewed-on: https://chromium-review.googlesource.com/745326 > Commit-Queue: Doug Turner <dougt@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522268} TBR=pastarmovj@chromium.org,nasko@chromium.org,jam@chromium.org,boliu@chromium.org,rockot@chromium.org,clamy@chromium.org,dougt@chromium.org,cjennyc28@gmail.com Change-Id: I09dad40ad0dffa4cf7accfc0cd2dbb722b1c651b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756642 , 792868 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/814394 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#522427} [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/BUILD.gn [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/browser/DEPS [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/browser/aw_browser_context.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/browser/aw_browser_context.h [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/browser/net/aw_network_delegate.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/android_webview/browser/net/aw_network_delegate.h [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/BUILD.gn [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/DEPS [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/net/chrome_network_delegate.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/net/chrome_network_delegate.h [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/chrome/browser/profiles/profile_io_data.h [delete] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/components/policy/content/BUILD.gn [delete] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/components/policy/content/DEPS [delete] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/components/policy/content/policy_blacklist_navigation_throttle.cc [delete] https://crrev.com/1419427e917eb6110885aafbe64966585287c1d4/components/policy/content/policy_blacklist_navigation_throttle.h [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/components/policy/core/browser/url_blacklist_manager.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/components/policy/core/browser/url_blacklist_manager.h [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/components/policy/core/browser/url_blacklist_manager_unittest.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/034134229bfcfe39482304614c615b826979d822/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dcaf5962cf73f2856f5824ae96f9818e8d979e5 commit 9dcaf5962cf73f2856f5824ae96f9818e8d979e5 Author: Doug Turner <dougt@chromium.org> Date: Thu Dec 21 04:38:53 2017 Add Chrome Policy Blacklist support for Network Service In this CL, we create a new implementation of NavigationThrottle, called PolicyBlacklistNavigationThrottle in which we call into a policy::URLBlacklistManager implementation during calls to WillStartRequest(). If the requested URL is in the blocklist, we’d return CANCEL otherwise PROCEED. This CL also introduces a KeyedService for accessing the policy::URLBlacklistManager. This was reverted in 814394 due to a non-plzNavigate path not working. Will reland after plznavigate is the only path. TBR=pastarmovj@chromium.org, boliu@chromium.org, rockot@chromium.org Bug: 756642 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If5f5259397ee9305c75190f1bbc35a108c80bbc5 Reviewed-on: https://chromium-review.googlesource.com/814695 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Doug Turner <dougt@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#525606} [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/BUILD.gn [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/browser/DEPS [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/browser/aw_browser_context.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/browser/aw_browser_context.h [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/browser/net/aw_network_delegate.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/android_webview/browser/net/aw_network_delegate.h [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/BUILD.gn [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/DEPS [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/net/chrome_network_delegate.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/net/chrome_network_delegate.h [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/chrome/browser/profiles/profile_io_data.h [add] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/content/BUILD.gn [add] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/content/DEPS [add] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/content/policy_blacklist_navigation_throttle.cc [add] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/content/policy_blacklist_navigation_throttle.h [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/core/browser/url_blacklist_manager.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/core/browser/url_blacklist_manager.h [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/components/policy/core/browser/url_blacklist_manager_unittest.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/9dcaf5962cf73f2856f5824ae96f9818e8d979e5/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Comment 1 by dougt@chromium.org
, Oct 19 2017Status: Started (was: Available)