New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756627 link

Starred by 1 user
Status: Assigned
Owner:
bcwh...@chromium.org
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

We should add absolute size metrics to persistent allocator - in addition to UsedPct

Project Member Reported by asvitk...@chromium.org, Aug 17 2017 
We should add absolute size metrics to persistent allocator - in addition to UsedPct.

UsedPct is useful to monitor when we may need to increase these. However, it's pretty poor for reasoning about how much things change and how many bytes we start using or saving - because it requires looking up the total from the code and doing math.

We should record the size used itself too.

Not super urgent, so marking P3 - so no need to look at it soon, but would be good eventually.

Comment 1 by bcwh...@chromium.org, Nov 3 2017 

What are the chances that, four months after adding this, I'll get assigned a bug saying it should be removed because nobody is looking at it?

I think a little math is worth avoiding the duplication and the additional log storage requirements.

Also, because these are updated once per metric cycle, only the peak values have much meaning.  That's sufficient for determining if the allocation size needs to be increased but not much else.

Comment 2 by asvitk...@chromium.org, Nov 3 2017 

Well, hopefully we should have Chirp monitoring for these metrics - in which case we won't have histogram eraser asking to delete them.

In terms of duplication and additional storage requirements, that's a fair point. Ideally we could use formulas on the dashboards for this, but I think their support for numeric histograms is not great yet - i.e. they can't get percentile values.
►

Sign in to add a comment