Convert tough_scheduling_cases to WPRGo. |
||||
Issue descriptionInitial attempt shows some issue with the current ToT .wpr file. Attempting to fetch the file: wkorman@lemur:~/chrome$ ./tools/perf/fetch_benchmark_deps.py scheduler.tough_scheduling_cases tools/perf/page_sets/data/tough_scheduling_cases_001.wpr Seems to state success, but the file is in fact not present on local filesystem. And so attempting to convert shows: wkorman@lemur:~/chrome$ ./tools/perf/convert_legacy_wpr_archive ./tools/perf/page_sets/data/tough_scheduling_cases.json Usage: convert_legacy_wpr_archive [options] convert_legacy_wpr_archive: error: file "/usr/local/google/home/wkorman/workspace/chromium/src/tools/perf/page_sets/data/tough_scheduling_cases_001.wpr" does not exist Attempting to run the benchmark locally does seem to run successfully though via: wkorman@lemur:~/chrome$ ./tools/perf/run_benchmark --browser=system scheduler.tough_scheduling_cases
,
Aug 17 2017
Oh, strange. Maybe there is some bug with the fetch_benchmark_deps.py script. Though After you run the benchmark & have tools/perf/page_sets/data/tough_scheduling_cases_001.wpr file on to your local machine, I think running "./tools/perf/convert_legacy_wpr_archive ./tools/perf/page_sets/data/tough_scheduling_cases.json" again should work.
,
Aug 21 2017
The benchmark is currently running on my workstation and I see this log message re: archive missing:
[ RUN ] simple_text_page.html
(WARNING) 2017-08-21 14:28:24,764 shared_page_state.WillRunStory:238 WPR archive missing: /usr/local/google/home/wkorman/workspace/chromium/src/tools/perf/page_sets/data/tough_scheduling_cases_001.wpr
(WARNING) 2017-08-21 14:28:39,854 model._CreateImporters:274 No importer found for TraceDataPart("telemetry")
[ OK ] simple_text_page.html (15669 ms)
[ RUN ] touch_handler_scrolling.html
Maybe this test doesn't actually use a wpr file. Helen/Ned do you have any insight?
,
Aug 21 2017
Unassigning myself as I am no longer actively working on this. I've updated 756002 with more.
,
Aug 21 2017
> Maybe this test doesn't actually use a wpr file. I am not sure. Ned, do you know?
,
Aug 21 2017
I will look into this.
,
Aug 21 2017
Ok, so it turns out that this benchmark doesn't need WPR archives as it only use local files stored in https://cs.chromium.org/chromium/src/tools/perf/page_sets/tough_scheduling_cases/ I sent out a CL to remove the references to WPR archives to make this less confusing.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8de0a1b8ab276d48d82883b185eef62aa5d17eea commit 8de0a1b8ab276d48d82883b185eef62aa5d17eea Author: Ned Nguyen <nednguyen@google.com> Date: Tue Aug 22 01:05:53 2017 Remove tough_scheduling_cases WPR archives & their references This CL cleans up tough_scheduling_cases WPR archives as they are not needed by scheduler.tough_scheduling_cases benchmarks. Bug: 756621 Change-Id: I7e73804033aa2d69730e9302fe24ebe19be6be87 Reviewed-on: https://chromium-review.googlesource.com/625079 Reviewed-by: Walter Korman <wkorman@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#496152} [delete] https://crrev.com/9bd5aef927219e3e72b7a076f14bb7efb01dca83/tools/perf/page_sets/data/tough_scheduling_cases.json [delete] https://crrev.com/9bd5aef927219e3e72b7a076f14bb7efb01dca83/tools/perf/page_sets/data/tough_scheduling_cases_001.wpr.sha1 [modify] https://crrev.com/8de0a1b8ab276d48d82883b185eef62aa5d17eea/tools/perf/page_sets/tough_scheduling_cases.py
,
Aug 22 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wkorman@chromium.org
, Aug 17 2017