New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756614 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in cc::ResourceProvider::ScopedWriteLockGL::AllocateGpuMemoryBuffer

Project Member Reported by ClusterFuzz, Aug 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6667910750928896

Fuzzer: meacer_extension_apis
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  cc::ResourceProvider::ScopedWriteLockGL::AllocateGpuMemoryBuffer
  cc::ResourceProvider::ScopedWriteLockGL::ConsumeTexture
  cc::GpuRasterBufferProvider::PlaybackOnWorkerThread
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=494077:494482

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6667910750928896

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Platform>Extensions Internals>GPU
[mac bug triage]

Tentatively tagging Platform>Extensions, Internals>GPU - please correct if wrong.
Cc: msrchandra@chromium.org
Components: Internals>Compositing
Labels: Test-Predator-Wrong-CLs M-62
Owner: sunn...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "resource_provider.cc" assigning to the concern owner.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/0cb875e6dff21d6417e4cf84d0fb3f9a3db8af3f

@sunnyps -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e21c6c243337dcc2649729c81e0646807f6e69

commit 93e21c6c243337dcc2649729c81e0646807f6e69
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Fri Aug 18 23:21:59 2017

cc: Fix for crash when GMB allocation fails.

crrev.com/c/605087 moved GMB allocation code to resource lock but
dropped the workaround to deal with GMB allocation failure in release
builds.

R=piman
BUG=756802, 756614 ,756431,554541

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie147c25642c80654ca029b62afc9f753d1288a43
Reviewed-on: https://chromium-review.googlesource.com/621869
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495739}
[modify] https://crrev.com/93e21c6c243337dcc2649729c81e0646807f6e69/cc/resources/resource_provider.cc

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Aug 19 2017

ClusterFuzz has detected this issue as fixed in range 495712:495750.

Detailed report: https://clusterfuzz.com/testcase?key=6667910750928896

Fuzzer: meacer_extension_apis
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  cc::ResourceProvider::ScopedWriteLockGL::AllocateGpuMemoryBuffer
  cc::ResourceProvider::ScopedWriteLockGL::ConsumeTexture
  cc::GpuRasterBufferProvider::PlaybackOnWorkerThread
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=494077:494482
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=495712:495750

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6667910750928896

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Aug 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6667910750928896 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment