New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756613 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Task

Blocking:
issue 756002



Sign in to add a comment

Convert tough_pinch_zoom_cases to WprGo.

Project Member Reported by wkorman@chromium.org, Aug 17 2017

Issue description

Initial effort shows repeated failures. Looks like may need to test non-desktop with Android, but even desktop fails with an apparent dev tools timing error.

smoothness.tough_pinch_zoom_cases smoothness.desktop_tough_pinch_zoom_cases smoothness.gpu_rasterization.tough_pinch_zoom_cases

desktop sample error:

Exception raised when cleaning story run: 

Traceback (most recent call last):
  _RunStoryAndProcessErrorIfNeeded at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:132
    test.DidRunPage(state.platform)
  traced_function at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
    return func(*args, **kwargs)
  DidRunPage at /usr/local/google/home/wkorman/workspace/chromium/src/tools/perf/measurements/smoothness.py:67
    self._tbm.DidRunStory(platform, self._results)
  DidRunStory at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:310
    trace_result = platform.tracing_controller.StopTracing()
  StopTracing at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:47
    return self._tracing_controller_backend.StopTracing()
  StopTracing at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:109
    self._IssueClockSyncMarker()
  _IssueClockSyncMarker at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:213
    self._RecordIssuerClockSyncMarker)
  RecordClockSyncMarker at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:178
    raise ChromeClockSyncError('Cannot issue clock sync. No devtools clients')
ChromeClockSyncError: Cannot issue clock sync. No devtools clients

Locals:
  devtools_clients                             : []
  record_controller_clock_sync_marker_callback : <bound method TracingControllerBackend._RecordIssuerClockSyncMarker of <telemetry.internal.platform.tracing_controller_backend.TracingControllerBackend object at 0x7fd7abe457d0>>
  sync_id                                      : 'fa338818-560e-4304-9306-b180e7355abd'

[  FAILED  ] http://booking.com (9126 ms)

 
Blocking: 756002
Cc: wkorman@chromium.org
Components: Blink>Paint
Owner: ----
Status: Available (was: Started)
Unassigning myself as I am no longer actively working on this. I've updated 756002 with more.

Comment 3 by trchen@chromium.org, Aug 24 2017

Chrome crashed for hitting a CHECK here:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/synthetic_gesture_target_base.cc?rcl=b481b28ef49243e45c00b078caa049fcba826f3d&l=62

Basically the story script emitted pinch gestures using ActionRunner.PinchPage, which by default generate touch event at the center point of <body> element, which goes out of the view bound after zooming in, triggering the CHECK.

Comment 4 by trchen@chromium.org, Aug 24 2017

And the Wikipedia story still fails. It seems to me the story wasn't recorded properly since the beginning. With .wpr it loaded 404 error page and succeeded, but it just timed out with .wprgo . (shrug)

Comment 5 by trchen@chromium.org, Aug 24 2017

Owner: trchen@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/chromium/src/+/630998
According to the spreadsheet (https://docs.google.com/spreadsheets/d/1SVNzaT-bMIZ3nr6GZVXfLeoZIG59d635owASw2ayNpI/edit#gid=0) there are only two JSON pages left uncoverted:

tough_pinch_zoom_cases.json
key_desktop_move_cases.json

Tien: can you do those two?

Comment 7 by trchen@chromium.org, Sep 13 2017

Sure! Was waiting for the perf bots to quiet down before proceeding. Continuing now.
A friendly ping. trchen@: Any update on "key_desktop_move_cases.json" ?
This is the only wpr pageset that is remaining.
Status: Fixed (was: Started)
Just uploaded for review. I'll close this one and track it with  issue 756002 .

Sign in to add a comment