Convert tough_pinch_zoom_cases to WprGo. |
||||
Issue description
Initial effort shows repeated failures. Looks like may need to test non-desktop with Android, but even desktop fails with an apparent dev tools timing error.
smoothness.tough_pinch_zoom_cases smoothness.desktop_tough_pinch_zoom_cases smoothness.gpu_rasterization.tough_pinch_zoom_cases
desktop sample error:
Exception raised when cleaning story run:
Traceback (most recent call last):
_RunStoryAndProcessErrorIfNeeded at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:132
test.DidRunPage(state.platform)
traced_function at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
return func(*args, **kwargs)
DidRunPage at /usr/local/google/home/wkorman/workspace/chromium/src/tools/perf/measurements/smoothness.py:67
self._tbm.DidRunStory(platform, self._results)
DidRunStory at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:310
trace_result = platform.tracing_controller.StopTracing()
StopTracing at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:47
return self._tracing_controller_backend.StopTracing()
StopTracing at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:109
self._IssueClockSyncMarker()
_IssueClockSyncMarker at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:213
self._RecordIssuerClockSyncMarker)
RecordClockSyncMarker at /usr/local/google/home/wkorman/workspace/chromium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:178
raise ChromeClockSyncError('Cannot issue clock sync. No devtools clients')
ChromeClockSyncError: Cannot issue clock sync. No devtools clients
Locals:
devtools_clients : []
record_controller_clock_sync_marker_callback : <bound method TracingControllerBackend._RecordIssuerClockSyncMarker of <telemetry.internal.platform.tracing_controller_backend.TracingControllerBackend object at 0x7fd7abe457d0>>
sync_id : 'fa338818-560e-4304-9306-b180e7355abd'
[ FAILED ] http://booking.com (9126 ms)
,
Aug 21 2017
Unassigning myself as I am no longer actively working on this. I've updated 756002 with more.
,
Aug 24 2017
Chrome crashed for hitting a CHECK here: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/synthetic_gesture_target_base.cc?rcl=b481b28ef49243e45c00b078caa049fcba826f3d&l=62 Basically the story script emitted pinch gestures using ActionRunner.PinchPage, which by default generate touch event at the center point of <body> element, which goes out of the view bound after zooming in, triggering the CHECK.
,
Aug 24 2017
And the Wikipedia story still fails. It seems to me the story wasn't recorded properly since the beginning. With .wpr it loaded 404 error page and succeeded, but it just timed out with .wprgo . (shrug)
,
Aug 24 2017
https://chromium-review.googlesource.com/c/chromium/src/+/630998
,
Sep 13 2017
According to the spreadsheet (https://docs.google.com/spreadsheets/d/1SVNzaT-bMIZ3nr6GZVXfLeoZIG59d635owASw2ayNpI/edit#gid=0) there are only two JSON pages left uncoverted: tough_pinch_zoom_cases.json key_desktop_move_cases.json Tien: can you do those two?
,
Sep 13 2017
Sure! Was waiting for the perf bots to quiet down before proceeding. Continuing now.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6f0b5099fb2f3207dbdd919211943677c2f5068 commit c6f0b5099fb2f3207dbdd919211943677c2f5068 Author: Tien-Ren Chen <trchen@chromium.org> Date: Wed Sep 13 22:50:17 2017 Migrate tough_pinch_zoom_cases to WPRGo Deleted one story (Wikipedia) in the process because it was never properly recorded (HTTP 404). BUG= 756002 , 756613 Change-Id: If5757f7cd68eabebf148595a4b57ad07436a164e Reviewed-on: https://chromium-review.googlesource.com/631257 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501779} [modify] https://crrev.com/c6f0b5099fb2f3207dbdd919211943677c2f5068/tools/perf/benchmarks/smoothness.py [modify] https://crrev.com/c6f0b5099fb2f3207dbdd919211943677c2f5068/tools/perf/page_sets/data/tough_pinch_zoom_cases.json [delete] https://crrev.com/9aa706c8157d1766bfe51f436f8e5f7bd3e9c269/tools/perf/page_sets/data/tough_pinch_zoom_cases_000.wpr.sha1 [add] https://crrev.com/c6f0b5099fb2f3207dbdd919211943677c2f5068/tools/perf/page_sets/data/tough_pinch_zoom_cases_000.wprgo.sha1 [modify] https://crrev.com/c6f0b5099fb2f3207dbdd919211943677c2f5068/tools/perf/page_sets/tough_pinch_zoom_cases.py
,
Sep 26 2017
A friendly ping. trchen@: Any update on "key_desktop_move_cases.json" ? This is the only wpr pageset that is remaining.
,
Sep 26 2017
Just uploaded for review. I'll close this one and track it with issue 756002 . |
||||
►
Sign in to add a comment |
||||
Comment 1 by wkorman@chromium.org
, Aug 17 2017