OfflineAudioContext oncomplete not firing |
|||
Issue descriptionChrome Version: ToT chromium today What steps will reproduce the problem? (1) Visit https://rtoy.github.io/webaudio-benchmark/index.html?useEvent (2) Open dev tools (3) What is the expected result? Dev console should print out that startRendering is using the event handler. There should be an output line for each test that is run What happens instead? Not messages for the test. Compare the console output using https://rtoy.github.io/webaudio-benchmark/index.html. This uses the promise returned by startRendering. There is a line printed as each test finishes.
,
Aug 22 2017
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b143568509fee3ab04070a7aba05189d48ea87a2 commit b143568509fee3ab04070a7aba05189d48ea87a2 Author: Jeremy Roman <jbroman@chromium.org> Date: Tue Aug 22 23:55:16 2017 Fix BaseAudioContext::TraceWrappers to reach the EventTarget data. Previously it was not invoking EventTargetWithInlineData's wrapper-tracing method, so this was getting lost in the override. This bug was previously hidden by the redundant tracing of event listeners which was removed in r491479: https://chromium.googlesource.com/chromium/src/+/d68025ec A layout test for this case has been added. Bug: 756611 Change-Id: I98c8dc49eef3b49c20788a55ca2843521051cd5e Reviewed-on: https://chromium-review.googlesource.com/627421 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#496511} [add] https://crrev.com/b143568509fee3ab04070a7aba05189d48ea87a2/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc.html [modify] https://crrev.com/b143568509fee3ab04070a7aba05189d48ea87a2/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
,
Aug 24 2017
Fixed. No merge necessary, as the original change is in the same milestone as the fix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rtoy@chromium.org
, Aug 21 2017