Issue metadata
Sign in to add a comment
|
ProxyHasProperty stub crashes when trap is a Smi |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5958699981209600 Fuzzer: decoder_langfuzz Job Type: linux_asan_d8 Platform Id: linux Crash Type: UNKNOWN READ Crash Address: 0xffffffffffffffff Crash State: v8::internal::Invoke v8::internal::CallInternal v8::Script::Run Sanitizer: address (ASAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8&range=47371:47372 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5958699981209600 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Aug 17 2017
Maya, this one's for you.
Repro:
out/x64.debug/d8 -e "'foo' in new Proxy({}, {has: 0})"
The fix seems simple: I think you need the "GotoIf(TaggedIsSmi(trap), &trap_not_callable);" line that the "get" stub has but the "has" stub doesn't.
,
Aug 18 2017
,
Aug 18 2017
,
Aug 18 2017
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 18 2017
The fix is already pending a code review: https://chromium-review.googlesource.com/c/620647
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/03285ec968a78683be5342c4a035da81bf394816 commit 03285ec968a78683be5342c4a035da81bf394816 Author: Maya Lekova <mslekova@google.com> Date: Fri Aug 18 13:56:18 2017 [builtins] Fix crash in ProxyHasProperty stub The crash used to happen when trap is a Smi. Bug: chromium:756608 Change-Id: I0a6f0328afc64d8e521b5b370a291f9aef6b08d0 Reviewed-on: https://chromium-review.googlesource.com/620647 Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@google.com> Cr-Commit-Position: refs/heads/master@{#47429} [modify] https://crrev.com/03285ec968a78683be5342c4a035da81bf394816/src/builtins/builtins-proxy-gen.cc [add] https://crrev.com/03285ec968a78683be5342c4a035da81bf394816/test/mjsunit/regress/regress-756608.js
,
Aug 18 2017
Should be fixed by #7. Thanks for the quick turnaround!
,
Aug 19 2017
ClusterFuzz has detected this issue as fixed in range 47428:47429. Detailed report: https://clusterfuzz.com/testcase?key=5958699981209600 Fuzzer: decoder_langfuzz Job Type: linux_asan_d8 Platform Id: linux Crash Type: UNKNOWN READ Crash Address: 0xffffffffffffffff Crash State: v8::internal::Invoke v8::internal::CallInternal v8::Script::Run Sanitizer: address (ASAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8&range=47371:47372 Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8&range=47428:47429 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5958699981209600 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Aug 19 2017
ClusterFuzz testcase 5958699981209600 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Aug 19 2017
,
Sep 1 2017
*** Boilerplate reminders! *** Please do NOT publicly disclose details until a fix has been released to all our users. Early public disclosure may cancel the provisional reward. Also, please be considerate about disclosure when the bug affects a core library that may be used by other products. Please do NOT share this information with third parties who are not directly involved in fixing the bug. Doing so may cancel the provisional reward. Please be honest if you have already disclosed anything publicly or to third parties. Lastly, we understand that some of you are not interested in money. We offer the option to donate your reward to an eligible charity. If you prefer this option, let us know and we will also match your donation - subject to our discretion. Any rewards that are unclaimed after 12 months will be donated to a charity of our choosing. *********************************
,
Sep 1 2017
Groovy - your fuzzer got you another $3,500 :-)
,
Sep 1 2017
,
Oct 5 2017
,
Nov 25 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsesek@chromium.org
, Aug 17 2017Owner: jkummerow@chromium.org
Status: Assigned (was: Untriaged)