New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756606 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 756600


Participants' hotlists:
WmatrixHotlist


Sign in to add a comment

add monarch instrumentation to matrix backend

Project Member Reported by akes...@chromium.org, Aug 17 2017

Issue description

wmatrix backend should at least have tick and error rate metrics
 
Blockedon: 756600
Blockedon: -756600
Blocking: 756600

Comment 3 by jkop@chromium.org, Aug 29 2017

Owner: jkop@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-private/+/f8ad08fad2bfb2e0b2388e68c0cba52bb8fd5ac2

commit f8ad08fad2bfb2e0b2388e68c0cba52bb8fd5ac2
Author: Jacob Kopczynski <jkop@google.com>
Date: Mon Oct 30 22:53:32 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-private/+/adc185998c269a8d3d83f9b84c7e6b57ee6d0e39

commit adc185998c269a8d3d83f9b84c7e6b57ee6d0e39
Author: Jacob Kopczynski <jkop@google.com>
Date: Thu Nov 02 23:03:00 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/whining/+/0ef6bfc16148286fac8c45431e17d8703a886cd6

commit 0ef6bfc16148286fac8c45431e17d8703a886cd6
Author: Jacob Kopczynski <jkop@google.com>
Date: Sat Nov 04 04:56:48 2017

Add metrics and venv to wmatrix DB update pipeline

As part of this addition, refactor update_rawdb and update_wmdb to pull
 shared code into a new lib file. All logging will occur from a single
 line.
In order to enable local checks and use of chromite, also add virtualenv for
 dependencies.

BUG= chromium:756606 
TEST=Run live.

Change-Id: I45de3285be35b34b0f3b23f22afc561a263249b0
Reviewed-on: https://chromium-review.googlesource.com/707825
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/src/backend/__init__.py
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/venv/whining/__init__.py
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/bin/python_venv
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/venv/requirements.txt
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/venv/.coveragerc
[modify] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/src/backend/update_wmdb.py
[modify] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/src/backend/update_rawdb.py
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/.gitignore
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/venv/pytest.ini
[modify] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/src/backend/get_schedule.py
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/venv/.gitignore
[add] https://crrev.com/0ef6bfc16148286fac8c45431e17d8703a886cd6/src/backend/update_lib.py

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/autotest-private/+/bf42342e61ac0e85538cb493621b641d9036b9ec

commit bf42342e61ac0e85538cb493621b641d9036b9ec
Author: Jacob Kopczynski <jkop@google.com>
Date: Sat Nov 04 04:56:49 2017

Comment 8 by jkop@chromium.org, Nov 8 2017

Status: Started (was: Assigned)
Metrics change deployed, but they do not appear to be sent. Requires more investigation.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/whining/+/86733e94629807aca10be2f86bf3ec3cba55961b

commit 86733e94629807aca10be2f86bf3ec3cba55961b
Author: Jacob Kopczynski <jkop@google.com>
Date: Sat Nov 11 00:27:28 2017

wmatrix: more useful error classification

Add several error categories to classify_error.

BUG= chromium:756606 
TEST=run live

Change-Id: Iee274ba71c46b235aef75325251747edfbba95fd
Reviewed-on: https://chromium-review.googlesource.com/759410
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/86733e94629807aca10be2f86bf3ec3cba55961b/src/backend/update_lib.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ed55f2ebd0ee8980b78747995985b09f68298ffe

commit ed55f2ebd0ee8980b78747995985b09f68298ffe
Author: Jacob Kopczynski <jkop@google.com>
Date: Wed Nov 15 00:03:20 2017

balance_pools: run with indirect=True

Now sends metrics from subprocesses

BUG= chromium:756606 
TEST=run as dry_run

Change-Id: I6fba1771de0635891f942d120065a4cb65ec7b9f
Reviewed-on: https://chromium-review.googlesource.com/764435
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/ed55f2ebd0ee8980b78747995985b09f68298ffe/site_utils/balance_pools.py

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/whining/+/e3868f8fc73e97e776dd559d0235090820868222

commit e3868f8fc73e97e776dd559d0235090820868222
Author: Jacob Kopczynski <jkop@google.com>
Date: Sat Nov 18 04:18:28 2017

wmatrix: Add metrics flush to actually send them

BUG= chromium:756606 
TEST=run with metrics redirected to file.

Change-Id: Iaeb6c2f552f2d4853f3c9527f54c9638f39c1d84
Reviewed-on: https://chromium-review.googlesource.com/759427
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/e3868f8fc73e97e776dd559d0235090820868222/src/backend/update_wmdb.py
[modify] https://crrev.com/e3868f8fc73e97e776dd559d0235090820868222/src/backend/update_rawdb.py
[modify] https://crrev.com/e3868f8fc73e97e776dd559d0235090820868222/src/backend/update_lib.py

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/whining/+/ce6b2ba21ec94dc98c6bcedca733fbfae4358d47

commit ce6b2ba21ec94dc98c6bcedca733fbfae4358d47
Author: Jacob Kopczynski <jkop@google.com>
Date: Sat Nov 18 04:18:28 2017

wmatrix: remove short_lived

It's not necessary and is causing metrics not to be collected properly.

BUG= chromium:756606 
TEST=None

Change-Id: I801610b687541d16c126876e8a0c9553e71779a0
Reviewed-on: https://chromium-review.googlesource.com/777030
Commit-Ready: Jacob Kopczynski <jkop@chromium.org>
Tested-by: Jacob Kopczynski <jkop@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/ce6b2ba21ec94dc98c6bcedca733fbfae4358d47/src/backend/update_wmdb.py
[modify] https://crrev.com/ce6b2ba21ec94dc98c6bcedca733fbfae4358d47/src/backend/update_rawdb.py

Comment 13 by jkop@chromium.org, Nov 30 2017

Status: Fixed (was: Started)
Fixed as of: https://critique.corp.google.com/#review/176720412

Sign in to add a comment