Use non-tablet-style power button behavior on eve |
||||||||
Issue descriptionPer discussion between jennschen@, kuscher@, tbuckley@, and me this morning, we're planning to change eve's power button behavior for M61 to match that of non-convertible devices both when in laptop and tablet mode. Tapping the power button won't do anything; the user will need to hold it for ~1.5 seconds to lock and for ~4 seconds to shut down. Other platforms will be unaffected. There's also a second request that may be harder to do: the screen should turn off just two seconds after it's locked instead of the current delay of 40 seconds (see prefs::kPowerLockScreenOffDelayMs in chrome/browser/chromeos/power/power_prefs.cc). I'm not sure what we should do with the screen-dim-while-locked delay of 30 seconds. This should only happen when the screen is locked using the power button; we should continue to use the longer delay e.g. after the user idles to screen-off and then taps the Shift key.
,
Aug 17 2017
https://chromium-review.googlesource.com/c/619623 and https://chromium-review.googlesource.com/c/619761 for the session_manager portion.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96b4c361ec7f4e354f8252d7a46aba6194f66f71 commit 96b4c361ec7f4e354f8252d7a46aba6194f66f71 Author: Daniel Erat <derat@chromium.org> Date: Fri Aug 18 00:15:50 2017 chromeos: Add --force-clamshell-power-button. Add a command-line flag that can be passed to instruct ash::PowerButtonController to use clamshell-style power button behavior even if it sees accelerometer events. BUG: 756601 Test: tested on device with --force-clamshell-power-button switch Change-Id: I50784c9b68f1a1b33fc5d1cb2b25e2cbeb535826 Reviewed-on: https://chromium-review.googlesource.com/619690 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#495393} [modify] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/ash/ash_switches.cc [modify] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/ash/ash_switches.h [modify] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/ash/system/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/ash/wm/power_button_controller.cc [modify] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/ash/wm/power_button_controller.h [modify] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/chrome/browser/chromeos/login/chrome_restart_request.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1df90ae8697fe31831eb78146d3ed8d9fa30e1dd commit 1df90ae8697fe31831eb78146d3ed8d9fa30e1dd Author: Daniel Erat <derat@chromium.org> Date: Fri Aug 18 03:42:00 2017 libchromeos-use-flags: Add eve to IUSE. BUG= chromium:756601 TEST=none Change-Id: Ie660a49d3f9ab980fc03d5cbb733ff6cc3dd5bd3 Reviewed-on: https://chromium-review.googlesource.com/619623 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/1df90ae8697fe31831eb78146d3ed8d9fa30e1dd/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r35.ebuild [modify] https://crrev.com/1df90ae8697fe31831eb78146d3ed8d9fa30e1dd/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8bc24f8d59d0f87ef4b34e4f3a556f9c214e9365 commit 8bc24f8d59d0f87ef4b34e4f3a556f9c214e9365 Author: Daniel Erat <derat@chromium.org> Date: Fri Aug 18 03:41:57 2017 login: Pass --force-clamshell-power-button for eve. BUG= chromium:756601 TEST=none Change-Id: Iadadfefefd7942cc40946e3595022052f9cb695c Reviewed-on: https://chromium-review.googlesource.com/619761 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> [modify] https://crrev.com/8bc24f8d59d0f87ef4b34e4f3a556f9c214e9365/login_manager/chrome_setup.cc
,
Aug 18 2017
,
Aug 18 2017
Approving merge to M61 Chrome OS.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/087ef8492622e64b7573933fc9e6a77fff2f91b8 commit 087ef8492622e64b7573933fc9e6a77fff2f91b8 Author: Daniel Erat <derat@chromium.org> Date: Fri Aug 18 21:24:26 2017 chromeos: Add --force-clamshell-power-button. Add a command-line flag that can be passed to instruct ash::PowerButtonController to use clamshell-style power button behavior even if it sees accelerometer events. TBR=derat@chromium.org (cherry picked from commit 96b4c361ec7f4e354f8252d7a46aba6194f66f71) Bug: 756601 Test: tested on device with --force-clamshell-power-button switch Change-Id: I50784c9b68f1a1b33fc5d1cb2b25e2cbeb535826 Reviewed-on: https://chromium-review.googlesource.com/619690 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#495393} Reviewed-on: https://chromium-review.googlesource.com/621957 Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#686} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/087ef8492622e64b7573933fc9e6a77fff2f91b8/ash/ash_switches.cc [modify] https://crrev.com/087ef8492622e64b7573933fc9e6a77fff2f91b8/ash/ash_switches.h [modify] https://crrev.com/087ef8492622e64b7573933fc9e6a77fff2f91b8/ash/system/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/087ef8492622e64b7573933fc9e6a77fff2f91b8/ash/wm/power_button_controller.cc [modify] https://crrev.com/087ef8492622e64b7573933fc9e6a77fff2f91b8/ash/wm/power_button_controller.h [modify] https://crrev.com/087ef8492622e64b7573933fc9e6a77fff2f91b8/chrome/browser/chromeos/login/chrome_restart_request.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/396e04a994ab76d348596e7aaf91ce10b3301dc9 commit 396e04a994ab76d348596e7aaf91ce10b3301dc9 Author: Daniel Erat <derat@chromium.org> Date: Fri Aug 18 22:03:06 2017 login: Pass --force-clamshell-power-button for eve. BUG= chromium:756601 TEST=none Change-Id: Iadadfefefd7942cc40946e3595022052f9cb695c Reviewed-on: https://chromium-review.googlesource.com/619761 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> (cherry picked from commit 8bc24f8d59d0f87ef4b34e4f3a556f9c214e9365) Reviewed-on: https://chromium-review.googlesource.com/621251 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/396e04a994ab76d348596e7aaf91ce10b3301dc9/login_manager/chrome_setup.cc
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8d943a80744969da7968d3f943712632c48d3def commit 8d943a80744969da7968d3f943712632c48d3def Author: Daniel Erat <derat@chromium.org> Date: Fri Aug 18 23:42:54 2017 libchromeos-use-flags: Add eve to IUSE. BUG= chromium:756601 TEST=none Previous-Reviewed-on: https://chromium-review.googlesource.com/619623 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> (cherry picked from commit 1df90ae8697fe31831eb78146d3ed8d9fa30e1dd) Change-Id: Ib084a14ccbb8452110f3bd0face58831f156efd1 Reviewed-on: https://chromium-review.googlesource.com/622255 Reviewed-by: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/8d943a80744969da7968d3f943712632c48d3def/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r34.ebuild [modify] https://crrev.com/8d943a80744969da7968d3f943712632c48d3def/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Aug 24 2017
I've filed issue 758574 to track the riskier change to make us turn the screen off shortly after it's locked via the power button.
,
Aug 25 2017
It is not related to the implementation, just my puzzle which I should post at earlier time. Is second request Eve only, or deployed to some or all convertible devices? How do we judge that if some should but not all?
,
Aug 25 2017
I think the second request is going to be eve-only; I explained over IM.
,
Jan 2 2018
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by derat@chromium.org
, Aug 17 2017