Improve accessibility description for Playstore results |
||||||
Issue descriptionAdd star rating and price.
,
Aug 18 2017
Approving merge to M61 Chrome OS.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5dc3baded573d180f940eb08b7ae2905bca2bc9 commit f5dc3baded573d180f940eb08b7ae2905bca2bc9 Author: Vadim Tryshev <vadimt@google.com> Date: Fri Aug 18 18:22:34 2017 Including app price and rating in the accessibility description. For Play Store app search results, we've read only app name. Now we include also star rating and price. We are in talks about better description, such as "Google Maps, four point three stars, one dollar", but I believe that this small improvement is already beneficial for the users. Fixed SearchResultTileItemView perpetuating configuration parameters in static variables, which made unit tests check wrong behavior. Bug: 756598 Change-Id: Ia5913380f1d2370e3626c6f730c21b427fc6114d Reviewed-on: https://chromium-review.googlesource.com/619180 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#495625} [modify] https://crrev.com/f5dc3baded573d180f940eb08b7ae2905bca2bc9/ui/app_list/views/search_result_tile_item_list_view.cc [modify] https://crrev.com/f5dc3baded573d180f940eb08b7ae2905bca2bc9/ui/app_list/views/search_result_tile_item_list_view_unittest.cc [modify] https://crrev.com/f5dc3baded573d180f940eb08b7ae2905bca2bc9/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/f5dc3baded573d180f940eb08b7ae2905bca2bc9/ui/app_list/views/search_result_tile_item_view.h [modify] https://crrev.com/f5dc3baded573d180f940eb08b7ae2905bca2bc9/ui/app_list/views/suggestions_container_view.cc
,
Aug 21 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c466b056723c592a5333152b13a76b271b6b50f commit 0c466b056723c592a5333152b13a76b271b6b50f Author: Vadim Tryshev <vadimt@google.com> Date: Mon Aug 21 21:47:40 2017 Including app price and rating in the accessibility description. For Play Store app search results, we've read only app name. Now we include also star rating and price. We are in talks about better description, such as "Google Maps, four point three stars, one dollar", but I believe that this small improvement is already beneficial for the users. Fixed SearchResultTileItemView perpetuating configuration parameters in static variables, which made unit tests check wrong behavior. TBR=vadimt@google.com (cherry picked from commit f5dc3baded573d180f940eb08b7ae2905bca2bc9) Bug: 756598 Change-Id: Ia5913380f1d2370e3626c6f730c21b427fc6114d Reviewed-on: https://chromium-review.googlesource.com/619180 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#495625} Reviewed-on: https://chromium-review.googlesource.com/624895 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#734} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0c466b056723c592a5333152b13a76b271b6b50f/ui/app_list/views/search_result_tile_item_list_view.cc [modify] https://crrev.com/0c466b056723c592a5333152b13a76b271b6b50f/ui/app_list/views/search_result_tile_item_list_view_unittest.cc [modify] https://crrev.com/0c466b056723c592a5333152b13a76b271b6b50f/ui/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/0c466b056723c592a5333152b13a76b271b6b50f/ui/app_list/views/search_result_tile_item_view.h [modify] https://crrev.com/0c466b056723c592a5333152b13a76b271b6b50f/ui/app_list/views/suggestions_container_view.cc
,
Aug 22 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Aug 17 2017