New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756576 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 771875



Sign in to add a comment

Log Printer Setup Abandonment

Project Member Reported by skau@chromium.org, Aug 17 2017

Issue description

So that we're aware of printers that users are frustrated with, log the make and model information of printers where users gave up on the setup.

Leftover work from:
https://bugs.chromium.org/p/chromium/issues/detail?id=647283
 

Comment 1 by skau@chromium.org, Sep 6 2017

Labels: -M-62 M-63
Ran out of time.  Punt to 63.

Comment 2 by skau@chromium.org, Oct 5 2017

Blockedon: 771875
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c397a59516e30df79b19583dcfc02f4395957481

commit c397a59516e30df79b19583dcfc02f4395957481
Author: Sean Kau <skau@chromium.org>
Date: Wed Oct 18 02:11:23 2017

Record metrics for abandoned printer setups.

To determine what printers users are having difficulty setting up,
record the printer if setup is abandoned from the PPD selection screen.
This will tell us where our PPD coverage is lacking.

Bug:  756576 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1e0913a3096d8a674a14cf230f6b97af456b330
Reviewed-on: https://chromium-review.googlesource.com/602696
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509654}
[modify] https://crrev.com/c397a59516e30df79b19583dcfc02f4395957481/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/c397a59516e30df79b19583dcfc02f4395957481/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/c397a59516e30df79b19583dcfc02f4395957481/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/c397a59516e30df79b19583dcfc02f4395957481/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
[modify] https://crrev.com/c397a59516e30df79b19583dcfc02f4395957481/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/c397a59516e30df79b19583dcfc02f4395957481/chrome/test/data/webui/settings/cups_printer_page_tests.js

Comment 4 by skau@chromium.org, Oct 18 2017

Labels: Merge-Request-63
Status: Fixed (was: Started)
Request to pick back.  No user visible changes.  Launching an additional metric.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 19 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5

commit 5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5
Author: Sean Kau <skau@chromium.org>
Date: Thu Oct 19 17:42:25 2017

Record metrics for abandoned printer setups.

To determine what printers users are having difficulty setting up,
record the printer if setup is abandoned from the PPD selection screen.
This will tell us where our PPD coverage is lacking.

TBR=skau@chromium.org

(cherry picked from commit c397a59516e30df79b19583dcfc02f4395957481)

Bug:  756576 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id1e0913a3096d8a674a14cf230f6b97af456b330
Reviewed-on: https://chromium-review.googlesource.com/602696
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509654}
Reviewed-on: https://chromium-review.googlesource.com/728348
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#72}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h
[modify] https://crrev.com/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/5c56ee9ff3bb346aed0c72e6914c361c2ee6fad5/chrome/test/data/webui/settings/cups_printer_page_tests.js

Sign in to add a comment