https://chromium.googlesource.com/chromium/src/+/d629de326110e81a67317312b794ddec5a077d29 caused about 200 layout test failures on network service bot. see https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/4272 With the new code path, workers are now getting a URLLoaderFactory from the ResourceDispatcherHost through WorkerURLLoaderFactoryProviderImpl. I think we can simplify this now that URLLoaderFactory has a Clone method. When creating a dedicated worker, RenderFrame can clone its URLLoaderFactory and provide that to WorkerFetchContextImpl. Shared workers will need to get the render process wide URLLoaderFactory to clone.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ecb2d6bbcc62c159dca2656e5ec29228b7aa6e3 commit 4ecb2d6bbcc62c159dca2656e5ec29228b7aa6e3 Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Aug 17 20:03:40 2017 Temporarily disable OffMainThreadFetch with network service. BUG= 756571 TBR=kinuko@chromium.org NOTRY=true Change-Id: Ieb3ee459062dbcebeb4f6eddb75090a58b7e8b2b Reviewed-on: https://chromium-review.googlesource.com/619647 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#495293} [modify] https://crrev.com/4ecb2d6bbcc62c159dca2656e5ec29228b7aa6e3/content/child/runtime_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38e2b7aee1f91154d458ad07f38e0f09327fb873 commit 38e2b7aee1f91154d458ad07f38e0f09327fb873 Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Aug 18 02:08:44 2017 Update some layout test expectations for network service. These were passing tests before r495097 which enabled OffMainThreadFetch by default. Even after disabling that feature for network service, the tests are failing because the cl also updated their expectations. TBR=kinuko@chromium.org BUG= 756571 NOTRY=true Change-Id: Ie13f477c7986fd487a86d1dc3f7e291a52d72374 Reviewed-on: https://chromium-review.googlesource.com/620275 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#495425} [modify] https://crrev.com/38e2b7aee1f91154d458ad07f38e0f09327fb873/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
Issue 755055 has been merged into this issue.
horo@-san: (per offline chat) do you think you can take a look at this?
OK I'll take a look.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/339cb6961a6e02924898f0692e8a9567b0302935 commit 339cb6961a6e02924898f0692e8a9567b0302935 Author: Daniel Hintze <hintzed@google.com> Date: Tue Aug 22 14:43:26 2017 Set referrer for cors preflights This CL makes CORS preflight requests use the same referrer and referrer policy as the actual request as (now) specified (https://fetch.spec.whatwg.org/#cors-preflight-fetch) and thus fixes some previously broken tests. Bug: 756571 Change-Id: I9eafe45df39ac1f71207555947315456ced7f7d8 Reviewed-on: https://chromium-review.googlesource.com/625625 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Daniel Hintze <hintzed@google.com> Cr-Commit-Position: refs/heads/master@{#496303} [delete] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/third_party/WebKit/LayoutTests/external/wpt/fetch/api/cors/cors-preflight-referrer.any-expected.txt [delete] https://crrev.com/ba7e48f93bd0d79696d11baf8374d273f76d72d1/third_party/WebKit/LayoutTests/external/wpt/fetch/api/cors/cors-preflight-referrer.any.worker-expected.txt [modify] https://crrev.com/339cb6961a6e02924898f0692e8a9567b0302935/third_party/WebKit/Source/platform/exported/WebCORS.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b73429ef4968c087931bc30f787357e8e0e1d4d0 commit b73429ef4968c087931bc30f787357e8e0e1d4d0 Author: Tsuyoshi Horo <horo@chromium.org> Date: Fri Aug 25 10:46:25 2017 Stop using WorkerURLLoaderFactoryProvider I introduced WorkerURLLoaderFactoryProvider in e612058 to: 1) Get the URLLoaderFactory in the worker thread. 2) Register the WorkerFetchContextImpl in a (dedicated or shared) worker thread as a ServiceWorkerWorkerClient to the parent document's ServiceWorkerProviderHost in the browser process to receive SetControllerServiceWorker() method call. But now we can get the URLLoaderFactory in the main thread and make a clone of it and provide that to WorkerFetchContextImpl. So this cl deletes WorkerURLLoaderFactoryProvider and use the Clone method of URLLoaderFactory. And also this cl changes the caller of SetControllerServiceWorker() from the ServiceWorkerProviderHost in the browser process to ServiceWorkerProviderContext in the main thread of the renderer process. OffMainThreadFetch was disabled when NetworkService is enabled because WorkerURLLoaderFactoryProvider can't a URLLoaderFactory. But we can enable it now. Bug: 756571 Change-Id: Ib2a549ce23dc0a612a2df88c1f45af1383192ad3 Reviewed-on: https://chromium-review.googlesource.com/620510 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#497372} [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/service_worker/service_worker_context_core.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/service_worker/service_worker_context_core.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/service_worker/service_worker_context_wrapper.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/child/child_url_loader_factory_getter.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/child/child_url_loader_factory_getter.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/child/loader/cors_url_loader_factory.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/child/runtime_features.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/child/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/child/service_worker/service_worker_provider_context.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/common/BUILD.gn [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/common/service_worker/service_worker_provider_interfaces.mojom [delete] https://crrev.com/cdb2e7347e272e46ff67f64460991bf38eb90461/content/common/worker_url_loader_factory_provider.mojom [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/render_frame_impl.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/service_worker/service_worker_fetch_context_impl.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/service_worker/worker_fetch_context_impl.h [modify] https://crrev.com/b73429ef4968c087931bc30f787357e8e0e1d4d0/content/renderer/shared_worker/embedded_shared_worker_stub.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb082ed4d1400832d7fb4172ac6b0c2852b83790 commit cb082ed4d1400832d7fb4172ac6b0c2852b83790 Author: Egor Pasko <pasko@chromium.org> Date: Fri Aug 25 13:14:20 2017 Revert "Stop using WorkerURLLoaderFactoryProvider" This reverts commit b73429ef4968c087931bc30f787357e8e0e1d4d0. Reason for revert: http://crbug.com/758981 Original change's description: > Stop using WorkerURLLoaderFactoryProvider > > I introduced WorkerURLLoaderFactoryProvider in e612058 to: > 1) Get the URLLoaderFactory in the worker thread. > 2) Register the WorkerFetchContextImpl in a (dedicated or shared) worker thread > as a ServiceWorkerWorkerClient to the parent document's ServiceWorkerProviderHost > in the browser process to receive SetControllerServiceWorker() method call. > > But now we can get the URLLoaderFactory in the main thread and make a clone of > it and provide that to WorkerFetchContextImpl. > So this cl deletes WorkerURLLoaderFactoryProvider and use the Clone method of > URLLoaderFactory. > > And also this cl changes the caller of SetControllerServiceWorker() from the > ServiceWorkerProviderHost in the browser process to ServiceWorkerProviderContext > in the main thread of the renderer process. > > OffMainThreadFetch was disabled when NetworkService is enabled because > WorkerURLLoaderFactoryProvider can't a URLLoaderFactory. But we can enable it > now. > > > Bug: 756571 > Change-Id: Ib2a549ce23dc0a612a2df88c1f45af1383192ad3 > Reviewed-on: https://chromium-review.googlesource.com/620510 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#497372} TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org Change-Id: Ia956b33a749fda9989803ff76f5705ae1f758425 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756571 Reviewed-on: https://chromium-review.googlesource.com/635544 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#497387} [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/service_worker/service_worker_context_core.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/service_worker/service_worker_context_core.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/service_worker/service_worker_context_wrapper.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/child/child_url_loader_factory_getter.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/child/child_url_loader_factory_getter.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/child/loader/cors_url_loader_factory.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/child/runtime_features.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/child/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/child/service_worker/service_worker_provider_context.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/common/BUILD.gn [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/common/service_worker/service_worker_provider_interfaces.mojom [add] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/common/worker_url_loader_factory_provider.mojom [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/render_frame_impl.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/service_worker/service_worker_fetch_context_impl.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/service_worker/worker_fetch_context_impl.h [modify] https://crrev.com/cb082ed4d1400832d7fb4172ac6b0c2852b83790/content/renderer/shared_worker/embedded_shared_worker_stub.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855 commit e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855 Author: Tsuyoshi Horo <horo@chromium.org> Date: Fri Aug 25 16:01:13 2017 Reland "Stop using WorkerURLLoaderFactoryProvider" Reason for reland: http://crbug.com/758981#c3 This is a reland of b73429ef4968c087931bc30f787357e8e0e1d4d0 Original change's description: > Stop using WorkerURLLoaderFactoryProvider > > I introduced WorkerURLLoaderFactoryProvider in e612058 to: > 1) Get the URLLoaderFactory in the worker thread. > 2) Register the WorkerFetchContextImpl in a (dedicated or shared) worker thread > as a ServiceWorkerWorkerClient to the parent document's ServiceWorkerProviderHost > in the browser process to receive SetControllerServiceWorker() method call. > > But now we can get the URLLoaderFactory in the main thread and make a clone of > it and provide that to WorkerFetchContextImpl. > So this cl deletes WorkerURLLoaderFactoryProvider and use the Clone method of > URLLoaderFactory. > > And also this cl changes the caller of SetControllerServiceWorker() from the > ServiceWorkerProviderHost in the browser process to ServiceWorkerProviderContext > in the main thread of the renderer process. > > OffMainThreadFetch was disabled when NetworkService is enabled because > WorkerURLLoaderFactoryProvider can't a URLLoaderFactory. But we can enable it > now. > > > Bug: 756571 > Change-Id: Ib2a549ce23dc0a612a2df88c1f45af1383192ad3 > Reviewed-on: https://chromium-review.googlesource.com/620510 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#497372} TBR=falken@chromium.org,pasko@chromium.org,dcheng@chromium.org,kinuko@chromium.org Bug: 756571 ,758981 Change-Id: I3735b2841bdc91efb31da2b9dbea8636136aa5f9 Reviewed-on: https://chromium-review.googlesource.com/635823 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#497422} [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/service_worker/service_worker_context_core.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/service_worker/service_worker_context_core.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/service_worker/service_worker_context_wrapper.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/service_worker/service_worker_provider_host.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/browser/service_worker/service_worker_provider_host.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/child/child_url_loader_factory_getter.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/child/child_url_loader_factory_getter.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/child/loader/cors_url_loader_factory.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/child/runtime_features.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/child/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/child/service_worker/service_worker_provider_context.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/common/BUILD.gn [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/common/service_worker/service_worker_provider_interfaces.mojom [delete] https://crrev.com/b6ba9966360367f58c72395c4a088a72bc850a43/content/common/worker_url_loader_factory_provider.mojom [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/render_frame_impl.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/service_worker/service_worker_fetch_context_impl.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/service_worker/worker_fetch_context_impl.h [modify] https://crrev.com/e4b17a3c3ed5c61dcaaad37f2cecbac5ea767855/content/renderer/shared_worker/embedded_shared_worker_stub.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa9c45f113d12b207597e909e679279ea8ede5e6 commit aa9c45f113d12b207597e909e679279ea8ede5e6 Author: Tsuyoshi Horo <horo@chromium.org> Date: Mon Aug 28 07:38:09 2017 Check the existence of ServiceWorkerProviderContext And add Service Worker fetch tests for fetching from worker in sandboxed iframes. Bug: 759200 , 756571 Change-Id: Id0d74a469bb1afc8ac26439aa5968fda670a6daf Reviewed-on: https://chromium-review.googlesource.com/637059 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#497705} [modify] https://crrev.com/aa9c45f113d12b207597e909e679279ea8ede5e6/content/renderer/render_frame_impl.cc [modify] https://crrev.com/aa9c45f113d12b207597e909e679279ea8ede5e6/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/aa9c45f113d12b207597e909e679279ea8ede5e6/content/renderer/service_worker/worker_fetch_context_impl.h [modify] https://crrev.com/aa9c45f113d12b207597e909e679279ea8ede5e6/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/sandboxed-iframe-fetch-event-iframe.html [modify] https://crrev.com/aa9c45f113d12b207597e909e679279ea8ede5e6/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/sandboxed-iframe-fetch-event.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/141bc3819f90b2b4e5421e05a781dbc2145e855f commit 141bc3819f90b2b4e5421e05a781dbc2145e855f Author: Tsuyoshi Horo <horo@chromium.org> Date: Mon Aug 28 11:06:46 2017 Revise comment in RenderFrameImpl::CreateWorkerFetchContext() Bug: 759200 , 756571 Change-Id: I15e4e036a9bcb2cb36a131eb6b8196a4d091f1e0 Reviewed-on: https://chromium-review.googlesource.com/636727 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#497732} [modify] https://crrev.com/141bc3819f90b2b4e5421e05a781dbc2145e855f/content/renderer/render_frame_impl.cc
Apologies, applied the wrong component in bulk.
Comment 1 by bugdroid1@chromium.org
, Aug 17 2017