New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , All
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR



Sign in to add a comment
link

Issue 756564: VR: Add user gesture to displayactivate events.

Reported by mthiesse@chromium.org, Aug 17 2017 Project Member

Issue description

Doc: https://docs.google.com/document/d/1OaxvioOpaZkpfSftWNuTHDfY9eHsV4meUaxqUO5EshI/edit

Summary: displayactivate is only triggerable by user action, with the intent to interact with the page, and so should have a gesture token associated with it. This allows media playback for WebVR pages that only receive the displayactivate event without the user tapping/clicking on the page.
 

Comment 1 by bugdroid1@chromium.org, Aug 22 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09b107130f5c7a4cb377322b879ac2aac67cadbf

commit 09b107130f5c7a4cb377322b879ac2aac67cadbf
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Aug 22 04:58:14 2017

VR: Add gesture token to vrdisplayactivate, remove cardboard compat hack

This CL adds a gesture token to the displayactivate event which can only
be triggered by user action (on Android, placing the phone in a VR
headset and completing controller pairing while on a WebVR site).

This CL also removes the cardboard click event used for compatibility
and supplying user gesture, as a gesture is now supplied with the
displayactivate event.

Note: Once this lands, action will be required on the part of WebVR
Origin Trial participants that were previously relying on the cardboard
compat click events to act as user gestures - they will have to
perform any gesture-requiring actions in the displayactivate handler.

Bug:  716571 ,  756564 
Change-Id: I541c8e181fadaf58710da57b6e9f5e8971451073
Reviewed-on: https://chromium-review.googlesource.com/619170
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496219}
[modify] https://crrev.com/09b107130f5c7a4cb377322b879ac2aac67cadbf/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/09b107130f5c7a4cb377322b879ac2aac67cadbf/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/09b107130f5c7a4cb377322b879ac2aac67cadbf/third_party/WebKit/Source/modules/vr/VRDisplay.h

Comment 2 by mthiesse@chromium.org, Aug 28 2017

Status: Fixed (was: Started)

Comment 3 by dbbrooks@chromium.org, Sep 5 2017

Michael, is this something that I can verify manually? It sounds like I can, but I'm not sure what the details would be. Thanks.

Comment 4 by mthiesse@chromium.org, Sep 5 2017

We would need a test page that tries to play video during the vrdisplayactivate event. We should fix the video test page on webvr.info to do this.

Comment 5 by btebbs@chromium.org, Jul 4 2018

Components: Blink>WebXR

Sign in to add a comment