New issue
Advanced search Search tips

Issue 756556 link

Starred by 3 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 757444

Blocking:
issue 751556



Sign in to add a comment

Strange behaviour when deleting current profile with ForceBrowserSignin enabled

Project Member Reported by tnagel@chromium.org, Aug 17 2017

Issue description

Chrome Version: ToT
OS: Linux

What steps will reproduce the problem?
(1) Start with fresh user-data directory
(2) Disable ForceBrowserSignin
(3) Create 3 different profiles (but don't sign into them)
(4) Enable ForceBrowserSignin, restart browser
(5) Log into Profile 1, adding a GAIA account
(6) Delete the current profile

What is the expected result?
The profile picker should be shown.

What happens instead?
The sign-in prompt is shown, but it is not clear for which of the two remaining profiles. Also, the window that was decorated "Profile 1" now has lost that decoration. But the window isn't closed. Thus we have now an open window the profile of which has been deleted -- this seems a strange state to be in.
 

Comment 1 by zmin@chromium.org, Aug 18 2017

Hi, 

When the last unlocked profile is deleted, UserManager will pop up a sign in prompt  because user has to sign in to use Chrome again. I agree that if there're more than 1 locked profiles, this might confuse user. I think it could be changed to open sign-in prompt iff there is one locked profile. 

For window closing issue, I can't reproduce this on my win10. I'll find a linux machine and try again later.

Thanks a lot for the reporting.

Comment 2 by tnagel@chromium.org, Aug 21 2017

Blockedon: 757444

Comment 3 by tnagel@chromium.org, Aug 21 2017

Tracking auto-opening a random profile under issue 757444.

Comment 4 by tnagel@chromium.org, Aug 21 2017

I can't repro the strange window thing anymore. Closing this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740a2d59fcf00ddec60d3df08a5264f01b51dc63

commit 740a2d59fcf00ddec60d3df08a5264f01b51dc63
Author: Owen Min <zmin@chromium.org>
Date: Wed Aug 23 21:49:47 2017

Show sign in dialog iff there is one locked profile.

After deleting a profile, UserManager and sign in dialog will be displayed if the fallback profile is locked.
However, if force-sign-in is enabled and there is more than one profiles, sign in dialog will not be displayed.
Because it's not clear for which of the remaining profiles is being used.

Bug: 756556
Change-Id: Ie11520b148f054c9045e57b7064a96f8925a9d3f
Reviewed-on: https://chromium-review.googlesource.com/626758
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496818}
[modify] https://crrev.com/740a2d59fcf00ddec60d3df08a5264f01b51dc63/chrome/browser/ui/webui/profile_helper.cc

Comment 6 by tnagel@chromium.org, Aug 28 2017

Cc: tnagel@chromium.org
Owen, would you mind to show the picker, always? (This is described in issue 757444.) Imho that would be even clearer.

Comment 7 by tnagel@chromium.org, Aug 28 2017

To be clear: By "always" I mean "always after the current profile has been deleted".

Comment 8 by zmin@chromium.org, Aug 28 2017

Do you mean always show the User Manager even the fallback profile is not locked? Or do you mean even the force-sign-in policy is not enabled?

Comment 9 by tnagel@chromium.org, Aug 29 2017

Independent of the force sign-in policy, I think that the profile picker should always be shown when the current profile is deleted and one or more other profiles are existing so that the user can make a choice whether they would like to see the contents of one of the existing profiles or not. We shouldn't force the contents of a profile into the face of the user without being requested by the user.
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 28 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 751556
Likewise, deleting the only existing profile shouldn't spring a login screen into the user's face.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6139a048600eb65ebe2420a355f391a89fbb1fa6

commit 6139a048600eb65ebe2420a355f391a89fbb1fa6
Author: Owen Min <zmin@chromium.org>
Date: Thu Nov 09 23:25:55 2017

Deleting the last profile when force-sign-in policy enabled won't trigger sign in dialog

As the request of #11 of crbug.com/756556, when force-sign-in policy is enabled
and the fallback profile is locked, there won't be any sign-in dialog opened
automatically.
Note that the fallback profile will still be opened if it is not locked. This
is a behavior regardless the policy status. There is a separate issue to improve
this UX.

Bug: 756556
Change-Id: I8d11c182b2a88d22db8912950f0814c98f2cc9dc
Reviewed-on: https://chromium-review.googlesource.com/761478
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515343}
[modify] https://crrev.com/6139a048600eb65ebe2420a355f391a89fbb1fa6/chrome/browser/ui/webui/profile_helper.cc

Status: Assigned (was: Available)
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment