LocalStorageContextMojoTestWithService.InvalidVersionOnDisk is flaky |
||||||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=LocalStorageContextMojoTestWithService.InvalidVersionOnDisk e.g. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/44887 [ RUN ] LocalStorageContextMojoTestWithService.InvalidVersionOnDisk ../../content/browser/dom_storage/local_storage_context_mojo_unittest.cc:992: Failure Value of: DoTestGet(context, key, &result) Actual: true Expected: false [ FAILED ] LocalStorageContextMojoTestWithService.InvalidVersionOnDisk (59 ms)
,
Aug 24 2017
,
Oct 2 2017
Seems to actually be flaky on at least other linux platforms as well. Just very infrequently failing.
,
Oct 2 2017
Also interesting, but unclear if related, one run seem to have failed differently: [ RUN ] LocalStorageContextMojoTestWithService.InvalidVersionOnDisk content_unittests: ../../third_party/leveldatabase/src/db/skiplist.h:344: void leveldb::SkipList<const char *, leveldb::MemTable::KeyComparator>::Insert(const Key &) [Key = const char *, Comparator = leveldb::MemTable::KeyComparator]: Assertion `x == __null || !Equal(key, x->key)' failed. Received signal 6 #0 0x0000f2cb1c37 base::debug::StackTrace::StackTrace() #1 0x0000f2cafc3c base::debug::StackTrace::StackTrace() #2 0x0000f2cb15c8 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x0000f76e5420 ([vdso]+0x41f) #4 0x0000f76e5440 ([vdso]+0x43f) #5 0x0000e169c687 gsignal #6 0x0000e169fab3 abort #7 0x0000e16957c7 <unknown> #8 0x0000e1695877 __assert_fail #9 0x00000ba688c1 leveldb::SkipList<>::Insert() #10 0x00000ba67e1a leveldb::MemTable::Add() #11 0x00000ba80d87 leveldb::(anonymous namespace)::MemTableInserter::Put() #12 0x00000ba80033 leveldb::WriteBatch::Iterate() #13 0x00000ba80800 leveldb::WriteBatchInternal::InsertInto() #14 0x00000ba4ba77 leveldb::DBImpl::RecoverLogFile() #15 0x00000ba4b18c leveldb::DBImpl::Recover() #16 0x00000ba543c8 leveldb::DB::Open() #17 0x00000ba3fe7a leveldb_env::DBTracker::OpenDatabase() #18 0x00000ba402dc leveldb_env::OpenDB() #19 0x00000bf7edf4 leveldb::LevelDBServiceImpl::OpenWithOptions() #20 0x00000b0e243b leveldb::mojom::LevelDBServiceStubDispatch::AcceptWithResponder() #21 0x0000089d6d03 leveldb::mojom::LevelDBServiceStub<>::AcceptWithResponder() #22 0x0000f50af9f2 mojo::InterfaceEndpointClient::HandleValidatedMessage() #23 0x0000f50aee3d mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() #24 0x0000f50ad48c mojo::FilterChain::Accept() #25 0x0000f50b37fa mojo::InterfaceEndpointClient::HandleIncomingMessage() #26 0x0000f50cde12 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #27 0x0000f50cd066 mojo::internal::MultiplexRouter::Accept() #28 0x0000f50ad48c mojo::FilterChain::Accept() #29 0x0000f509cecc mojo::Connector::ReadSingleMessage() #30 0x0000f509e184 mojo::Connector::ReadAllAvailableMessages() #31 0x0000f509df36 mojo::Connector::OnHandleReadyInternal() #32 0x0000f509ddca mojo::Connector::OnWatcherHandleReady() #33 0x0000f50a2622 _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIPS3_JjEEEvS5_OT_DpOT0_ #34 0x0000f50a2530 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_ #35 0x0000f50a2490 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEEOj #36 0x0000f50a2368 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEOj #37 0x0000f5096445 _ZNKR4base17RepeatingCallbackIFvjEE3RunEj #38 0x0000f50a11e1 mojo::SimpleWatcher::DiscardReadyState() #39 0x0000f50a15b1 _ZN4base8internal13FunctorTraitsIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEvE6InvokeIJS6_jSA_EEEvSC_DpOT_ #40 0x0000f50a150e _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS8_jSC_EEEvOT_DpOT0_ #41 0x0000f50a1472 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS5_EEEFvjSB_EE7RunImplIRKSD_RKNSt3__15tupleIJS5_EEEJLj0EEEEvOT_OT0_NSK_16integer_sequenceIjJXspT1_EEEEOjSB_ #42 0x0000f50a132c _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS5_EEEFvjSB_EE3RunEPNS0_13BindStateBaseEOjSB_ #43 0x0000f2b958cb _ZNKR4base17RepeatingCallbackIFvjRKN4mojo18HandleSignalsStateEEE3RunEjS4_ #44 0x0000f2b94e3e mojo::SimpleWatcher::OnHandleReady() #45 0x0000f2b963db _ZN4base8internal13FunctorTraitsIMN4mojo13SimpleWatcherEFvijRKNS2_18HandleSignalsStateEEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKiRKjS6_EEEvS8_OT_DpOT0_ #46 0x0000f2b962f2 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo13SimpleWatcherEFvijRKNS4_18HandleSignalsStateEERKNS_7WeakPtrIS5_EEJRKiRKjS8_EEEvOT_OT0_DpOT1_ #47 0x0000f2b96214 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLj0ELj1ELj2ELj3EEEEvOT_OT0_NSI_16integer_sequenceIjJXspT1_EEEE #48 0x0000f2b95ff1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE3RunEPNS0_13BindStateBaseE #49 0x0000f2c56398 _ZNO4base12OnceCallbackIFvvEE3RunEv #50 0x0000f2cb6e08 base::debug::TaskAnnotator::RunTask() #51 0x0000f2ef8dcc base::internal::TaskTracker::RunOrSkipTask() #52 0x0000f2efb6bb base::internal::TaskTrackerPosix::RunOrSkipTask() #53 0x00000b80fb74 base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask() #54 0x0000f2ef6fc2 base::internal::TaskTracker::RunNextTask() #55 0x0000f2ee05ad base::internal::SchedulerWorker::Thread::ThreadMain() #56 0x0000f2f09cd3 base::(anonymous namespace)::ThreadFunc() #57 0x0000f76b8f72 start_thread #58 0x0000e175c3ee clone gs: 00000063 fs: 00000000 es: 0000002b ds: 0000002b edi: e181b000 esi: f76d7000 ebp: d987a128 esp: d9879ec4 ebx: 00000fb3 edx: 00000006 ecx: 0000104c eax: 00000000 trp: 00000000 err: 00000000 ip: f76e5440 cs: 00000023 efl: 00200296 usp: d9879ec4 ss: 0000002b [end of stack trace] Calling _exit(1). Core file will not be generated. [541/5435] LocalStorageContextMojoTestWithService.InvalidVersionOnDisk (CRASHED)
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e66a1ce2aacce78b76fd5b08be226b92fcf3cdb commit 7e66a1ce2aacce78b76fd5b08be226b92fcf3cdb Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Nov 22 00:08:34 2017 [LocalStorage] Fix flaky tests Bug: 756550 , 787373 Change-Id: Ib2415821b2137f11b93d3f9d84afe794388abca3 Reviewed-on: https://chromium-review.googlesource.com/782641 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#518469} [modify] https://crrev.com/7e66a1ce2aacce78b76fd5b08be226b92fcf3cdb/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
,
Nov 22 2017
,
Jun 19 2018
Note: this test is still very flakey on android: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=LocalStorageContextMojoTestWithService.InvalidVersionOnDisk Going to re-disable.
,
Jun 19 2018
Assigning to Marijn as he owns Local Storage more than I do.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17cbf497b9c533ac8c91129ae81d8578a51d5a71 commit 17cbf497b9c533ac8c91129ae81d8578a51d5a71 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Jun 19 20:50:08 2018 Disable LocalStorageContextMojoTestWithService.InvalidVersionOnDisk on Android Test is very flakey. On many bots, it fails at least once per run. Bug: 756550 Change-Id: I8eac5aa374999a20382e30c689761bedb6f23c65 Reviewed-on: https://chromium-review.googlesource.com/1106760 Commit-Queue: agrieve <agrieve@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568596} [modify] https://crrev.com/17cbf497b9c533ac8c91129ae81d8578a51d5a71/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347bc13bffedcfbbabb7d17165a0721641f9299d commit 347bc13bffedcfbbabb7d17165a0721641f9299d Author: Marijn Kruisselbrink <mek@chromium.org> Date: Tue Jun 19 23:17:41 2018 [DOMStorage] Don't just flush main loop in tests, but flush all threads. Flushing just the main thread could cause tasks on the leveldb and/or file task runners to not be executed when we expected them to. Flushing those task runners as well should reduce test flakiness. And re-enable LocalStorageContextMojoTestWithService.InvalidVersionOnDisk as this seems to fix the flakiness in that test. Bug: 756550 Change-Id: I7fbdfad9ed5581a0a2dbd030500cc80b9eb2fea1 Reviewed-on: https://chromium-review.googlesource.com/1107117 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568635} [modify] https://crrev.com/347bc13bffedcfbbabb7d17165a0721641f9299d/content/browser/dom_storage/local_storage_context_mojo_unittest.cc [modify] https://crrev.com/347bc13bffedcfbbabb7d17165a0721641f9299d/content/browser/dom_storage/test/mojo_test_with_file_service.h
,
Jun 20 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 17 2017