New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756543 link

Starred by 1 user
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CSS grid highlight is wrong with align-content and/or justify-content property is set to space-around

Project Member Reported by eostroukhov@chromium.org, Aug 17 2017 
1. Open https://codepen.io/rachelandrew/pen/kXvWVN
2. Highlight the grid.

Grid lines are drawn in the wrong location.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437

commit cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Wed Aug 23 17:40:13 2017

[DevTools] Fix CSS grid highligh alignment

This fixes highlight for CSS grids that have align-content and/or
justify-content set to values other then start.

Also, highlights array now contains column positions and not column
width to avoid accumulating rounding errors.

Bug:  756543 
Change-Id: I183ad6553d7ffca466191043232ff1573b9b2238
Reviewed-on: https://chromium-review.googlesource.com/621402
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496726}
[modify] https://crrev.com/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437/third_party/WebKit/LayoutTests/inspector/elements/highlight/highlight-css-grid-expected.txt
[modify] https://crrev.com/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437/third_party/WebKit/LayoutTests/inspector/elements/highlight/highlight-css-grid.html
[modify] https://crrev.com/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437/third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html
[modify] https://crrev.com/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/cb016cb5f59a51bb7ddba8a40e0ecb7fbb58d437/third_party/WebKit/Source/core/layout/LayoutGrid.h

Comment 2 by eostroukhov@chromium.org, Oct 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment