Cannot switch from canary to dev channel |
|||
Issue description
Repro:
(1) Start on canary channel.
(2) Open settings.
(3) Click 3-line button in upper left, click on About Chrome OS.
(4) Attempt to switch to dev channel.
Nothing happens.
JS Console:
crisper.js:formatted:1483 Uncaught (in promise) Error: Assertion failed: Unreachable code hit
at assert (crisper.js:formatted:1483)
at assertNotReached (crisper.js:formatted:1494)
at Object.browserChannelToI18nId (crisper.js:formatted:2275)
at browserProxy.getChannelInfo.then.info (crisper.js:formatted:5136)
at <anonymous>
That error corresponds to:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js?q=assertNotReached
It seems the canary channel isn't included in that switch statement.
,
Aug 22 2017
Yep, |channel| was something like 'canary', but I don't remember exactly what the string was. Sorry - should have noted that down.
,
Aug 22 2017
Interestingly we don't seem to handle the Canary channel in the UI at all. The simplest thing is probably to just disable the UI since it's not really a user-facing channel; switching from the Canary channel isn't something one generally would want to do.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b966f3d04dd81c1acd94510b15e918ee737550b7 commit b966f3d04dd81c1acd94510b15e918ee737550b7 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Aug 28 19:11:39 2017 Settings > About: Handle canary channel This changes the Settings page to show the canary channel, but does not provide UI to allow setting the channel to canary. It also removes / cleans up some unused code related to the about/help page. Bug: 756542 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4ef77ad9e4f20fe27eca1e465ee91533b0f3b23e Reviewed-on: https://chromium-review.googlesource.com/630557 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#497828} [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chrome/app/settings_strings.grdp [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js [delete] https://crrev.com/ee77a567d98db38bfe3aa72ed4808f4b67beffba/chrome/browser/ui/webui/help/help_handler.cc [delete] https://crrev.com/ee77a567d98db38bfe3aa72ed4808f4b67beffba/chrome/browser/ui/webui/help/help_handler.h [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chrome/browser/ui/webui/help/help_utils_chromeos.cc [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chrome/browser/ui/webui/help/help_utils_chromeos.h [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chrome/browser/ui/webui/help/version_updater_chromeos.cc [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chromeos/chromeos_switches.cc [modify] https://crrev.com/b966f3d04dd81c1acd94510b15e918ee737550b7/chromeos/chromeos_switches.h
,
Aug 29 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by steve...@chromium.org
, Aug 22 2017Status: Started (was: Untriaged)